All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Shannon Zhao <zhaoshenglong@huawei.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"julien.grall@citrix.com" <julien.grall@citrix.com>,
	"freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>,
	"matt.fleming@intel.com" <matt.fleming@intel.com>,
	"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>,
	"peter.huangpeng@huawei.com" <peter.huangpeng@huawei.com>,
	"shannon.zhao@linaro.org" <shannon.zhao@linaro.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	<daniel.kiper@oracle.com>
Subject: Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters
Date: Thu, 10 Sep 2015 12:37:57 +0100	[thread overview]
Message-ID: <alpine.DEB.2.02.1509101223580.2672@kaball.uk.xensource.com> (raw)
In-Reply-To: <20150910112418.GC29293@leverpostej>

On Thu, 10 Sep 2015, Mark Rutland wrote:
> > > Does Xen not talk to EFI itself and/or give the kernel a virtual EFI
> > > interface?
> > 
> > Xen talks to EFI itself but the interface provided to dom0 is somewhat
> > different: there are no BootServices (Xen calls ExitBootServices before
> > running the kernel), and the RuntimeServices go via hypercalls (see
> > drivers/xen/efi.c).
> 
> That's somewhat hideous; a non Xen-aware OS wouild presumably die if
> trying to use any runtime services the normal way? I'm not keen on
> describing things that the OS cannot use.
 
I agree that is somewhat hideous, but a non-Xen aware OS traditionally
has never been able to even boot as Dom0. On ARM it can, but it still
wouldn't be very useful (one couldn't use it to start other guests).


> Why can't Xen give a virtual EFI interface to Dom0 / guests? e.g.
> create pages of RuntimeServicesCode that are trivial assembly shims
> doing hypercalls, and plumb these into the virtual EFI memory map and
> tables?
> 
> That would keep things sane for any guest, allow for easy addition of
> EFI features, and you could even enter the usual EFI entry point,
> simulate ExitBootServices(), SetVirtualAddressMap(), and allow the guest
> to make things sane for itself...

That's the way it was done on x86 and now we have common code both in
Linux (drivers/xen/efi.c) and Xen (xen/common/efi) which implement this
scheme.  Switching to a different solution for ARM, would mean diverging
with x86, which is not nice, or reimplementing the x86 solution too,
which is expensive.

BTW I think that the idea you proposed was actually considered at the
time and deemed hard to implement, if I recall correctly.


In any case this should be separate from the shim ABI discussion.

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Stefano Stabellini
	<stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>,
	Shannon Zhao
	<zhaoshenglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org"
	<Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
	"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org"
	<xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org>,
	"julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org"
	<julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
	"freebsd-arm-h+KGxgPPiopAfugRpC6u6w@public.gmane.org"
	<freebsd-arm-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>,
	"matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"jbeulich-IBi9RG/b67k@public.gmane.org" <jbeulich@su>
Subject: Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters
Date: Thu, 10 Sep 2015 12:37:57 +0100	[thread overview]
Message-ID: <alpine.DEB.2.02.1509101223580.2672@kaball.uk.xensource.com> (raw)
In-Reply-To: <20150910112418.GC29293@leverpostej>

On Thu, 10 Sep 2015, Mark Rutland wrote:
> > > Does Xen not talk to EFI itself and/or give the kernel a virtual EFI
> > > interface?
> > 
> > Xen talks to EFI itself but the interface provided to dom0 is somewhat
> > different: there are no BootServices (Xen calls ExitBootServices before
> > running the kernel), and the RuntimeServices go via hypercalls (see
> > drivers/xen/efi.c).
> 
> That's somewhat hideous; a non Xen-aware OS wouild presumably die if
> trying to use any runtime services the normal way? I'm not keen on
> describing things that the OS cannot use.
 
I agree that is somewhat hideous, but a non-Xen aware OS traditionally
has never been able to even boot as Dom0. On ARM it can, but it still
wouldn't be very useful (one couldn't use it to start other guests).


> Why can't Xen give a virtual EFI interface to Dom0 / guests? e.g.
> create pages of RuntimeServicesCode that are trivial assembly shims
> doing hypercalls, and plumb these into the virtual EFI memory map and
> tables?
> 
> That would keep things sane for any guest, allow for easy addition of
> EFI features, and you could even enter the usual EFI entry point,
> simulate ExitBootServices(), SetVirtualAddressMap(), and allow the guest
> to make things sane for itself...

That's the way it was done on x86 and now we have common code both in
Linux (drivers/xen/efi.c) and Xen (xen/common/efi) which implement this
scheme.  Switching to a different solution for ARM, would mean diverging
with x86, which is not nice, or reimplementing the x86 solution too,
which is expensive.

BTW I think that the idea you proposed was actually considered at the
time and deemed hard to implement, if I recall correctly.


In any case this should be separate from the shim ABI discussion.

WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters
Date: Thu, 10 Sep 2015 12:37:57 +0100	[thread overview]
Message-ID: <alpine.DEB.2.02.1509101223580.2672@kaball.uk.xensource.com> (raw)
In-Reply-To: <20150910112418.GC29293@leverpostej>

On Thu, 10 Sep 2015, Mark Rutland wrote:
> > > Does Xen not talk to EFI itself and/or give the kernel a virtual EFI
> > > interface?
> > 
> > Xen talks to EFI itself but the interface provided to dom0 is somewhat
> > different: there are no BootServices (Xen calls ExitBootServices before
> > running the kernel), and the RuntimeServices go via hypercalls (see
> > drivers/xen/efi.c).
> 
> That's somewhat hideous; a non Xen-aware OS wouild presumably die if
> trying to use any runtime services the normal way? I'm not keen on
> describing things that the OS cannot use.
 
I agree that is somewhat hideous, but a non-Xen aware OS traditionally
has never been able to even boot as Dom0. On ARM it can, but it still
wouldn't be very useful (one couldn't use it to start other guests).


> Why can't Xen give a virtual EFI interface to Dom0 / guests? e.g.
> create pages of RuntimeServicesCode that are trivial assembly shims
> doing hypercalls, and plumb these into the virtual EFI memory map and
> tables?
> 
> That would keep things sane for any guest, allow for easy addition of
> EFI features, and you could even enter the usual EFI entry point,
> simulate ExitBootServices(), SetVirtualAddressMap(), and allow the guest
> to make things sane for itself...

That's the way it was done on x86 and now we have common code both in
Linux (drivers/xen/efi.c) and Xen (xen/common/efi) which implement this
scheme.  Switching to a different solution for ARM, would mean diverging
with x86, which is not nice, or reimplementing the x86 solution too,
which is expensive.

BTW I think that the idea you proposed was actually considered at the
time and deemed hard to implement, if I recall correctly.


In any case this should be separate from the shim ABI discussion.

  parent reply	other threads:[~2015-09-10 11:40 UTC|newest]

Thread overview: 182+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10  8:41 [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters Shannon Zhao
2015-09-10  8:41 ` Shannon Zhao
2015-09-10  8:41 ` Shannon Zhao
2015-09-10  9:52 ` Mark Rutland
2015-09-10  9:52   ` Mark Rutland
2015-09-10  9:52   ` Mark Rutland
2015-09-10 10:19   ` Stefano Stabellini
2015-09-10 10:19   ` Stefano Stabellini
2015-09-10 10:19     ` Stefano Stabellini
2015-09-10 10:19     ` Stefano Stabellini
2015-09-10 11:24     ` Mark Rutland
2015-09-10 11:24     ` Mark Rutland
2015-09-10 11:24       ` Mark Rutland
2015-09-10 11:24       ` Mark Rutland
2015-09-10 11:37       ` Stefano Stabellini
2015-09-10 11:37       ` Stefano Stabellini [this message]
2015-09-10 11:37         ` Stefano Stabellini
2015-09-10 11:37         ` Stefano Stabellini
2015-09-10 12:15         ` Mark Rutland
2015-09-10 12:15         ` Mark Rutland
2015-09-10 12:15           ` Mark Rutland
2015-09-10 12:15           ` Mark Rutland
2015-09-10 12:58           ` [Xen-devel] " Ian Campbell
2015-09-10 12:58             ` Ian Campbell
2015-09-10 12:58             ` Ian Campbell
2015-09-10 13:08             ` Jan Beulich
2015-09-10 13:08               ` Jan Beulich
2015-09-10 13:08               ` Jan Beulich
2015-09-10 13:30               ` Ian Campbell
2015-09-10 13:30               ` [Xen-devel] " Ian Campbell
2015-09-10 13:30                 ` Ian Campbell
2015-09-10 13:30                 ` Ian Campbell
2015-09-10 13:08             ` Jan Beulich
2015-09-10 12:58           ` Ian Campbell
2015-09-10 13:52           ` Stefano Stabellini
2015-09-10 13:52             ` Stefano Stabellini
2015-09-10 13:52             ` Stefano Stabellini
2015-09-10 14:13             ` Leif Lindholm
2015-09-10 14:13               ` Leif Lindholm
2015-09-10 14:13               ` Leif Lindholm
2015-09-10 14:13             ` Leif Lindholm
2015-09-10 14:49             ` Mark Rutland
2015-09-10 14:49               ` Mark Rutland
2015-09-10 14:49               ` Mark Rutland
2015-09-10 16:10               ` Stefano Stabellini
2015-09-10 16:10                 ` Stefano Stabellini
2015-09-10 16:10                 ` Stefano Stabellini
2015-09-10 16:23                 ` Mark Rutland
2015-09-10 16:23                   ` Mark Rutland
2015-09-10 16:23                   ` Mark Rutland
2015-09-11 12:46                   ` Daniel Kiper
2015-09-11 12:46                     ` Daniel Kiper
2015-09-11 12:46                     ` Daniel Kiper
2015-09-11 13:14                     ` Stefano Stabellini
2015-09-11 13:14                     ` Stefano Stabellini
2015-09-11 13:14                       ` Stefano Stabellini
2015-09-11 13:14                       ` Stefano Stabellini
2015-09-11 13:30                       ` Ard Biesheuvel
2015-09-11 13:30                         ` Ard Biesheuvel
2015-09-11 13:30                         ` Ard Biesheuvel
2015-09-11 15:45                         ` Daniel Kiper
2015-09-11 15:45                           ` Daniel Kiper
2015-09-11 15:45                           ` Daniel Kiper
2015-09-14  8:42                           ` Shannon Zhao
2015-09-14  8:42                             ` Shannon Zhao
2015-09-14  8:42                             ` Shannon Zhao
2015-09-14  9:09                             ` Ard Biesheuvel
2015-09-14  9:09                               ` Ard Biesheuvel
2015-09-14  9:09                               ` Ard Biesheuvel
2015-09-14  9:31                               ` Shannon Zhao
2015-09-14  9:31                                 ` Shannon Zhao
2015-09-14  9:31                                 ` Shannon Zhao
2015-09-14  9:36                                 ` Ard Biesheuvel
2015-09-14  9:36                                 ` Ard Biesheuvel
2015-09-14  9:36                                   ` Ard Biesheuvel
2015-09-14  9:36                                   ` Ard Biesheuvel
2015-09-14 10:39                                   ` Jan Beulich
2015-09-14 10:39                                   ` [Xen-devel] " Jan Beulich
2015-09-14 10:39                                     ` Jan Beulich
2015-09-14 10:39                                     ` Jan Beulich
2015-09-14 11:16                                     ` Ard Biesheuvel
2015-09-14 11:16                                       ` Ard Biesheuvel
2015-09-14 11:16                                       ` Ard Biesheuvel
2015-09-14 11:34                                       ` Jan Beulich
2015-09-14 11:34                                         ` Jan Beulich
2015-09-14 11:34                                         ` Jan Beulich
2015-09-14 11:34                                       ` Jan Beulich
2015-09-14 11:16                                     ` Ard Biesheuvel
2015-09-14  9:09                             ` Ard Biesheuvel
2015-09-11 15:45                         ` Daniel Kiper
2015-09-11 16:33                         ` Mark Rutland
2015-09-11 16:33                           ` Mark Rutland
2015-09-11 16:33                           ` Mark Rutland
2015-09-11 16:33                         ` Mark Rutland
2015-09-11 13:30                       ` Ard Biesheuvel
2015-09-11 16:25                     ` Mark Rutland
2015-09-11 16:25                     ` Mark Rutland
2015-09-11 16:25                       ` Mark Rutland
2015-09-11 16:25                       ` Mark Rutland
2015-09-12 11:36                       ` Daniel Kiper
2015-09-12 11:36                         ` Daniel Kiper
2015-09-12 11:36                         ` Daniel Kiper
2015-09-14  9:25                         ` Mark Rutland
2015-09-14  9:25                         ` Mark Rutland
2015-09-14  9:25                           ` Mark Rutland
2015-09-14  9:25                           ` Mark Rutland
2015-09-14  9:43                           ` Ard Biesheuvel
2015-09-14  9:43                           ` Ard Biesheuvel
2015-09-14  9:43                             ` Ard Biesheuvel
2015-09-14  9:57                             ` Ian Campbell
     [not found]                             ` <CAKv+Gu9ER1cKvPHobq-wo7ggPesJj4OQ7=aTr24GVpubHvVqjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14  9:57                               ` Ian Campbell
2015-09-14  9:57                                 ` Ian Campbell
2015-09-14 10:02                                 ` Ard Biesheuvel
     [not found]                                 ` <1442224673.3549.131.camel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2015-09-14 10:02                                   ` Ard Biesheuvel
2015-09-14 10:02                                     ` Ard Biesheuvel
     [not found]                                     ` <CAKv+Gu_Gh649EwdtodLY9Q28JhqYg8o6RShXXH1ZbxsfYRfi2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 10:25                                       ` Ian Campbell
2015-09-14 10:25                                         ` Ian Campbell
2015-09-14 10:25                                     ` Ian Campbell
2015-09-14 12:28                               ` Daniel Kiper
2015-09-14 12:28                                 ` Daniel Kiper
     [not found]                                 ` <20150914122858.GI4530-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org>
2015-09-14 13:09                                   ` Ard Biesheuvel
2015-09-14 13:09                                     ` Ard Biesheuvel
2015-09-14 13:57                                     ` Daniel Kiper
     [not found]                                     ` <CAKv+Gu_z2X=9-qgoKTS7dKLqtSUvysyu9LzZryJqcSR4X8Ss6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 13:57                                       ` Daniel Kiper
2015-09-14 13:57                                         ` Daniel Kiper
2015-09-14 13:09                                 ` Ard Biesheuvel
2015-09-14 12:28                             ` Daniel Kiper
2015-09-14  9:47                           ` Stefano Stabellini
2015-09-14  9:47                           ` Stefano Stabellini
2015-09-14  9:47                             ` Stefano Stabellini
2015-09-14  9:47                             ` Stefano Stabellini
2015-09-14 12:19                           ` Daniel Kiper
2015-09-14 12:19                             ` Daniel Kiper
2015-09-14 12:19                             ` Daniel Kiper
2015-09-14 12:19                           ` Daniel Kiper
2015-09-12 11:36                       ` Daniel Kiper
2015-09-11 12:46                   ` Daniel Kiper
2015-09-10 16:23                 ` Mark Rutland
2015-09-11 11:00                 ` Ian Campbell
2015-09-11 11:00                 ` Ian Campbell
2015-09-11 11:00                   ` Ian Campbell
2015-09-11 11:00                   ` Ian Campbell
2015-09-10 16:10               ` Stefano Stabellini
2015-09-10 14:49             ` Mark Rutland
2015-09-10 13:52           ` Stefano Stabellini
2015-09-10 12:55         ` Jan Beulich
2015-09-10 12:55           ` Jan Beulich
2015-09-10 12:55           ` Jan Beulich
2015-09-10 14:53           ` Mark Rutland
2015-09-10 14:53             ` Mark Rutland
2015-09-10 14:53             ` Mark Rutland
2015-09-10 15:06             ` Jan Beulich
2015-09-10 15:06               ` Jan Beulich
2015-09-10 15:06               ` Jan Beulich
2015-09-11 16:36               ` Mark Rutland
2015-09-11 16:36                 ` Mark Rutland
2015-09-11 16:36                 ` Mark Rutland
2015-09-11 16:36               ` Mark Rutland
2015-09-10 15:06             ` Jan Beulich
2015-09-10 12:55         ` Jan Beulich
2015-09-10  9:52 ` Mark Rutland
2015-09-10 11:32 ` Andrew Turner
2015-09-10 11:32   ` Andrew Turner
2015-09-10 11:32   ` Andrew Turner
2015-09-10 11:48   ` Julien Grall
2015-09-10 11:48     ` Julien Grall
2015-09-10 11:48     ` Julien Grall
2015-09-10 12:05     ` Roger Pau Monné
2015-09-10 12:05     ` Roger Pau Monné
2015-09-10 12:05       ` Roger Pau Monné
2015-09-10 12:05       ` Roger Pau Monné
2015-09-10 12:53       ` Julien Grall
2015-09-10 12:53       ` [Xen-devel] " Julien Grall
2015-09-10 12:53         ` Julien Grall
2015-09-10 12:53         ` Julien Grall
2015-09-10 11:48   ` Julien Grall
2015-09-10 11:32 ` Andrew Turner
2015-09-17 11:43 ` Shannon Zhao
2015-09-17 11:43 ` Shannon Zhao
2015-09-17 11:43   ` Shannon Zhao
2015-09-17 11:43   ` Shannon Zhao
  -- strict thread matches above, loose matches on Subject: below --
2015-09-10  8:41 Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1509101223580.2672@kaball.uk.xensource.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=daniel.kiper@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=freebsd-arm@freebsd.org \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matt.fleming@intel.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=shannon.zhao@linaro.org \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.