From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org,
rander.wang@linux.intel.com, hui.wang@canonical.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
bard.liao@intel.com
Subject: Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
Date: Tue, 11 May 2021 17:50:57 +0530 [thread overview]
Message-ID: <YJp2qYH1IQxDjgNA@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210511025035.25233-1-yung-chuan.liao@linux.intel.com>
On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
> struct adr_remap *map = dmi_id->driver_data;
> ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, hui.wang@canonical.com,
sanyog.r.kale@intel.com, rander.wang@linux.intel.com,
bard.liao@intel.com
Subject: Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
Date: Tue, 11 May 2021 17:50:57 +0530 [thread overview]
Message-ID: <YJp2qYH1IQxDjgNA@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210511025035.25233-1-yung-chuan.liao@linux.intel.com>
On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
> struct adr_remap *map = dmi_id->driver_data;
> ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2021-05-11 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 2:50 [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization Bard Liao
2021-05-11 2:50 ` Bard Liao
2021-05-11 12:20 ` Vinod Koul [this message]
2021-05-11 12:20 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJp2qYH1IQxDjgNA@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.