* [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
@ 2021-05-11 2:50 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-05-11 2:50 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, gregkh, srinivas.kandagatla,
rander.wang, hui.wang, pierre-louis.bossart, sanyog.r.kale,
bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
cppcheck warning:
drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
for 'map'. The initialized value is overwritten before it is
read. [redundantInitialization]
for (map = dmi_id->driver_data; map->adr; map++) {
^
drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
struct adr_remap *map = dmi_id->driver_data;
^
drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
for (map = dmi_id->driver_data; map->adr; map++) {
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/dmi-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 82061c1d9835..5db0a2443a1d 100644
--- a/drivers/soundwire/dmi-quirks.c
+++ b/drivers/soundwire/dmi-quirks.c
@@ -80,7 +80,7 @@ u64 sdw_dmi_override_adr(struct sdw_bus *bus, u64 addr)
/* check if any address remap quirk applies */
dmi_id = dmi_first_match(adr_remap_quirk_table);
if (dmi_id) {
- struct adr_remap *map = dmi_id->driver_data;
+ struct adr_remap *map;
for (map = dmi_id->driver_data; map->adr; map++) {
if (map->adr == addr) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
@ 2021-05-11 2:50 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-05-11 2:50 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, gregkh, linux-kernel, pierre-louis.bossart, hui.wang,
sanyog.r.kale, rander.wang, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
cppcheck warning:
drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
for 'map'. The initialized value is overwritten before it is
read. [redundantInitialization]
for (map = dmi_id->driver_data; map->adr; map++) {
^
drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
struct adr_remap *map = dmi_id->driver_data;
^
drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
for (map = dmi_id->driver_data; map->adr; map++) {
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/dmi-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 82061c1d9835..5db0a2443a1d 100644
--- a/drivers/soundwire/dmi-quirks.c
+++ b/drivers/soundwire/dmi-quirks.c
@@ -80,7 +80,7 @@ u64 sdw_dmi_override_adr(struct sdw_bus *bus, u64 addr)
/* check if any address remap quirk applies */
dmi_id = dmi_first_match(adr_remap_quirk_table);
if (dmi_id) {
- struct adr_remap *map = dmi_id->driver_data;
+ struct adr_remap *map;
for (map = dmi_id->driver_data; map->adr; map++) {
if (map->adr == addr) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
2021-05-11 2:50 ` Bard Liao
@ 2021-05-11 12:20 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-05-11 12:20 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, linux-kernel, gregkh, srinivas.kandagatla,
rander.wang, hui.wang, pierre-louis.bossart, sanyog.r.kale,
bard.liao
On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
> struct adr_remap *map = dmi_id->driver_data;
> ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization
@ 2021-05-11 12:20 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-05-11 12:20 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, gregkh, linux-kernel, pierre-louis.bossart, hui.wang,
sanyog.r.kale, rander.wang, bard.liao
On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
> struct adr_remap *map = dmi_id->driver_data;
> ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
> for (map = dmi_id->driver_data; map->adr; map++) {
> ^
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 12:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 2:50 [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization Bard Liao
2021-05-11 2:50 ` Bard Liao
2021-05-11 12:20 ` Vinod Koul
2021-05-11 12:20 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.