From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Drew Richardson <drew.richardson@arm.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Dave P Martin <Dave.Martin@arm.com>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wade Cherry <Wade.Cherry@arm.com>,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH] ARM: Mark ret_fast_syscall as a function
Date: Thu, 6 Aug 2015 13:30:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1508061327510.1515@knanqh.ubzr> (raw)
In-Reply-To: <20150806170758.GA26691@dreric01-gentoo.localdomain>
On Thu, 6 Aug 2015, Drew Richardson wrote:
> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> >
> > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> >
> > But with this change it correctly shows as:
> >
> > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> >
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> >
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
>
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?
Most likely that it is so trivial that nobody paid much attention.
FWIW, you can add
Acked-by: Nicolas Pitre <nico@linaro.org>
and submit it here: http://www.arm.linux.org.uk/developer/patches/
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Mark ret_fast_syscall as a function
Date: Thu, 6 Aug 2015 13:30:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1508061327510.1515@knanqh.ubzr> (raw)
In-Reply-To: <20150806170758.GA26691@dreric01-gentoo.localdomain>
On Thu, 6 Aug 2015, Drew Richardson wrote:
> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> >
> > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> >
> > But with this change it correctly shows as:
> >
> > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> >
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> >
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
>
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?
Most likely that it is so trivial that nobody paid much attention.
FWIW, you can add
Acked-by: Nicolas Pitre <nico@linaro.org>
and submit it here: http://www.arm.linux.org.uk/developer/patches/
Nicolas
next prev parent reply other threads:[~2015-08-06 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:45 [PATCH] ARM: Mark ret_fast_syscall as a function Drew Richardson
2015-07-14 12:45 ` Drew Richardson
2015-08-06 17:08 ` Drew Richardson
2015-08-06 17:08 ` Drew Richardson
2015-08-06 17:30 ` Nicolas Pitre [this message]
2015-08-06 17:30 ` Nicolas Pitre
2015-08-06 17:52 ` Drew Richardson
2015-08-06 17:52 ` Drew Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1508061327510.1515@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=Dave.Martin@arm.com \
--cc=Wade.Cherry@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=drew.richardson@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.