* [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs [not found] <CGME20220811114614epcas5p29046e326acc8d13824479504e80a0d49@epcas5p2.samsung.com> @ 2022-08-11 11:35 ` Alim Akhtar 0 siblings, 0 replies; 4+ messages in thread From: Alim Akhtar @ 2022-08-11 11:35 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-scsi Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen, chanho61.park, linux-samsung-soc, Alim Akhtar struct fsd_ufs_drvs is not used outside this file, so made it static. This fixes sparse warning: drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: symbol 'fsd_ufs_drvs' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- drivers/ufs/host/ufs-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index eced97538082..6cef19118e07 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1711,7 +1711,7 @@ static struct exynos_ufs_uic_attr fsd_uic_attr = { .pa_dbg_option_suite = 0x2E820183, }; -struct exynos_ufs_drv_data fsd_ufs_drvs = { +static struct exynos_ufs_drv_data fsd_ufs_drvs = { .uic_attr = &fsd_uic_attr, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR | -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs @ 2022-08-11 11:35 ` Alim Akhtar 0 siblings, 0 replies; 4+ messages in thread From: Alim Akhtar @ 2022-08-11 11:35 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-scsi Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen, chanho61.park, linux-samsung-soc, Alim Akhtar struct fsd_ufs_drvs is not used outside this file, so made it static. This fixes sparse warning: drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: symbol 'fsd_ufs_drvs' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- drivers/ufs/host/ufs-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index eced97538082..6cef19118e07 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1711,7 +1711,7 @@ static struct exynos_ufs_uic_attr fsd_uic_attr = { .pa_dbg_option_suite = 0x2E820183, }; -struct exynos_ufs_drv_data fsd_ufs_drvs = { +static struct exynos_ufs_drv_data fsd_ufs_drvs = { .uic_attr = &fsd_uic_attr, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR | -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs 2022-08-11 11:35 ` Alim Akhtar @ 2022-08-11 11:53 ` Krzysztof Kozlowski -1 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2022-08-11 11:53 UTC (permalink / raw) To: Alim Akhtar, linux-arm-kernel, linux-kernel, linux-scsi Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen, chanho61.park, linux-samsung-soc On 11/08/2022 14:35, Alim Akhtar wrote: > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> This should be static const. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs @ 2022-08-11 11:53 ` Krzysztof Kozlowski 0 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2022-08-11 11:53 UTC (permalink / raw) To: Alim Akhtar, linux-arm-kernel, linux-kernel, linux-scsi Cc: krzysztof.kozlowski+dt, avri.altman, bvanassche, martin.petersen, chanho61.park, linux-samsung-soc On 11/08/2022 14:35, Alim Akhtar wrote: > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> This should be static const. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-11 11:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220811114614epcas5p29046e326acc8d13824479504e80a0d49@epcas5p2.samsung.com>
2022-08-11 11:35 ` [PATCH] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs Alim Akhtar
2022-08-11 11:35 ` Alim Akhtar
2022-08-11 11:53 ` Krzysztof Kozlowski
2022-08-11 11:53 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.