From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH v3 03/11] drm/xe/bmg: Add BMG platform definition
Date: Tue, 9 Apr 2024 10:46:09 -0500 [thread overview]
Message-ID: <tfh3hmcmqbebzsxmdtw5safmqw3wo6t44bit6zjmaly2t7xo2t@4szqtwyiaxom> (raw)
In-Reply-To: <20240408170545.3769566-4-balasubramani.vivekanandan@intel.com>
On Mon, Apr 08, 2024 at 10:35:37PM +0530, Balasubramani Vivekanandan wrote:
>From: Matt Roper <matthew.d.roper@intel.com>
>
>BMG is a discrete GPU based on the Xe2 architecture.
>No device ids are bound to the BMG platform descriptor yet.
>BMG device ids will be added once we have all the basic required
>platform enabling patches landed.
>
>v2: Removed device ids, deferring it to a later patch
>
>Bspec: 68090
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>---
> drivers/gpu/drm/xe/xe_pci.c | 6 ++++++
> drivers/gpu/drm/xe/xe_platform_types.h | 1 +
> 2 files changed, 7 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>index 2d3b18d6404e..3b30353dbc09 100644
>--- a/drivers/gpu/drm/xe/xe_pci.c
>+++ b/drivers/gpu/drm/xe/xe_pci.c
>@@ -337,6 +337,12 @@ static const struct xe_device_desc lnl_desc = {
> .require_force_probe = true,
> };
>
>+static const struct xe_device_desc bmg_desc __maybe_unused = {
>+ DGFX_FEATURES,
>+ PLATFORM(XE_BATTLEMAGE),
>+ .require_force_probe = true,
>+};
>+
> #undef PLATFORM
> __diag_pop();
>
>diff --git a/drivers/gpu/drm/xe/xe_platform_types.h b/drivers/gpu/drm/xe/xe_platform_types.h
>index 553f53dbd093..79b7042c4534 100644
>--- a/drivers/gpu/drm/xe/xe_platform_types.h
>+++ b/drivers/gpu/drm/xe/xe_platform_types.h
>@@ -22,6 +22,7 @@ enum xe_platform {
> XE_PVC,
> XE_METEORLAKE,
> XE_LUNARLAKE,
>+ XE_BATTLEMAGE,
See https://lore.kernel.org/all/jmgaruuivoineqbkx6rvu6n5qasuq4lev6vwwytyt7vwnog3q6@fl3tkitfwbfv/
I don't see a point in not declaring the IS_BATTLEMAGE() separately
in https://patchwork.freedesktop.org/patch/586853/?series=131983&rev=2
Having the sw-only platform sketch in a single commit IMO would be
better. Anyway, this is just a nitpick if you have to respin this
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
> };
>
> enum xe_subplatform {
>--
>2.25.1
>
next prev parent reply other threads:[~2024-04-09 15:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 17:05 [PATCH v3 00/11] Add Battlemage support Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 01/11] drm/xe/xe2: Recognize Xe2_HPG IP Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 02/11] drm/xe/xe2: Recognize Xe2_HPM IP Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 03/11] drm/xe/bmg: Add BMG platform definition Balasubramani Vivekanandan
2024-04-08 19:09 ` Ghimiray, Himal Prasad
2024-04-09 15:46 ` Lucas De Marchi [this message]
2024-04-08 17:05 ` [PATCH v3 04/11] drm/xe/bmg: Add BMG mocs table Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 05/11] drm/xe/bmg: Program an additional discrete-specific PAT setting Balasubramani Vivekanandan
2024-04-08 19:05 ` Ghimiray, Himal Prasad
2024-04-08 17:05 ` [PATCH v3 06/11] drm/xe/xe2hpg: Determine flat ccs offset for vram Balasubramani Vivekanandan
2024-04-08 21:44 ` Matt Roper
2024-04-08 17:05 ` [PATCH v3 07/11] drm/xe/xe2hpg: Remove extra allocation of CCS pages for dgfx Balasubramani Vivekanandan
2024-04-08 18:57 ` Ghimiray, Himal Prasad
2024-04-08 21:46 ` Matt Roper
2024-04-22 10:15 ` Thomas Hellström
2024-04-08 17:05 ` [PATCH v3 08/11] drm/xe/xe2: Add workaround 18034896535 Balasubramani Vivekanandan
2024-04-26 21:02 ` Lucas De Marchi
2024-04-29 13:51 ` Gustavo Sousa
2024-04-08 17:05 ` [PATCH v3 09/11] drm/xe/xe2hpg: Add initial GT workarounds Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 10/11] drm/xe/xe2hpg: Introduce performance tuning changes for Xe2_HPG Balasubramani Vivekanandan
2024-04-08 17:05 ` [PATCH v3 11/11] drm/xe/xe2hpm: Add initial set of workarounds Balasubramani Vivekanandan
2024-04-08 18:33 ` ✓ CI.Patch_applied: success for Add Battlemage support (rev3) Patchwork
2024-04-08 18:33 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-08 18:34 ` ✓ CI.KUnit: success " Patchwork
2024-04-08 18:46 ` ✓ CI.Build: " Patchwork
2024-04-08 18:48 ` ✓ CI.Hooks: " Patchwork
2024-04-08 18:50 ` ✓ CI.checksparse: " Patchwork
2024-04-08 19:12 ` ✓ CI.BAT: " Patchwork
2024-04-09 0:34 ` ✓ CI.FULL: " Patchwork
2024-04-09 21:25 ` [PATCH v3 00/11] Add Battlemage support Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tfh3hmcmqbebzsxmdtw5safmqw3wo6t44bit6zjmaly2t7xo2t@4szqtwyiaxom \
--to=lucas.demarchi@intel.com \
--cc=balasubramani.vivekanandan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.