From: Douglas Anderson <dianders@chromium.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
swboyd@chromium.org, Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Kees Cook <keescook@chromium.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Tony Luck <tony.luck@intel.com>,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered
Date: Fri, 3 Nov 2023 16:34:27 -0700 [thread overview]
Message-ID: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> (raw)
On sc7180 when the watchdog timer fires your logs get filled with:
watchdog0: pretimeout event
watchdog0: pretimeout event
watchdog0: pretimeout event
...
watchdog0: pretimeout event
If you're using console-ramoops to debug crashes the above gets quite
annoying since it blows away any other log messages that might have
been there.
The issue is that the "bark" interrupt (AKA the "pretimeout"
interrupt) remains high until the watchdog is pet. Since we've got
things configured as "level" triggered we'll keep getting interrupted
over and over.
Let's switch to edge triggered. Now we'll get one interrupt when the
"bark" interrupt goes off we'll get one interrupt and won't get
another one until the "bark" interrupt is cleared and asserts again.
This matches how many older Qualcomm SoCs have things configured.
Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 11f353d416b4..c0365832c315 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3576,7 +3576,7 @@ watchdog@17c10000 {
compatible = "qcom,apss-wdt-sc7180", "qcom,kpss-wdt";
reg = <0 0x17c10000 0 0x1000>;
clocks = <&sleep_clk>;
- interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
};
timer@17c20000 {
--
2.42.0.869.gea05f2083d-goog
next reply other threads:[~2023-11-03 23:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:34 Douglas Anderson [this message]
2023-11-03 23:34 ` [PATCH 2/9] arm64: dts: qcom: sc7280: Make watchdog bark interrupt edge triggered Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 3/9] arm64: dts: qcom: sdm845: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 4/9] arm64: dts: qcom: sm8150: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 5/9] arm64: dts: qcom: sm8250: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 6/9] arm64: dts: qcom: sa8775p: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 7/9] arm64: dts: qcom: sc8280xp: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 8/9] arm64: dts: qcom: sm6350: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-05 13:33 ` Krzysztof Kozlowski
2023-11-06 21:53 ` Stephen Boyd
2023-11-04 0:42 ` [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt " Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-06 21:52 ` Doug Anderson
2023-11-06 22:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quic_saipraka@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tony.luck@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).