From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-watchdog@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Andy Gross <agross@kernel.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Kees Cook <keescook@chromium.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Tony Luck <tony.luck@intel.com>,
<cros-qcom-dts-watchers@chromium.org>,
<devicetree@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered
Date: Mon, 6 Nov 2023 14:36:51 -0800 [thread overview]
Message-ID: <20231106223651.GZ3553829@hu-bjorande-lv.qualcomm.com> (raw)
In-Reply-To: <CAD=FV=UJE6VKrjFJ2g=4qRHLdnqymossWSAFeKyUykxm1sTCtQ@mail.gmail.com>
On Mon, Nov 06, 2023 at 01:52:58PM -0800, Doug Anderson wrote:
> Hi,
>
> On Mon, Nov 6, 2023 at 1:49 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Douglas Anderson (2023-11-03 16:34:27)
> > > On sc7180 when the watchdog timer fires your logs get filled with:
> > > watchdog0: pretimeout event
> > > watchdog0: pretimeout event
> > > watchdog0: pretimeout event
> > > ...
> > > watchdog0: pretimeout event
> > >
> > > If you're using console-ramoops to debug crashes the above gets quite
> > > annoying since it blows away any other log messages that might have
> > > been there.
> > >
> > > The issue is that the "bark" interrupt (AKA the "pretimeout"
> > > interrupt) remains high until the watchdog is pet. Since we've got
> > > things configured as "level" triggered we'll keep getting interrupted
> > > over and over.
> > >
> > > Let's switch to edge triggered. Now we'll get one interrupt when the
> > > "bark" interrupt goes off we'll get one interrupt and won't get
> >
> > "We'll get one" twice?
>
> I like to make like to make typos. If you hadn't hadn't noticed.
>
> I'll wait another few days and send a version with the typo fixed
> unless Bjorn tells me not to (because he didn't care and applied it
> anyway or because he fixed it himself while applying).
>
I'd be happy to pick your resubmitted series. Thanks for cleaning this
up across the platforms.
Regards,
Bjorn
>
> > > another one until the "bark" interrupt is cleared and asserts again.
> > >
> > > This matches how many older Qualcomm SoCs have things configured.
> > >
> > > Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt")
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> >
> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> Thanks!
>
> -Doug
prev parent reply other threads:[~2023-11-06 22:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:34 [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered Douglas Anderson
2023-11-03 23:34 ` [PATCH 2/9] arm64: dts: qcom: sc7280: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 3/9] arm64: dts: qcom: sdm845: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 4/9] arm64: dts: qcom: sm8150: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 5/9] arm64: dts: qcom: sm8250: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 6/9] arm64: dts: qcom: sa8775p: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 7/9] arm64: dts: qcom: sc8280xp: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 8/9] arm64: dts: qcom: sm6350: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-05 13:33 ` Krzysztof Kozlowski
2023-11-06 21:53 ` Stephen Boyd
2023-11-04 0:42 ` [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt " Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-06 21:52 ` Doug Anderson
2023-11-06 22:36 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106223651.GZ3553829@hu-bjorande-lv.qualcomm.com \
--to=quic_bjorande@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quic_saipraka@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tony.luck@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).