From: Guenter Roeck <linux@roeck-us.net>
To: Douglas Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
swboyd@chromium.org, Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] arm64: dts: qcom: sm6350: Make watchdog bark interrupt edge triggered
Date: Fri, 3 Nov 2023 17:43:22 -0700 [thread overview]
Message-ID: <8331ff50-e825-4c27-909e-37f5a9387344@roeck-us.net> (raw)
In-Reply-To: <20231103163434.8.Ic1d4402e99c70354d501ccd98105e908a902f671@changeid>
On Fri, Nov 03, 2023 at 04:34:34PM -0700, Douglas Anderson wrote:
> As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog
> bark interrupt edge triggered"), the Qualcomm watchdog timer's bark
> interrupt should be configured as edge triggered. Make the change.
>
> Fixes: 5f82b9cda61e ("arm64: dts: qcom: Add SM6350 device tree")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 8fd6f4d03490..6464e144c228 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -2524,7 +2524,7 @@ watchdog@17c10000 {
> compatible = "qcom,apss-wdt-sm6350", "qcom,kpss-wdt";
> reg = <0 0x17c10000 0 0x1000>;
> clocks = <&sleep_clk>;
> - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> };
>
> timer@17c20000 {
> --
> 2.42.0.869.gea05f2083d-goog
>
next prev parent reply other threads:[~2023-11-04 0:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:34 [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered Douglas Anderson
2023-11-03 23:34 ` [PATCH 2/9] arm64: dts: qcom: sc7280: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 3/9] arm64: dts: qcom: sdm845: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 4/9] arm64: dts: qcom: sm8150: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:50 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 5/9] arm64: dts: qcom: sm8250: " Douglas Anderson
2023-11-04 0:42 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 6/9] arm64: dts: qcom: sa8775p: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:51 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 7/9] arm64: dts: qcom: sc8280xp: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 8/9] arm64: dts: qcom: sm6350: " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck [this message]
2023-11-06 21:52 ` Stephen Boyd
2023-11-03 23:34 ` [PATCH 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example " Douglas Anderson
2023-11-04 0:43 ` Guenter Roeck
2023-11-05 13:33 ` Krzysztof Kozlowski
2023-11-06 21:53 ` Stephen Boyd
2023-11-04 0:42 ` [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt " Guenter Roeck
2023-11-06 21:49 ` Stephen Boyd
2023-11-06 21:52 ` Doug Anderson
2023-11-06 22:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8331ff50-e825-4c27-909e-37f5a9387344@roeck-us.net \
--to=linux@roeck-us.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).