From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v4 04/17] media: i2c: max9286: Define high channel amplitude
Date: Mon, 12 Apr 2021 11:34:38 +0200 [thread overview]
Message-ID: <20210412093451.14198-5-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20210412093451.14198-1-jacopo+renesas@jmondi.org>
Provide a macro to define the reverse channel amplitude to
be used to compensate the remote serializer noise immunity.
While at it, update a comment.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/max9286.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index ed1cdefe7c30..9124d5fa6ea3 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -113,6 +113,7 @@
#define MAX9286_REV_TRF(n) ((n) << 4)
#define MAX9286_REV_AMP(n) ((((n) - 30) / 10) << 1) /* in mV */
#define MAX9286_REV_AMP_X BIT(0)
+#define MAX9286_REV_AMP_HIGH 170
/* Register 0x3f */
#define MAX9286_EN_REV_CFG BIT(6)
#define MAX9286_REV_FLEN(n) ((n) - 20)
@@ -567,12 +568,12 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
* channels:
*
* - Increase the reverse channel amplitude to compensate for the
- * remote ends high threshold, if not done already
+ * remote ends high threshold
* - Verify all configuration links are properly detected
* - Disable auto-ack as communication on the control channel are now
* stable.
*/
- max9286_reverse_channel_setup(priv, 170);
+ max9286_reverse_channel_setup(priv, MAX9286_REV_AMP_HIGH);
max9286_check_config_link(priv, priv->source_mask);
/*
--
2.31.1
next prev parent reply other threads:[~2021-04-12 9:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 9:34 [PATCH v4 00/17] media: gmsl: Reliability improvements Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 01/17] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 02/17] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 03/17] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-04-12 9:34 ` Jacopo Mondi [this message]
2021-04-12 9:34 ` [PATCH v4 05/17] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 06/17] media: i2c: max9271: Check max9271_write() return Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 07/17] media: i2c: max9271: Introduce wake_up() function Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 08/17] media: i2c: rdacm21: Add dealy after OV490 reset Jacopo Mondi
2021-04-14 16:49 ` Kieran Bingham
2021-04-14 23:10 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 09/17] media: i2c: rdacm21: Fix OV10640 powerup Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 10/17] media: i2c: rdacm21: Power up OV10640 before OV490 Jacopo Mondi
2021-04-14 23:13 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 11/17] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-04-14 23:14 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 12/17] media: i2c: rdacm20: Embed 'serializer' field Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 13/17] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 14/17] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 15/17] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 16/17] media: v4l2-subdev: De-deprecate init() subdev op Jacopo Mondi
2021-04-15 12:31 ` Jacopo Mondi
2021-06-14 7:34 ` Jacopo Mondi
2021-06-14 8:51 ` Hans Verkuil
2021-06-14 9:45 ` Jacopo Mondi
2021-06-14 9:55 ` Hans Verkuil
2021-06-14 15:17 ` Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 17/17] media: gmsl: Reimplement initialization sequence Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412093451.14198-5-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).