From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/17] media: i2c: rdacm21: Add dealy after OV490 reset
Date: Wed, 14 Apr 2021 17:49:37 +0100 [thread overview]
Message-ID: <e47bbf9b-5ba0-d4a4-ee64-0724d6d55957@ideasonboard.com> (raw)
In-Reply-To: <20210412093451.14198-9-jacopo+renesas@jmondi.org>
Hi Jacopo,
There's still a s/dealy/delay/ in $SUBJECT
On 12/04/2021 10:34, Jacopo Mondi wrote:
> Add a delay after the OV490 chip is put in reset state. The reset
> signal shall be held for at least 250 useconds.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
I added this on v3...
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/i2c/rdacm21.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index 553e3f03752b..6be8ce130e78 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -469,7 +469,10 @@ static int rdacm21_initialize(struct rdacm21_device *dev)
> if (ret)
> return ret;
>
> - /* Enable GPIO1 and hold OV490 in reset during max9271 configuration. */
> + /*
> + * Enable GPIO1 and hold OV490 in reset during max9271 configuration.
> + * The reset signal has to be asserted for at least 250 useconds.
Is it worth mentioning here that it is asserted to active low? Just to
make it clear that holding it low for 250 uS is the desired effect?
It might not be worth it - but perhaps that was the reason for some
confusion here.
Eitherway RB tag still stands I think.
--
Kieran
> + */
> ret = max9271_enable_gpios(&dev->serializer, MAX9271_GPIO1OUT);
> if (ret)
> return ret;
> @@ -477,6 +480,7 @@ static int rdacm21_initialize(struct rdacm21_device *dev)
> ret = max9271_clear_gpios(&dev->serializer, MAX9271_GPIO1OUT);
> if (ret)
> return ret;
> + usleep_range(250, 500);
>
> ret = max9271_configure_gmsl_link(&dev->serializer);
> if (ret)
>
next prev parent reply other threads:[~2021-04-14 16:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 9:34 [PATCH v4 00/17] media: gmsl: Reliability improvements Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 01/17] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 02/17] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 03/17] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 04/17] media: i2c: max9286: Define high " Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 05/17] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 06/17] media: i2c: max9271: Check max9271_write() return Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 07/17] media: i2c: max9271: Introduce wake_up() function Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 08/17] media: i2c: rdacm21: Add dealy after OV490 reset Jacopo Mondi
2021-04-14 16:49 ` Kieran Bingham [this message]
2021-04-14 23:10 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 09/17] media: i2c: rdacm21: Fix OV10640 powerup Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 10/17] media: i2c: rdacm21: Power up OV10640 before OV490 Jacopo Mondi
2021-04-14 23:13 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 11/17] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-04-14 23:14 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 12/17] media: i2c: rdacm20: Embed 'serializer' field Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 13/17] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 14/17] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 15/17] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 16/17] media: v4l2-subdev: De-deprecate init() subdev op Jacopo Mondi
2021-04-15 12:31 ` Jacopo Mondi
2021-06-14 7:34 ` Jacopo Mondi
2021-06-14 8:51 ` Hans Verkuil
2021-06-14 9:45 ` Jacopo Mondi
2021-06-14 9:55 ` Hans Verkuil
2021-06-14 15:17 ` Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 17/17] media: gmsl: Reimplement initialization sequence Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e47bbf9b-5ba0-d4a4-ee64-0724d6d55957@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).