From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v4 06/17] media: i2c: max9271: Check max9271_write() return
Date: Mon, 12 Apr 2021 11:34:40 +0200 [thread overview]
Message-ID: <20210412093451.14198-7-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20210412093451.14198-1-jacopo+renesas@jmondi.org>
Check the return value of the max9271_write() function in the
max9271 library driver.
While at it, modify an existing condition to be made identical
to other checks.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/max9271.c | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c
index c495582dcff6..2c7dc7fb9846 100644
--- a/drivers/media/i2c/max9271.c
+++ b/drivers/media/i2c/max9271.c
@@ -106,7 +106,10 @@ int max9271_set_serial_link(struct max9271_device *dev, bool enable)
* Short delays here appear to show bit-errors in the writes following.
* Therefore a conservative delay seems best here.
*/
- max9271_write(dev, 0x04, val);
+ ret = max9271_write(dev, 0x04, val);
+ if (ret < 0)
+ return ret;
+
usleep_range(5000, 8000);
return 0;
@@ -118,7 +121,7 @@ int max9271_configure_i2c(struct max9271_device *dev, u8 i2c_config)
int ret;
ret = max9271_write(dev, 0x0d, i2c_config);
- if (ret)
+ if (ret < 0)
return ret;
/* The delay required after an I2C bus configuration change is not
@@ -143,7 +146,10 @@ int max9271_set_high_threshold(struct max9271_device *dev, bool enable)
* Enable or disable reverse channel high threshold to increase
* immunity to power supply noise.
*/
- max9271_write(dev, 0x08, enable ? ret | BIT(0) : ret & ~BIT(0));
+ ret = max9271_write(dev, 0x08, enable ? ret | BIT(0) : ret & ~BIT(0));
+ if (ret < 0)
+ return ret;
+
usleep_range(2000, 2500);
return 0;
@@ -152,6 +158,8 @@ EXPORT_SYMBOL_GPL(max9271_set_high_threshold);
int max9271_configure_gmsl_link(struct max9271_device *dev)
{
+ int ret;
+
/*
* Configure the GMSL link:
*
@@ -162,16 +170,24 @@ int max9271_configure_gmsl_link(struct max9271_device *dev)
*
* TODO: Make the GMSL link configuration parametric.
*/
- max9271_write(dev, 0x07, MAX9271_DBL | MAX9271_HVEN |
- MAX9271_EDC_1BIT_PARITY);
+ ret = max9271_write(dev, 0x07, MAX9271_DBL | MAX9271_HVEN |
+ MAX9271_EDC_1BIT_PARITY);
+ if (ret < 0)
+ return ret;
+
usleep_range(5000, 8000);
/*
* Adjust spread spectrum to +4% and auto-detect pixel clock
* and serial link rate.
*/
- max9271_write(dev, 0x02, MAX9271_SPREAD_SPECT_4 | MAX9271_R02_RES |
- MAX9271_PCLK_AUTODETECT | MAX9271_SERIAL_AUTODETECT);
+ ret = max9271_write(dev, 0x02,
+ MAX9271_SPREAD_SPECT_4 | MAX9271_R02_RES |
+ MAX9271_PCLK_AUTODETECT |
+ MAX9271_SERIAL_AUTODETECT);
+ if (ret < 0)
+ return ret;
+
usleep_range(5000, 8000);
return 0;
--
2.31.1
next prev parent reply other threads:[~2021-04-12 9:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 9:34 [PATCH v4 00/17] media: gmsl: Reliability improvements Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 01/17] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 02/17] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 03/17] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 04/17] media: i2c: max9286: Define high " Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 05/17] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-04-12 9:34 ` Jacopo Mondi [this message]
2021-04-12 9:34 ` [PATCH v4 07/17] media: i2c: max9271: Introduce wake_up() function Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 08/17] media: i2c: rdacm21: Add dealy after OV490 reset Jacopo Mondi
2021-04-14 16:49 ` Kieran Bingham
2021-04-14 23:10 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 09/17] media: i2c: rdacm21: Fix OV10640 powerup Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 10/17] media: i2c: rdacm21: Power up OV10640 before OV490 Jacopo Mondi
2021-04-14 23:13 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 11/17] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-04-14 23:14 ` Laurent Pinchart
2021-04-12 9:34 ` [PATCH v4 12/17] media: i2c: rdacm20: Embed 'serializer' field Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 13/17] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 14/17] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 15/17] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 16/17] media: v4l2-subdev: De-deprecate init() subdev op Jacopo Mondi
2021-04-15 12:31 ` Jacopo Mondi
2021-06-14 7:34 ` Jacopo Mondi
2021-06-14 8:51 ` Hans Verkuil
2021-06-14 9:45 ` Jacopo Mondi
2021-06-14 9:55 ` Hans Verkuil
2021-06-14 15:17 ` Jacopo Mondi
2021-04-12 9:34 ` [PATCH v4 17/17] media: gmsl: Reimplement initialization sequence Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412093451.14198-7-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).