From: Ravi Bangoria <ravi.bangoria@amd.com>
To: "Wang, Weilin" <weilin.wang@intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>,
"Alt, Samantha" <samantha.alt@intel.com>,
"Taylor, Perry" <perry.taylor@intel.com>,
"Biggers, Caleb" <caleb.biggers@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 1/3] perf test: Add metric value validation test
Date: Mon, 19 Jun 2023 09:50:40 +0530 [thread overview]
Message-ID: <93574312-f467-04af-92af-5b5476043977@amd.com> (raw)
In-Reply-To: <CO6PR11MB56353207BBD7BDA6C530EBDEEE5EA@CO6PR11MB5635.namprd11.prod.outlook.com>
>>> +grep -q Intel /proc/cpuinfo || (echo Skipping non-Intel; exit 2)
>>
>> This check doesn't seem to be working. On my Zen3 AMD machine:
>
> Thanks for reporting this! I've update this search to "GenuineIntel" in v4 to help solve this issue.
> Please check it out.
I'm sorry. I should have been more elaborative.
What I mean was () in bash creates a sub shell and thus exits from
the sub shell. I think what you need is {}. Ex:
grep -q Intel /proc/cpuinfo || { echo Skipping non-Intel; exit 2; }
>> test child finished with 0
>> ---- end ----
>> perf metrics value validation: Ok
>>
>> I haven't yet investigated whether it's genuine or false positive.
>>
> Base on this final report, it validated some basic rules like the 12 metrics for positive value test and 2 metrics for single metric value checks.
> The test script grabs metrics supported on the platform and generates validation rules that only include metrics in the supported list.
> Therefore, it is not surprising that the check passes on your system.
Got it.
Thanks,
Ravi
next prev parent reply other threads:[~2023-06-19 4:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 16:26 [PATCH v2 0/3] Add metric value validation test Weilin Wang
2023-06-09 16:26 ` [PATCH v2 1/3] perf test: " Weilin Wang
2023-06-09 16:26 ` [PATCH v2 2/3] perf test: Add skip list for metrics known would fail Weilin Wang
2023-06-09 16:26 ` [PATCH v2 3/3] perf test: Rerun failed metrics with longer workload Weilin Wang
2023-06-13 0:04 ` [PATCH v2 0/3] Add metric value validation test Ian Rogers
2023-06-14 20:38 ` [PATCH v3 " Weilin Wang
2023-06-14 20:38 ` [PATCH v3 1/3] perf test: " Weilin Wang
2023-06-16 7:02 ` Ravi Bangoria
2023-06-18 17:43 ` Wang, Weilin
2023-06-19 4:20 ` Ravi Bangoria [this message]
2023-06-14 20:38 ` [PATCH v3 2/3] perf test: Add skip list for metrics known would fail Weilin Wang
2023-06-14 20:38 ` [PATCH v3 3/3] perf test: Rerun failed metrics with longer workload Weilin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93574312-f467-04af-92af-5b5476043977@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).