From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Franziska Näpelt" <franziska.naepelt@googlemail.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
keyrings@vger.kernel.org, dhowells@redhat.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
Linux Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues
Date: Tue, 6 Jun 2023 21:29:08 +0300 [thread overview]
Message-ID: <93f96b93-2f2e-4c98-8ffd-1bd0bd441347@kadam.mountain> (raw)
In-Reply-To: <CAAUT3iPVFZEQE+bFk4HhWbaAtnsbQLYrzggeD2Va4mC0Q09SNQ@mail.gmail.com>
On Tue, Jun 06, 2023 at 07:59:02PM +0200, Franziska Näpelt wrote:
> Am Di., 6. Juni 2023 um 18:03 Uhr schrieb Jarkko Sakkinen <jarkko@kernel.org>:
> > On Tue Jun 6, 2023 at 6:25 PM EEST, Dan Carpenter wrote:
> > > On Tue, Jun 06, 2023 at 05:51:09PM +0300, Jarkko Sakkinen wrote:
> > > > On Tue Jun 6, 2023 at 4:38 PM EEST, Dan Carpenter wrote:
> > > > > On Tue, Jun 06, 2023 at 07:28:52PM +0700, Bagas Sanjaya wrote:
> > > > > > On Fri, Jun 02, 2023 at 10:59:02AM +0200, Franziska Naepelt wrote:
> > > > > > > The following issues are fixed:
> > > > > > > - WARNING: Missing or malformed SPDX-License-Identifier tag
> > > > > > > - ERROR: trailing statements should be on next line
> > > > > > > - WARNING: braces {} are not necessary for single statement blocks
> > > > > > > - ERROR: space required before the open parenthesis '('
> > > > > > > - ERROR: code indent should use tabs where possible
> > > > > > > - WARNING: please, no spaces at the start of a line
> > > > > > > - WARNING: Missing a blank line after declarations
> > > > > >
[ snip ]
>
> I'm a bit puzzled now since there are different opinions on my patch.
> I'm struggling to draw a conclusion whether to split the patch into smaller
> single line patches or not.
>
> I'd propose to split it into two patches:
> * One for SPDX license tag fix
> * One for spacing, tab, blank line, unnecessary braces etc.
You should definitely pull the SPDX change into its own patch because
it's sightly controversial and important.
In drivers/staging/ we would say pull each type of checkpatch warning
into its own patch so it would be something like 6 patches. But I don't
know how it's done in this subsystem. I feel like Greg maybe goes
overboard on splitting patches up, but the advantage of Greg's system is
that it's easy to explain the rules to newbies. There is a lot about
staging/ which designed around newbies.
If I'm totally honest, in a lot of subsystems the policy is just leave
it alone. Don't bother cleaning up checkpatch stuff because it just
creates more work and makes the git log noisier.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-06 18:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:05 [PATCH] certs/extract-cert: Fix checkpatch issues Franziska Naepelt
2023-06-02 2:27 ` kernel test robot
2023-06-02 3:09 ` kernel test robot
2023-06-02 8:59 ` [PATCH v2] " Franziska Naepelt
2023-06-06 12:28 ` Bagas Sanjaya
2023-06-06 13:38 ` Dan Carpenter
2023-06-06 14:51 ` Jarkko Sakkinen
2023-06-06 15:25 ` Dan Carpenter
2023-06-06 16:03 ` Jarkko Sakkinen
2023-06-06 17:59 ` Franziska Näpelt
2023-06-06 18:29 ` Dan Carpenter [this message]
2023-06-06 21:43 ` Ben Boeckel
2023-06-07 16:11 ` Jarkko Sakkinen
2023-06-09 14:01 ` Dan Carpenter
2023-06-09 15:37 ` Jarkko Sakkinen
2023-06-09 15:43 ` Jarkko Sakkinen
2023-06-06 12:38 ` Jarkko Sakkinen
2023-06-06 12:44 ` Jarkko Sakkinen
2023-06-06 12:47 ` Jarkko Sakkinen
2023-06-06 14:44 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f96b93-2f2e-4c98-8ffd-1bd0bd441347@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=bagasdotme@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=franziska.naepelt@googlemail.com \
--cc=jarkko@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).