From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Franziska Naepelt <franziska.naepelt@googlemail.com>,
keyrings@vger.kernel.org, dhowells@redhat.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
Franziska Naepelt <franziska.naepelt@gmail.com>,
kernel test robot <lkp@intel.com>,
Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
Linux Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues
Date: Fri, 9 Jun 2023 17:01:31 +0300 [thread overview]
Message-ID: <c464c4ee-038c-47bf-857a-b11a89680e82@kadam.mountain> (raw)
In-Reply-To: <CT5NH4XXIYQF.5XXJE6JA5FZP@suppilovahvero>
On Tue, Jun 06, 2023 at 05:51:09PM +0300, Jarkko Sakkinen wrote:
> It's not a "punishment". It's more like that I really have to take the
> time to read the prose...
The thing about imperative tense is that it was used as a punishment on
me once five years ago. I wrote a quite bad commit message and a senior
maintainer told me to re-write it properly and I realized that it was
true. My commit message was bad. So I wrote a proper commit message.
And then he yelled at me, "Can't you follow simple directions and write
it in imperative tense like the documentation says? Are you a
shithead?"
So then I swore I would never talk to him again or to anyone who
enforced the imperative tense rule. That has only happened once in the
intervening years. I told the maintainer, "Fine. Re-write the commit
message however you like and give me Reported-by credit." This was a
cheeky response and it made the maintainer enraged. I guess he thought
that my boss would force me to fix the bug or something? I felt bad for
the Intel developer who had to fix my bug instead because I knew that
the maintainer was going to be super angry if he gave me reported-by
credit so I had put him in a bind. I almost re-wrote the commit message
so that he wouldn't have to deal with that. Maybe this is how mothers
feel when they try to take abuse from an angry husband instead of
letting their kids suffer. But I am a bad mother and I left.
My boss would never have forced me to deal with that. When he left for
a different company he said, "Dan, I'm transitioning and XXX is taking
over me and I have told him all your weirdness so he is prepared." And
it was a huge comfort to me because I know what my weakness are.
You people on this thread all seem super nice. And you're right that we
should always try to be improve every aspect of our craft.
When Jarkko talked about people who write too long commit messages, I
thought about one developer in particular who writes too long commit
messages. He writes in imperative tense. He takes everything so
seriously and he's never seen a rule without following it. His patches
are always right. People have told him that his commit messages are bad
and too long and those people are right. But they need to shut up. The
good things that he does and the bad things that he does are all part of
the same package. He can't change and I don't want him to feel anything
but welcome.
It's hard to be a good kernel developer without being at least slightly
obsessive. Both developers and maintainers are that way. And I deal
with a lot of people and accomodating maintainers you disagree with is
part of the job.
So long as everyone is kind to each other. That's the main thing.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-09 14:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:05 [PATCH] certs/extract-cert: Fix checkpatch issues Franziska Naepelt
2023-06-02 2:27 ` kernel test robot
2023-06-02 3:09 ` kernel test robot
2023-06-02 8:59 ` [PATCH v2] " Franziska Naepelt
2023-06-06 12:28 ` Bagas Sanjaya
2023-06-06 13:38 ` Dan Carpenter
2023-06-06 14:51 ` Jarkko Sakkinen
2023-06-06 15:25 ` Dan Carpenter
2023-06-06 16:03 ` Jarkko Sakkinen
2023-06-06 17:59 ` Franziska Näpelt
2023-06-06 18:29 ` Dan Carpenter
2023-06-06 21:43 ` Ben Boeckel
2023-06-07 16:11 ` Jarkko Sakkinen
2023-06-09 14:01 ` Dan Carpenter [this message]
2023-06-09 15:37 ` Jarkko Sakkinen
2023-06-09 15:43 ` Jarkko Sakkinen
2023-06-06 12:38 ` Jarkko Sakkinen
2023-06-06 12:44 ` Jarkko Sakkinen
2023-06-06 12:47 ` Jarkko Sakkinen
2023-06-06 14:44 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c464c4ee-038c-47bf-857a-b11a89680e82@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=bagasdotme@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=franziska.naepelt@gmail.com \
--cc=franziska.naepelt@googlemail.com \
--cc=jarkko@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).