From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Franziska Naepelt <franziska.naepelt@googlemail.com>,
keyrings@vger.kernel.org
Cc: dhowells@redhat.com, dwmw2@infradead.org,
linux-kernel@vger.kernel.org,
Franziska Naepelt <franziska.naepelt@gmail.com>,
kernel test robot <lkp@intel.com>,
Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
Linux Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues
Date: Tue, 6 Jun 2023 19:28:52 +0700 [thread overview]
Message-ID: <ZH8mhIrjyBvTF4oZ@debian.me> (raw)
In-Reply-To: <20230602085902.59006-1-franziska.naepelt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Fri, Jun 02, 2023 at 10:59:02AM +0200, Franziska Naepelt wrote:
> The following issues are fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - ERROR: trailing statements should be on next line
> - WARNING: braces {} are not necessary for single statement blocks
> - ERROR: space required before the open parenthesis '('
> - ERROR: code indent should use tabs where possible
> - WARNING: please, no spaces at the start of a line
> - WARNING: Missing a blank line after declarations
Again, write the patch description in imperative mood (e.g. "Do foo").
> +// SPDX-License-Identifier: LGPL-2.1
> /* Extract X.509 certificate in DER form from PKCS#11 or PEM.
> *
> * Copyright © 2014-2015 Red Hat, Inc. All Rights Reserved.
Nope.
The license boilerplate says LGPL 2.1 or any later version, so the
corresponding SPDX tag should have been:
```
// SPDX-License-Identifier: LGPL-2.1-or-later
```
And please also delete the boilerplate and separate this SPDX conversion
into its own patch.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-06 12:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:05 [PATCH] certs/extract-cert: Fix checkpatch issues Franziska Naepelt
2023-06-02 2:27 ` kernel test robot
2023-06-02 3:09 ` kernel test robot
2023-06-02 8:59 ` [PATCH v2] " Franziska Naepelt
2023-06-06 12:28 ` Bagas Sanjaya [this message]
2023-06-06 13:38 ` Dan Carpenter
2023-06-06 14:51 ` Jarkko Sakkinen
2023-06-06 15:25 ` Dan Carpenter
2023-06-06 16:03 ` Jarkko Sakkinen
2023-06-06 17:59 ` Franziska Näpelt
2023-06-06 18:29 ` Dan Carpenter
2023-06-06 21:43 ` Ben Boeckel
2023-06-07 16:11 ` Jarkko Sakkinen
2023-06-09 14:01 ` Dan Carpenter
2023-06-09 15:37 ` Jarkko Sakkinen
2023-06-09 15:43 ` Jarkko Sakkinen
2023-06-06 12:38 ` Jarkko Sakkinen
2023-06-06 12:44 ` Jarkko Sakkinen
2023-06-06 12:47 ` Jarkko Sakkinen
2023-06-06 14:44 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH8mhIrjyBvTF4oZ@debian.me \
--to=bagasdotme@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=franziska.naepelt@gmail.com \
--cc=franziska.naepelt@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).