* [PATCHv2] selftests: damon: add config file
@ 2023-04-12 9:28 Anders Roxell
2023-04-12 16:58 ` SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: Anders Roxell @ 2023-04-12 9:28 UTC (permalink / raw)
To: sj, shuah
Cc: linux-kernel, damon, linux-mm, linux-kselftest, Anders Roxell,
Naresh Kamboju
Building and running the subsuite 'damon' of kselftest, shows the
following issues:
selftests: damon: debugfs_attrs.sh
/sys/kernel/debug/damon not found
By creating a config file enabling DAMON fragments in the
selftests/damon/ directory the tests pass.
Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
tools/testing/selftests/damon/config | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 tools/testing/selftests/damon/config
diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
new file mode 100644
index 000000000000..0daf38974eb0
--- /dev/null
+++ b/tools/testing/selftests/damon/config
@@ -0,0 +1,7 @@
+CONFIG_DAMON=y
+CONFIG_DAMON_SYSFS=y
+CONFIG_DAMON_DBGFS=y
+CONFIG_DAMON_PADDR=y
+CONFIG_DAMON_VADDR=y
+CONFIG_DAMON_RECLAIM=y
+CONFIG_DAMON_LRU_SORT=y
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] selftests: damon: add config file
2023-04-12 9:28 [PATCHv2] selftests: damon: add config file Anders Roxell
@ 2023-04-12 16:58 ` SeongJae Park
2023-06-09 19:16 ` SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2023-04-12 16:58 UTC (permalink / raw)
To: Anders Roxell
Cc: sj, shuah, linux-kernel, damon, linux-mm, linux-kselftest,
Naresh Kamboju
Hi Anders,
On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote:
> Building and running the subsuite 'damon' of kselftest, shows the
> following issues:
> selftests: damon: debugfs_attrs.sh
> /sys/kernel/debug/damon not found
>
> By creating a config file enabling DAMON fragments in the
> selftests/damon/ directory the tests pass.
>
> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
checkpatch.pl is warning as below:
WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
#20:
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you
have a link to put here? I guess the report was made inside Linaro, so might
have no publicly available link. Maybe better to add some notes or some funny
tag like "Link: N/A # no publicly-available link of the report" for convincing
the tool, but I don't think this should be a blocker for this patch.
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> tools/testing/selftests/damon/config | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 tools/testing/selftests/damon/config
>
> diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
> new file mode 100644
> index 000000000000..0daf38974eb0
> --- /dev/null
> +++ b/tools/testing/selftests/damon/config
> @@ -0,0 +1,7 @@
> +CONFIG_DAMON=y
> +CONFIG_DAMON_SYSFS=y
> +CONFIG_DAMON_DBGFS=y
> +CONFIG_DAMON_PADDR=y
> +CONFIG_DAMON_VADDR=y
> +CONFIG_DAMON_RECLAIM=y
> +CONFIG_DAMON_LRU_SORT=y
> --
> 2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] selftests: damon: add config file
2023-04-12 16:58 ` SeongJae Park
@ 2023-06-09 19:16 ` SeongJae Park
2023-06-12 22:32 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2023-06-09 19:16 UTC (permalink / raw)
To: SeongJae Park
Cc: akpm, Anders Roxell, shuah, linux-kernel, damon, linux-mm,
linux-kselftest, Naresh Kamboju
On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <sj@kernel.org> wrote:
> Hi Anders,
>
> On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote:
>
> > Building and running the subsuite 'damon' of kselftest, shows the
> > following issues:
> > selftests: damon: debugfs_attrs.sh
> > /sys/kernel/debug/damon not found
> >
> > By creating a config file enabling DAMON fragments in the
> > selftests/damon/ directory the tests pass.
> >
> > Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> checkpatch.pl is warning as below:
>
> WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
> #20:
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
> warn when Reported-by: is not followed by Link:")'s commit message. Do you
> have a link to put here? I guess the report was made inside Linaro, so might
> have no publicly available link. Maybe better to add some notes or some funny
> tag like "Link: N/A # no publicly-available link of the report" for convincing
> the tool, but I don't think this should be a blocker for this patch.
>
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
Shuah, may I ask your opinion on this patch?
I'm also cc-ing Andrew, as he may also interested in picking this patch.
Thanks,
SJ
>
>
> Thanks,
> SJ
>
> > ---
> > tools/testing/selftests/damon/config | 7 +++++++
> > 1 file changed, 7 insertions(+)
> > create mode 100644 tools/testing/selftests/damon/config
> >
> > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
> > new file mode 100644
> > index 000000000000..0daf38974eb0
> > --- /dev/null
> > +++ b/tools/testing/selftests/damon/config
> > @@ -0,0 +1,7 @@
> > +CONFIG_DAMON=y
> > +CONFIG_DAMON_SYSFS=y
> > +CONFIG_DAMON_DBGFS=y
> > +CONFIG_DAMON_PADDR=y
> > +CONFIG_DAMON_VADDR=y
> > +CONFIG_DAMON_RECLAIM=y
> > +CONFIG_DAMON_LRU_SORT=y
> > --
> > 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] selftests: damon: add config file
2023-06-09 19:16 ` SeongJae Park
@ 2023-06-12 22:32 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2023-06-12 22:32 UTC (permalink / raw)
To: SeongJae Park
Cc: akpm, Anders Roxell, shuah, linux-kernel, damon, linux-mm,
linux-kselftest, Naresh Kamboju, Shuah Khan
On 6/9/23 13:16, SeongJae Park wrote:
> On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <sj@kernel.org> wrote:
>
>> Hi Anders,
>>
>> On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>>> Building and running the subsuite 'damon' of kselftest, shows the
>>> following issues:
>>> selftests: damon: debugfs_attrs.sh
>>> /sys/kernel/debug/damon not found
>>>
>>> By creating a config file enabling DAMON fragments in the
>>> selftests/damon/ directory the tests pass.
>>>
>>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
>>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>
>> checkpatch.pl is warning as below:
>>
>> WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
>> #20:
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>
>> The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
>> warn when Reported-by: is not followed by Link:")'s commit message. Do you
>> have a link to put here? I guess the report was made inside Linaro, so might
>> have no publicly available link. Maybe better to add some notes or some funny
>> tag like "Link: N/A # no publicly-available link of the report" for convincing
>> the tool, but I don't think this should be a blocker for this patch.
>>
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>
>> Reviewed-by: SeongJae Park <sj@kernel.org>
>
> Shuah, may I ask your opinion on this patch?
>
> I'm also cc-ing Andrew, as he may also interested in picking this patch.
>
If Andrew wants to pick this up:
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-12 22:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12 9:28 [PATCHv2] selftests: damon: add config file Anders Roxell
2023-04-12 16:58 ` SeongJae Park
2023-06-09 19:16 ` SeongJae Park
2023-06-12 22:32 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).