* Existing failures on stable 1.2 @ 2008-04-20 18:08 Luis Lavena [not found] ` <71166b3b0804201108o663495c4w141cb9f059ed3e55-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Luis Lavena @ 2008-04-20 18:08 UTC (permalink / raw) To: Mongrel Developers (ML) Hello Guys, I'm still getting these two: 1) Failure: test_horrible_queries(HttpParserTest) [./test/unit/test_http_parser.rb:105:in `test_horrible_queries' ./test/unit/test_http_parser.rb:103:in `times' ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']: <Mongrel::HttpParserError> exception expected but none was thrown. 2) Error: test_parse_strange_headers(HttpParserTest): Mongrel::HttpParserError: Invalid HTTP format, parsing fails. ./test/unit/test_http_parser.rb:49:in `execute' ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers' 59 tests, 458 assertions, 1 failures, 1 errors I want to confirm these are real (and not just me) and if someone else is working on those, or should I tackle them. Thanks in advance and have a nice weekend, -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <71166b3b0804201108o663495c4w141cb9f059ed3e55-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <71166b3b0804201108o663495c4w141cb9f059ed3e55-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-04-20 18:44 ` Evan Weaver [not found] ` <b6f68fc60804201144v83fbd92ld78c8acb62d3212d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Evan Weaver @ 2008-04-20 18:44 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw These are real-ish. We can fix the first one by reverting to Ragel 5. We can just remove the second one and document headers with linebreaks as being not supported. Evan On Sun, Apr 20, 2008 at 2:08 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Hello Guys, > > I'm still getting these two: > > 1) Failure: > test_horrible_queries(HttpParserTest) > [./test/unit/test_http_parser.rb:105:in `test_horrible_queries' > ./test/unit/test_http_parser.rb:103:in `times' > ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']: > <Mongrel::HttpParserError> exception expected but none was thrown. > > 2) Error: > test_parse_strange_headers(HttpParserTest): > Mongrel::HttpParserError: Invalid HTTP format, parsing fails. > ./test/unit/test_http_parser.rb:49:in `execute' > ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers' > > 59 tests, 458 assertions, 1 failures, 1 errors > > I want to confirm these are real (and not just me) and if someone else > is working on those, or should I tackle them. > > Thanks in advance and have a nice weekend, > -- > Luis Lavena > Multimedia systems > - > Human beings, who are almost unique in having the ability to learn from > the experience of others, are also remarkable for their apparent > disinclination to do so. > Douglas Adams > _______________________________________________ > Mongrel-development mailing list > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > http://rubyforge.org/mailman/listinfo/mongrel-development > -- Evan Weaver Cloudburst, LLC ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <b6f68fc60804201144v83fbd92ld78c8acb62d3212d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <b6f68fc60804201144v83fbd92ld78c8acb62d3212d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-04-20 18:47 ` Luis Lavena 2008-04-20 18:58 ` ry dahl 1 sibling, 0 replies; 10+ messages in thread From: Luis Lavena @ 2008-04-20 18:47 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw On Sun, Apr 20, 2008 at 3:44 PM, Evan Weaver <evan-72XWLPH10WVXUHR/Jj/Uug@public.gmane.org> wrote: > These are real-ish. We can fix the first one by reverting to Ragel 5. > We can just remove the second one and document headers with linebreaks > as being not supported. > I'm not against any of these two options. But I'll love to hear back from the submitters of these patches and how they could endorse/fix these issues without taking them out. > Evan > Regards, -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Existing failures on stable 1.2 [not found] ` <b6f68fc60804201144v83fbd92ld78c8acb62d3212d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 18:47 ` Luis Lavena @ 2008-04-20 18:58 ` ry dahl [not found] ` <3ae7f4480804201158n48585f47j6f0002ad2da4783f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 1 sibling, 1 reply; 10+ messages in thread From: ry dahl @ 2008-04-20 18:58 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw I was looking into that but had problems. The linebreak problem has been there since 1.0.1 On Sun, Apr 20, 2008 at 8:44 PM, Evan Weaver <evan-72XWLPH10WVXUHR/Jj/Uug@public.gmane.org> wrote: > These are real-ish. We can fix the first one by reverting to Ragel 5. > We can just remove the second one and document headers with linebreaks > as being not supported. > > Evan > > > > On Sun, Apr 20, 2008 at 2:08 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > Hello Guys, > > > > I'm still getting these two: > > > > 1) Failure: > > test_horrible_queries(HttpParserTest) > > [./test/unit/test_http_parser.rb:105:in `test_horrible_queries' > > ./test/unit/test_http_parser.rb:103:in `times' > > ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']: > > <Mongrel::HttpParserError> exception expected but none was thrown. > > > > 2) Error: > > test_parse_strange_headers(HttpParserTest): > > Mongrel::HttpParserError: Invalid HTTP format, parsing fails. > > ./test/unit/test_http_parser.rb:49:in `execute' > > ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers' > > > > 59 tests, 458 assertions, 1 failures, 1 errors > > > > I want to confirm these are real (and not just me) and if someone else > > is working on those, or should I tackle them. > > > > Thanks in advance and have a nice weekend, > > -- > > Luis Lavena > > Multimedia systems > > - > > Human beings, who are almost unique in having the ability to learn from > > the experience of others, are also remarkable for their apparent > > disinclination to do so. > > Douglas Adams > > _______________________________________________ > > Mongrel-development mailing list > > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > > http://rubyforge.org/mailman/listinfo/mongrel-development > > > > > > -- > Evan Weaver > Cloudburst, LLC > > > _______________________________________________ > Mongrel-development mailing list > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > http://rubyforge.org/mailman/listinfo/mongrel-development > ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <3ae7f4480804201158n48585f47j6f0002ad2da4783f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <3ae7f4480804201158n48585f47j6f0002ad2da4783f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-04-20 19:06 ` Luis Lavena [not found] ` <71166b3b0804201206y67dea70bj7c7c438a7ae4fb82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Luis Lavena @ 2008-04-20 19:06 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > I was looking into that but had problems. The linebreak problem has > been there since 1.0.1 > Hmn, ran the tests for 1.0.1 at that time before release the binary win32 gem and didn't see that failure... But my brain start playing tricks lately, so cannot be 100% certain. And seems I didn't yelled at the mailing list so maybe there was no failure before ragel 5 on the code. -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <71166b3b0804201206y67dea70bj7c7c438a7ae4fb82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <71166b3b0804201206y67dea70bj7c7c438a7ae4fb82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-04-20 19:13 ` ry dahl [not found] ` <3ae7f4480804201213i1f5bc0deu9e39ee7cb19c1ee8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: ry dahl @ 2008-04-20 19:13 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw it's been commented out since at least 0.3.14. linebreaks in header values is pretty debatable - does this actually happen? On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > > I was looking into that but had problems. The linebreak problem has > > been there since 1.0.1 > > > > Hmn, ran the tests for 1.0.1 at that time before release the binary > win32 gem and didn't see that failure... > > But my brain start playing tricks lately, so cannot be 100% certain. > And seems I didn't yelled at the mailing list so maybe there was no > failure before ragel 5 on the code. > > -- > > > Luis Lavena > Multimedia systems > - > Human beings, who are almost unique in having the ability to learn from > the experience of others, are also remarkable for their apparent > disinclination to do so. > Douglas Adams > _______________________________________________ > Mongrel-development mailing list > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > http://rubyforge.org/mailman/listinfo/mongrel-development > ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <3ae7f4480804201213i1f5bc0deu9e39ee7cb19c1ee8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <3ae7f4480804201213i1f5bc0deu9e39ee7cb19c1ee8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-04-20 19:25 ` Evan Weaver 2008-04-21 17:38 ` Eric Wong 1 sibling, 0 replies; 10+ messages in thread From: Evan Weaver @ 2008-04-20 19:25 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw Nobody has ask for support that I know of. Evan On Sun, Apr 20, 2008 at 3:13 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > it's been commented out since at least 0.3.14. linebreaks in header > values is pretty debatable - does this actually happen? > > > > On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > > > I was looking into that but had problems. The linebreak problem has > > > been there since 1.0.1 > > > > > > > Hmn, ran the tests for 1.0.1 at that time before release the binary > > win32 gem and didn't see that failure... > > > > But my brain start playing tricks lately, so cannot be 100% certain. > > And seems I didn't yelled at the mailing list so maybe there was no > > failure before ragel 5 on the code. > > > > -- > > > > > > Luis Lavena > > Multimedia systems > > - > > Human beings, who are almost unique in having the ability to learn from > > the experience of others, are also remarkable for their apparent > > disinclination to do so. > > Douglas Adams > > _______________________________________________ > > Mongrel-development mailing list > > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > > http://rubyforge.org/mailman/listinfo/mongrel-development > > > _______________________________________________ > Mongrel-development mailing list > Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org > http://rubyforge.org/mailman/listinfo/mongrel-development > -- Evan Weaver Cloudburst, LLC ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Existing failures on stable 1.2 [not found] ` <3ae7f4480804201213i1f5bc0deu9e39ee7cb19c1ee8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 19:25 ` Evan Weaver @ 2008-04-21 17:38 ` Eric Wong [not found] ` <20080421173842.GB15389-r0bfCMRs158eIZ0/mPfg9Q@public.gmane.org> 1 sibling, 1 reply; 10+ messages in thread From: Eric Wong @ 2008-04-21 17:38 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw Pen sends SSL certs with them. It actually shouldn't be too difficult to support, but I'm very strapped for time these days. ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > it's been commented out since at least 0.3.14. linebreaks in header > values is pretty debatable - does this actually happen? > > On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote: > > > I was looking into that but had problems. The linebreak problem has > > > been there since 1.0.1 > > > > > > > Hmn, ran the tests for 1.0.1 at that time before release the binary > > win32 gem and didn't see that failure... > > > > But my brain start playing tricks lately, so cannot be 100% certain. > > And seems I didn't yelled at the mailing list so maybe there was no > > failure before ragel 5 on the code. ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <20080421173842.GB15389-r0bfCMRs158eIZ0/mPfg9Q@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <20080421173842.GB15389-r0bfCMRs158eIZ0/mPfg9Q@public.gmane.org> @ 2008-04-22 0:16 ` Zed A. Shaw [not found] ` <20080421201656.da7e3270.zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Zed A. Shaw @ 2008-04-22 0:16 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw On Mon, 21 Apr 2008 10:38:42 -0700 Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote: > Pen sends SSL certs with them. It actually shouldn't be too difficult > to support, but I'm very strapped for time these days. And Pen is the only thing I've found that (ab)uses headers like this. Most of the usage out there didn't need it so I didn't bother adding it. Incidentally, http://www.and.org/and-httpd/ has an insane number of tests for nearly every http thing you could think of testing. I was originally going to base a test suite on his stuff, but never got around to it or found I needed it. -- Zed A. Shaw - Hate: http://savingtheinternetwithhate.com/ - Good: http://www.zedshaw.com/ - Evil: http://yearofevil.com/ ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <20080421201656.da7e3270.zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org>]
* Re: Existing failures on stable 1.2 [not found] ` <20080421201656.da7e3270.zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org> @ 2008-04-22 21:54 ` Luis Lavena 0 siblings, 0 replies; 10+ messages in thread From: Luis Lavena @ 2008-04-22 21:54 UTC (permalink / raw) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw On Mon, Apr 21, 2008 at 9:16 PM, Zed A. Shaw <zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org> wrote: > On Mon, 21 Apr 2008 10:38:42 -0700 > Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote: > > > Pen sends SSL certs with them. It actually shouldn't be too difficult > > to support, but I'm very strapped for time these days. > > And Pen is the only thing I've found that (ab)uses headers like this. > Most of the usage out there didn't need it so I didn't bother adding it. > > Incidentally, http://www.and.org/and-httpd/ has an insane number of > tests for nearly every http thing you could think of testing. I was > originally going to base a test suite on his stuff, but never got > around to it or found I needed it. > So mighty Zed, what we should do? :-D I've committed several changes to fix issues with mongrel_service for next release, but want to get rid all the failures on both platforms I'm supporting right now: i386-mswin32 and i386-mingw32 (VC6 and GCC builds of Ruby). So looking forward for suggestions before I pick up my axe (blame) and get rid of those without asking :-D -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-04-22 21:55 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2008-04-20 18:08 Existing failures on stable 1.2 Luis Lavena [not found] ` <71166b3b0804201108o663495c4w141cb9f059ed3e55-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 18:44 ` Evan Weaver [not found] ` <b6f68fc60804201144v83fbd92ld78c8acb62d3212d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 18:47 ` Luis Lavena 2008-04-20 18:58 ` ry dahl [not found] ` <3ae7f4480804201158n48585f47j6f0002ad2da4783f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 19:06 ` Luis Lavena [not found] ` <71166b3b0804201206y67dea70bj7c7c438a7ae4fb82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 19:13 ` ry dahl [not found] ` <3ae7f4480804201213i1f5bc0deu9e39ee7cb19c1ee8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2008-04-20 19:25 ` Evan Weaver 2008-04-21 17:38 ` Eric Wong [not found] ` <20080421173842.GB15389-r0bfCMRs158eIZ0/mPfg9Q@public.gmane.org> 2008-04-22 0:16 ` Zed A. Shaw [not found] ` <20080421201656.da7e3270.zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org> 2008-04-22 21:54 ` Luis Lavena
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).