diff options
| author | Eric Wong <e@80x24.org> | 2016-05-12 02:06:36 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2016-05-12 02:06:36 +0000 |
| commit | daef95d81b1c3b4dfe3e955d5f34d1be569d86b0 (patch) | |
| tree | 063f4e1ae6f7d56e0c37c2b7cb0ce56e89fe471d | |
| parent | 9073125f71afd615091f575d74ec468a0b1b79bf (diff) | |
| download | rack-lint-case-sens.tar.gz | |
lint: clarify "rack.hijack" case-sensitivity in response lint-case-sens
Based on my inspection of the webrick handler, it was
ambiguous as to whether "rack.hijack" is supposed to
be case-sensitive or not. Thankfully James cleared it up:
http://mid.gmane.org/CABGa_T8ihnKWwguObGCQqF-qBA+_v1YwM1-2tv3y5ShbWo4scw@mail.gmail.com
Note: I manually reapplied the SPEC change in
commit 72185735ad0c3aea4e37ab66b0c370e42180df39
("Fixed link and rack.session's indentation in SPEC")
after regenerating it from lint.rb
| -rw-r--r-- | SPEC | 3 | ||||
| -rw-r--r-- | lib/rack/lint.rb | 3 |
2 files changed, 4 insertions, 2 deletions
@@ -200,7 +200,8 @@ have been sent. In order to do this, an application may set the special header <tt>rack.hijack</tt> to an object that responds to <tt>call</tt> accepting an argument that conforms to the <tt>rack.hijack_io</tt> -protocol. +protocol. Unlike normal response headers, <tt>rack.hijack</tt> +is case-sensitive. After the headers have been sent, and this hijack callback has been called, the application is now responsible for the remaining lifecycle of the IO. The application is also responsible for maintaining HTTP diff --git a/lib/rack/lint.rb b/lib/rack/lint.rb index 54d37822..6eb24764 100644 --- a/lib/rack/lint.rb +++ b/lib/rack/lint.rb @@ -573,7 +573,8 @@ module Rack ## In order to do this, an application may set the special header ## <tt>rack.hijack</tt> to an object that responds to <tt>call</tt> ## accepting an argument that conforms to the <tt>rack.hijack_io</tt> - ## protocol. + ## protocol. Unlike normal response headers, <tt>rack.hijack</tt> + ## is case-sensitive. ## ## After the headers have been sent, and this hijack callback has been ## called, the application is now responsible for the remaining lifecycle |