* [PATCH] epoll: add newline to Kernel#warn messages for atomicity
@ 2017-03-17 0:07 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-03-17 0:07 UTC (permalink / raw)
To: sleepy-penguin
Relying on the record separator ($\ or "\n") is not atomic
on multi-process or multi-threaded systems writing to the
same log file or pipe.
---
lib/sleepy_penguin/epoll.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sleepy_penguin/epoll.rb b/lib/sleepy_penguin/epoll.rb
index 637db8d..da1502e 100644
--- a/lib/sleepy_penguin/epoll.rb
+++ b/lib/sleepy_penguin/epoll.rb
@@ -166,7 +166,7 @@ class SleepyPenguin::Epoll
begin
@io.epoll_ctl(CTL_MOD, io, events)
rescue Errno::ENOENT
- warn "epoll event cache failed (mod -> add)"
+ warn "epoll event cache failed (mod -> add)\n"
@io.epoll_ctl(CTL_ADD, io, events)
@marks[fd] = io
end
@@ -174,7 +174,7 @@ class SleepyPenguin::Epoll
begin
@io.epoll_ctl(CTL_ADD, io, events)
rescue Errno::EEXIST
- warn "epoll event cache failed (add -> mod)"
+ warn "epoll event cache failed (add -> mod)\n"
@io.epoll_ctl(CTL_MOD, io, events)
end
@marks[fd] = io
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-17 0:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-17 0:07 [PATCH] epoll: add newline to Kernel#warn messages for atomicity Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).