unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: "Bráulio Bhavamitra" <braulio@eita.org.br>
Cc: unicorn-public <unicorn-public@bogomips.org>
Subject: Re: Master hooks needed
Date: Sat, 4 Oct 2014 01:22:10 +0000	[thread overview]
Message-ID: <20141004012210.GA8134@dcvr.yhbt.net> (raw)
In-Reply-To: <CAJri6_s61q4-yMTp8Ev8HizDBnjGXqusmkrJODYX64TtFd+8ZA@mail.gmail.com>

Bráulio Bhavamitra <braulio@eita.org.br> wrote:
> The problem is actually worser, and the worker.nr == 0 can't be used.
> I had to do something like this:
> master_run = true
> before_fork do |server, worker|
>   if master_run
>      #warm up server...
>      #kill old pid...
>      #disconnect active record
>      master_run = false
>   end
>   # other stuff for each worker
> end
> In the last example, using worker.nr == 0 would make the server crash
> in case the worker 0 was killed/restarted.
> Also the AR's disconnect and *many other stuff* people put on
> before_fork should only be run once the master was preloaded, not for
> every worker.

AR disconnect! is idempotent and has been since unicorn existed.
I suspect most other things people run in before_fork are already
idempotent, too.

> So I still think at least a hook like master_preloaded(server) is necessary.

Using the local 'master_run' variable in your before_fork already
accomplishes everything you needed, right?

I try to keep unicorn as lean as possible and not bloat it with
redundant features.  The current hooks already fulfill the minimal
requirements for supporting apps which do not behave properly under
preload_app=true, so I am not convinced why a new hook is necessary.

  reply	other threads:[~2014-10-04  1:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 11:34 Master hooks needed Bráulio Bhavamitra
2014-10-03 12:22 ` Eric Wong
2014-10-03 12:36   ` Valentin Mihov
2014-10-03 17:50     ` Eric Wong
2014-10-03 18:12       ` Valentin Mihov
2014-10-04  0:53   ` Bráulio Bhavamitra
2014-10-04  1:22     ` Eric Wong [this message]
2014-10-04  1:35       ` Bráulio Bhavamitra
2014-10-04  1:57         ` Eric Wong
2014-10-04  2:04           ` Bráulio Bhavamitra
2014-10-04  2:25             ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141004012210.GA8134@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=braulio@eita.org.br \
    --cc=unicorn-public@bogomips.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).