From: Fumiaki MATSUSHIMA <mtsm.fm@gmail.com>
To: unicorn-public@bogomips.org
Cc: mtsmfm@gmail.com
Subject: [PATCH] Use IO#wait instead to fix test for Ruby 1.9
Date: Sat, 24 Feb 2018 16:06:36 +0900 [thread overview]
Message-ID: <20180224070636.20651-1-mtsmfm@gmail.com> (raw)
IO#wait_readable is introduced since 2.0
I confirmed we can pass tests for all versions of Ruby with this patch.
https://github.com/mtsmfm/unicorn/pull/2
---
test/unit/test_ccc.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/unit/test_ccc.rb b/test/unit/test_ccc.rb
index 0db0c38..3be1439 100644
--- a/test/unit/test_ccc.rb
+++ b/test/unit/test_ccc.rb
@@ -44,7 +44,7 @@ def test_ccc_tcpi
# make sure the server is running, at least
client = TCPSocket.new(host, port)
client.write("GET / HTTP/1.1\r\nHost: example.com\r\n\r\n")
- assert client.wait_readable(10), 'never got response from server'
+ assert client.wait(10), 'never got response from server'
res = client.read
assert_match %r{\AHTTP/1\.1 200}, res, 'got part of first response'
assert_match %r{\r\n\r\n\z}, res, 'got end of response, server is ready'
--
2.14.1
next reply other threads:[~2018-02-24 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 7:06 Fumiaki MATSUSHIMA [this message]
2018-02-24 8:08 ` [PATCH] Use IO#wait instead to fix test for Ruby 1.9 Eric Wong
2018-02-25 11:34 ` Fumiaki Matsushima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224070636.20651-1-mtsmfm@gmail.com \
--to=mtsm.fm@gmail.com \
--cc=mtsmfm@gmail.com \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).