unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Fumiaki MATSUSHIMA <mtsm.fm@gmail.com>
Cc: unicorn-public@bogomips.org, mtsmfm@gmail.com
Subject: Re: [PATCH] Use IO#wait instead to fix test for Ruby 1.9
Date: Sat, 24 Feb 2018 08:08:55 +0000	[thread overview]
Message-ID: <20180224080855.GA13738@80x24.org> (raw)
In-Reply-To: <20180224070636.20651-1-mtsmfm@gmail.com>

Fumiaki MATSUSHIMA <mtsm.fm@gmail.com> wrote:
> IO#wait_readable is introduced since 2.0
> 
> I confirmed we can pass tests for all versions of Ruby with this patch.

Thanks, applied.  Not sure if it's worth making a new release
to fix a test case, so I might wait a bit and see if there's
other stuff.

Also curious, how long do folks intend to continue using 1.9.3?

I don't care for whatever ruby-core claims to support, I know
realistically some folks (including distros) continue using older
versions for a while and I'll do my best to support them.

  reply	other threads:[~2018-02-24  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24  7:06 [PATCH] Use IO#wait instead to fix test for Ruby 1.9 Fumiaki MATSUSHIMA
2018-02-24  8:08 ` Eric Wong [this message]
2018-02-25 11:34   ` Fumiaki Matsushima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180224080855.GA13738@80x24.org \
    --to=e@80x24.org \
    --cc=mtsm.fm@gmail.com \
    --cc=mtsmfm@gmail.com \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).