From: Sam Saffron <sam.saffron@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: unblock function in pg messes up with unicorn
Date: Sat, 7 Dec 2013 11:04:59 +1100 [thread overview]
Message-ID: <CAAtdryPaZGmD9ceTuKZo+R2ga1=kv5zUhadt4_B2UzUq2HOMvA@mail.gmail.com> (raw)
In-Reply-To: <20131206184849.GA27820@dcvr.yhbt.net>
yeah, mysql appears to be using the default ubf which simply forces
your thread to be scheduled
https://github.com/brianmario/mysql2/blob/a9787cbb88f18d12f0b5c370c519d077ad68c862/ext/mysql2/result.c#L203
I think it would be cool to change unicorn to perform all the master /
worker coordination via pipes, only caveat is that QUIT and USR1 on
workers will still not work as expected if using the pg gem.
I am not sure Something like trap(:QUIT, no_ubf: true) would fly with
core but I can raise a ticket on redmine and see what people think.
On Sat, Dec 7, 2013 at 5:48 AM, Eric Wong <normalperson@yhbt.net> wrote:
> Sam Saffron <sam.saffron@gmail.com> wrote:
>> 1. Is this a pg bug? How could they even implement a ubf in such a way
>> that it does not stop queries when signals are sent? The main issue is
>> that without this Thread.kill will have to wait for queries to finish.
>
> No, not a pg bug. pg needs to account for the user hitting Ctrl-C and
> wanting to cancel a query (oh-no-I-started-DELETE-without-WHERE!).
>
>> 2. Is this a ruby bug? should there be a more sophisticated protocol
>> here? Should trap handlers inform the runtime that a ubf is not
>> needed?
>
> I don't know. Something like: trap(:QUIT, no_ubf: true) { ... } ?
>
>> something else ?
>
> Also see http://mid.gmane.org/20131120094717.GA17836@dcvr.yhbt.net
>
> Btw, given the master <-> worker separation in unicorn, we can also
> have the master talk to the worker through a pipe and avoid signals
> between the two.
>
>> Similar issue exists in mysql afaik.
>
> I don't think the mysql2 gem currently interrupts running queries.
> Not sure about the others.
> _______________________________________________
> Unicorn mailing list - mongrel-unicorn@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-unicorn
> Do not quote signatures (like this one) or top post when replying
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2013-12-07 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 12:29 unblock function in pg messes up with unicorn Sam Saffron
2013-12-06 18:48 ` Eric Wong
2013-12-07 0:04 ` Sam Saffron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAtdryPaZGmD9ceTuKZo+R2ga1=kv5zUhadt4_B2UzUq2HOMvA@mail.gmail.com' \
--to=sam.saffron@gmail.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).