unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* Bug, Unicorn can drop signals in extreme conditions
@ 2015-02-16  2:19 Steven Stewart-Gallus
  2015-02-18  9:15 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Stewart-Gallus @ 2015-02-16  2:19 UTC (permalink / raw)
  To: unicorn-public


While reading the article at
http://www.sitepoint.com/the-self-pipe-trick-explained/ I realized
that the signal handling code shown there and of the same type in your
application is broken.  As you have a single nonblocking pipe in your
application you can drop signals entirely (and not just fold multiple
signals of the same type into one).  The simplest fix is to use a pipe
for each individual type of signal or to just use pselect or similar.
I'm pretty sure that there is a way to use a single pipe but it seems
complicated and very difficult to implement correctly.

Thank you,
Steven Stewart-Gallus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-18 17:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-16  2:19 Bug, Unicorn can drop signals in extreme conditions Steven Stewart-Gallus
2015-02-18  9:15 ` Eric Wong
2015-02-18 17:27   ` Steven Stewart-Gallus

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).