yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: e@80x24.org
Subject: [PATCH 1/6] http_response: remove arg for Array#join
Date: Thu, 20 Nov 2014 20:45:37 +0000	[thread overview]
Message-ID: <1416516342-18987-2-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1416516342-18987-1-git-send-email-e@80x24.org>

Our kv_str method already fails if `$,' is a non-empty string.
Rack::Chunked and likely other middlewares fails when `$,' is
not empty, too, so supporting apps which set `$,' is probably
not feasible.
---
 lib/yahns/http_response.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index 33ae93e..e48e57c 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -27,7 +27,7 @@ module Yahns::HttpResponse # :nodoc:
   CONN_CLOSE = "Connection: close\r\n\r\n"
   Z = ""
   CCC_RESPONSE_START = [ 'HTTP', '/1.1 ' ]
-  RESPONSE_START = CCC_RESPONSE_START.join('')
+  RESPONSE_START = CCC_RESPONSE_START.join
   R100_RAW = "HTTP/1.1 100 Continue\r\n\r\n"
   R100_CCC = "100 Continue\r\n\r\nHTTP/1.1 "
   HTTP_EXPECT = "HTTP_EXPECT"
-- 
EW


  reply	other threads:[~2014-11-20 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 20:45 [PATCH 0/6] misc minor updates Eric Wong
2014-11-20 20:45 ` Eric Wong [this message]
2014-11-20 20:45 ` [PATCH 2/6] remove unused client_max_header_size config Eric Wong
2014-11-20 20:45 ` [PATCH 3/6] config: use literal symbol array for now Eric Wong
2014-11-20 20:45 ` [PATCH 4/6] http_response: reduce constants for 100 responses Eric Wong
2014-11-20 20:45 ` [PATCH 5/6] favor Array#map! for freshly-split arrays Eric Wong
2014-11-20 20:45 ` [PATCH 6/6] sendfile_compat: remove dependency on pread Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416516342-18987-2-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).