yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: e@80x24.org
Subject: [PATCH 2/6] remove unused client_max_header_size config
Date: Thu, 20 Nov 2014 20:45:38 +0000	[thread overview]
Message-ID: <1416516342-18987-3-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1416516342-18987-1-git-send-email-e@80x24.org>

We may not be able to support this in a more performant
way just yet.  Since this was never documented, we'll remove
the the current knobs for silently setting and ignoring it.

Users should use Unicorn::HttpParser.max_header_len= for now,
instead.  We may change Unicorn::HttpParser in the future if enough
people care about making this functionality per-app.
 lib/yahns/config.rb       | 1 -
 lib/yahns/http_context.rb | 1 -
 2 files changed, 2 deletions(-)

diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb
index 4ea51af..3055539 100644
--- a/lib/yahns/config.rb
+++ b/lib/yahns/config.rb
@@ -363,7 +363,6 @@ class Yahns::Config # :nodoc:
     # config name, minimum value
     client_body_buffer_size: 1,
     client_header_buffer_size: 1,
-    client_max_header_size: 1,
   }.each do |_v,minval|
     %Q(def #{_v}(val);) <<
diff --git a/lib/yahns/http_context.rb b/lib/yahns/http_context.rb
index 349e129..73bb49a 100644
--- a/lib/yahns/http_context.rb
+++ b/lib/yahns/http_context.rb
@@ -9,7 +9,6 @@ module Yahns::HttpContext # :nodoc:
   attr_accessor :client_body_buffer_size
   attr_accessor :client_header_buffer_size
   attr_accessor :client_max_body_size
-  attr_accessor :client_max_header_size
   attr_accessor :input_buffering  # :lazy, true, false
   attr_accessor :output_buffering # true, false
   attr_accessor :persistent_connections # true or false only

  parent reply	other threads:[~2014-11-20 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 20:45 [PATCH 0/6] misc minor updates Eric Wong
2014-11-20 20:45 ` [PATCH 1/6] http_response: remove arg for Array#join Eric Wong
2014-11-20 20:45 ` Eric Wong [this message]
2014-11-20 20:45 ` [PATCH 3/6] config: use literal symbol array for now Eric Wong
2014-11-20 20:45 ` [PATCH 4/6] http_response: reduce constants for 100 responses Eric Wong
2014-11-20 20:45 ` [PATCH 5/6] favor Array#map! for freshly-split arrays Eric Wong
2014-11-20 20:45 ` [PATCH 6/6] sendfile_compat: remove dependency on pread Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416516342-18987-3-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).