* [PATCH] response: only stream "file" responses on known length
@ 2016-11-08 23:21 Eric Wong
2016-11-08 23:28 ` Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2016-11-08 23:21 UTC (permalink / raw)
To: yahns-public
This means we need to check Content-Length and use it
properly (unless Content-Range is set).
---
lib/yahns/http_response.rb | 9 ++++++---
lib/yahns/stream_file.rb | 4 ++--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index 32d1a45..ca28bbf 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -60,7 +60,7 @@ def err_response(code)
end
def response_header_blocked(header, body, alive, offset, count)
- if body.respond_to?(:to_path)
+ if body.respond_to?(:to_path) && count
alive = Yahns::StreamFile.new(body, alive, offset, count)
body = nil
end
@@ -152,7 +152,8 @@ def http_response_write(res, opt)
alive = false if value =~ /\bclose\b/i
when %r{\AContent-Length\z}i
term = true
- flags |= MSG_MORE if value.to_i > 0 && !hdr_only
+ clen = value.to_i
+ flags |= MSG_MORE if clen > 0 && !hdr_only
kv_str(buf, key, value)
when %r{\ATransfer-Encoding\z}i
term = true if value =~ /\bchunked\b/i
@@ -163,6 +164,8 @@ def http_response_write(res, opt)
kv_str(buf, key, value)
end
end
+ count ||= clen
+
if !term && chunk_ok
term = true
body = Yahns::ChunkBody.new(body, opt)
@@ -194,7 +197,7 @@ def http_response_write(res, opt)
return response_hijacked(hijack) if hijack
return http_response_done(alive) if hdr_only
- if body.respond_to?(:to_path)
+ if body.respond_to?(:to_path) && count
@state = body = Yahns::StreamFile.new(body, alive, offset, count)
return step_write
end
diff --git a/lib/yahns/stream_file.rb b/lib/yahns/stream_file.rb
index fdba5bf..6cce7a0 100644
--- a/lib/yahns/stream_file.rb
+++ b/lib/yahns/stream_file.rb
@@ -27,8 +27,8 @@ def initialize(body, persist, offset, count)
retry
end
end
- @sf_offset = offset
- @sf_count = count || @tmpio.size
+ @sf_offset = offset || 0
+ @sf_count = count
@wbuf_persist = persist # whether or not we keep the connection alive
@body = body
end
--
EW
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] response: only stream "file" responses on known length
2016-11-08 23:21 [PATCH] response: only stream "file" responses on known length Eric Wong
@ 2016-11-08 23:28 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2016-11-08 23:28 UTC (permalink / raw)
To: yahns-public
Eric Wong <e@80x24.org> wrote:
> diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
Oops, missed this :x
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -125,7 +125,7 @@ def kv_str(buf, key, value)
def http_response_write(res, opt)
status, headers, body = res
offset = 0
- count = hijack = nil
+ count = hijack = clen = nil
alive = @hs.next? && self.class.persistent_connections
flags = MSG_DONTWAIT
term = false
> @@ -152,7 +152,8 @@ def http_response_write(res, opt)
> alive = false if value =~ /\bclose\b/i
> when %r{\AContent-Length\z}i
> term = true
> - flags |= MSG_MORE if value.to_i > 0 && !hdr_only
> + clen = value.to_i
> + flags |= MSG_MORE if clen > 0 && !hdr_only
> kv_str(buf, key, value)
> when %r{\ATransfer-Encoding\z}i
> term = true if value =~ /\bchunked\b/i
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-08 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08 23:21 [PATCH] response: only stream "file" responses on known length Eric Wong
2016-11-08 23:28 ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).