about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-07-26 23:54:54 +0000
committerEric Wong <e@80x24.org>2016-07-26 23:54:54 +0000
commite138d022e98b66c535f9bbdb230e4b5087fd8f33 (patch)
treeffeec5891d2b3c1c7b623970a402ea2723fe2805
parent4d5c57d62e603cbadf6b896489ae49bb197b6fe8 (diff)
downloadyahns-e138d022e98b66c535f9bbdb230e4b5087fd8f33.tar.gz
rack 2.x has some incompatible changes an deprecations; support
it but remain compatible with rack 1.x for the next few years.
-rw-r--r--extras/try_gzip_static.rb10
-rw-r--r--test/test_output_buffering.rb5
-rw-r--r--test/test_reopen_logs.rb6
3 files changed, 18 insertions, 3 deletions
diff --git a/extras/try_gzip_static.rb b/extras/try_gzip_static.rb
index d412589..4dd435a 100644
--- a/extras/try_gzip_static.rb
+++ b/extras/try_gzip_static.rb
@@ -49,7 +49,7 @@ class TryGzipStatic
     end
 
     size = st.size
-    ranges = Rack::Utils.byte_ranges(env, size)
+    ranges = byte_ranges(env, size)
     if ranges.nil? || ranges.length > 1
       [ 200 ] # serve the whole thing, possibly with static gzip \o/
     elsif ranges.empty?
@@ -221,4 +221,12 @@ class TryGzipStatic
       [ code, h, [ msg ] ]
     end
   end
+
+  if Rack::Utils.respond_to?(:get_byte_ranges) # rack 2.0+
+    def byte_ranges(env, size)
+      Rack::Utils.get_byte_ranges(env['HTTP_RANGE'], size)
+    end
+  else # rack 1.x
+    def byte_ranges(env, size); Rack::Utils.byte_ranges(env, size); end
+  end
 end
diff --git a/test/test_output_buffering.rb b/test/test_output_buffering.rb
index da93b87..ba3e94a 100644
--- a/test/test_output_buffering.rb
+++ b/test/test_output_buffering.rb
@@ -126,7 +126,10 @@ class TestOutputBuffering < Testcase
           end
           size = gplv3.size
           len = size.to_s
-          ranges = Rack::Utils.byte_ranges(e, size)
+
+          ranges = Rack::Utils.respond_to?(:get_byte_ranges) ?
+                   Rack::Utils.get_byte_ranges(e['HTTP_RANGE'], size) :
+                   Rack::Utils.byte_ranges(e, size)
           status = 200
           h = { "Content-Type" => "text/plain", "Content-Length" => len }
           if ranges && ranges.size == 1
diff --git a/test/test_reopen_logs.rb b/test/test_reopen_logs.rb
index 2eb3e0d..2ad1306 100644
--- a/test/test_reopen_logs.rb
+++ b/test/test_reopen_logs.rb
@@ -2,7 +2,11 @@
 # License: GPL-3.0+ (https://www.gnu.org/licenses/gpl-3.0.txt)
 # frozen_string_literal: true
 require_relative 'server_helper'
-require 'rack/commonlogger'
+require 'rack'
+# trigger autoload, since rack 1.x => 2.x renames:
+# 'rack/commonlogger' => 'rack/common_logger'
+# so we can't require directly
+Rack::CommonLogger.class
 
 class TestReopenLogs < Testcase
   ENV["N"].to_i > 1 and parallelize_me!