From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/8] staging: sm7xxfb: remove numvgamodes
Date: Tue, 16 Jun 2015 19:12:05 +0530 [thread overview]
Message-ID: <1434462131-15191-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com>
numvgamodes was only used in one place, so remove the #define
and use its defined value.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/staging/sm7xxfb/sm7xx.h | 2 --
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index c5d6253..4dabda4 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -775,5 +775,3 @@ static struct ModeInit vgamode[] = {
},
},
};
-
-#define numvgamodes ARRAY_SIZE(vgamode)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 4d9b69d..5667fbf 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -477,7 +477,7 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
"sfb->width=%d sfb->height=%d sfb->fb->var.bits_per_pixel=%d sfb->hz=%d\n",
sfb->width, sfb->height, sfb->fb->var.bits_per_pixel, sfb->hz);
- for (j = 0; j < numvgamodes; j++) {
+ for (j = 0; j < ARRAY_SIZE(vgamode); j++) {
if (vgamode[j].mmsizex == sfb->width &&
vgamode[j].mmsizey == sfb->height &&
vgamode[j].bpp == sfb->fb->var.bits_per_pixel &&
--
1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/8] staging: sm7xxfb: remove numvgamodes
Date: Tue, 16 Jun 2015 13:54:05 +0000 [thread overview]
Message-ID: <1434462131-15191-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com>
numvgamodes was only used in one place, so remove the #define
and use its defined value.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/staging/sm7xxfb/sm7xx.h | 2 --
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index c5d6253..4dabda4 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -775,5 +775,3 @@ static struct ModeInit vgamode[] = {
},
},
};
-
-#define numvgamodes ARRAY_SIZE(vgamode)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 4d9b69d..5667fbf 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -477,7 +477,7 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
"sfb->width=%d sfb->height=%d sfb->fb->var.bits_per_pixel=%d sfb->hz=%d\n",
sfb->width, sfb->height, sfb->fb->var.bits_per_pixel, sfb->hz);
- for (j = 0; j < numvgamodes; j++) {
+ for (j = 0; j < ARRAY_SIZE(vgamode); j++) {
if (vgamode[j].mmsizex = sfb->width &&
vgamode[j].mmsizey = sfb->height &&
vgamode[j].bpp = sfb->fb->var.bits_per_pixel &&
--
1.8.1.2
next prev parent reply other threads:[~2015-06-16 13:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 13:42 [PATCH 1/8] staging: sm7xxfb: declare struct as const Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` Sudip Mukherjee [this message]
2015-06-16 13:54 ` [PATCH 2/8] staging: sm7xxfb: remove numvgamodes Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 3/8] staging: sm7xxfb: add newline Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 4/8] staging: sm7xxfb: no space after cast Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 5/8] staging: sm7xxfb: fix alignment Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 6/8] staging: sm7xxfb: reduce indention Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 7/8] staging: sm7xxfb: move mode table Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 17:33 ` Joe Perches
2015-06-16 17:33 ` Joe Perches
2015-06-17 8:15 ` Sudip Mukherjee
2015-06-17 8:27 ` Sudip Mukherjee
2015-06-17 8:20 ` Joe Perches
2015-06-17 8:20 ` Joe Perches
2015-06-17 11:30 ` Sudip Mukherjee
2015-06-17 11:42 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 8/8] staging: sm7xxfb: fix camelcase Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434462131-15191-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.