From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table
Date: Tue, 16 Jun 2015 10:33:57 -0700 [thread overview]
Message-ID: <1434476037.2689.1.camel@perches.com> (raw)
In-Reply-To: <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote:
> move vgamode table from the header file to the C file and mark it
> as const.
The slightly odd indentation could be fixed here too.
> +static const struct ModeInit vgamode[] = {
> + {
> + /* mode#0: 640 x 480 16Bpp 60Hz */
> + 640, 480, 16, 60,
> + /* Init_MISC */
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table
Date: Tue, 16 Jun 2015 17:33:57 +0000 [thread overview]
Message-ID: <1434476037.2689.1.camel@perches.com> (raw)
In-Reply-To: <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote:
> move vgamode table from the header file to the C file and mark it
> as const.
The slightly odd indentation could be fixed here too.
> +static const struct ModeInit vgamode[] = {
> + {
> + /* mode#0: 640 x 480 16Bpp 60Hz */
> + 640, 480, 16, 60,
> + /* Init_MISC */
next prev parent reply other threads:[~2015-06-16 17:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 13:42 [PATCH 1/8] staging: sm7xxfb: declare struct as const Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 2/8] staging: sm7xxfb: remove numvgamodes Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 3/8] staging: sm7xxfb: add newline Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 4/8] staging: sm7xxfb: no space after cast Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 5/8] staging: sm7xxfb: fix alignment Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 6/8] staging: sm7xxfb: reduce indention Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 7/8] staging: sm7xxfb: move mode table Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
2015-06-16 17:33 ` Joe Perches [this message]
2015-06-16 17:33 ` Joe Perches
2015-06-17 8:15 ` Sudip Mukherjee
2015-06-17 8:27 ` Sudip Mukherjee
2015-06-17 8:20 ` Joe Perches
2015-06-17 8:20 ` Joe Perches
2015-06-17 11:30 ` Sudip Mukherjee
2015-06-17 11:42 ` Sudip Mukherjee
2015-06-16 13:42 ` [PATCH 8/8] staging: sm7xxfb: fix camelcase Sudip Mukherjee
2015-06-16 13:54 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434476037.2689.1.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.