From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>, Sudip Mukherjee <sudipm.mukherjee@gmail.com> Subject: [PATCH 5/8] staging: sm7xxfb: fix alignment Date: Tue, 16 Jun 2015 19:12:08 +0530 [thread overview] Message-ID: <1434462131-15191-5-git-send-email-sudipm.mukherjee@gmail.com> (raw) In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> Fix the alignment. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/staging/sm7xxfb/sm7xxfb.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index c832399..6bdcd5b 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -302,8 +302,8 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green, } #ifdef __BIG_ENDIAN -static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t - count, loff_t *ppos) +static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos) { unsigned long p = *ppos; @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t dst = buffer; for (i = c >> 2; i--;) { *dst = fb_readl(src++); - *dst = - (*dst & 0xff00ff00 >> 8) | - (*dst & 0x00ff00ff << 8); + *dst = (*dst & 0xff00ff00 >> 8) | + (*dst & 0x00ff00ff << 8); dst++; } if (c & 3) { @@ -381,9 +380,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t return (err) ? err : cnt; } -static ssize_t -smtcfb_write(struct fb_info *info, const char __user *buf, size_t count, - loff_t *ppos) +static ssize_t smtcfb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos) { unsigned long p = *ppos; @@ -552,8 +550,7 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb) writel(0x0, sfb->vp_regs + 0x40); /* set data width */ - m_nscreenstride = - (sfb->width * sfb->fb->var.bits_per_pixel) / 64; + m_nscreenstride = (sfb->width * sfb->fb->var.bits_per_pixel) / 64; switch (sfb->fb->var.bits_per_pixel) { case 8: writel(0x0, sfb->vp_regs + 0x0); -- 1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>, Sudip Mukherjee <sudipm.mukherjee@gmail.com> Subject: [PATCH 5/8] staging: sm7xxfb: fix alignment Date: Tue, 16 Jun 2015 13:54:08 +0000 [thread overview] Message-ID: <1434462131-15191-5-git-send-email-sudipm.mukherjee@gmail.com> (raw) In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> Fix the alignment. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/staging/sm7xxfb/sm7xxfb.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index c832399..6bdcd5b 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -302,8 +302,8 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green, } #ifdef __BIG_ENDIAN -static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t - count, loff_t *ppos) +static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos) { unsigned long p = *ppos; @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t dst = buffer; for (i = c >> 2; i--;) { *dst = fb_readl(src++); - *dst - (*dst & 0xff00ff00 >> 8) | - (*dst & 0x00ff00ff << 8); + *dst = (*dst & 0xff00ff00 >> 8) | + (*dst & 0x00ff00ff << 8); dst++; } if (c & 3) { @@ -381,9 +380,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t return (err) ? err : cnt; } -static ssize_t -smtcfb_write(struct fb_info *info, const char __user *buf, size_t count, - loff_t *ppos) +static ssize_t smtcfb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos) { unsigned long p = *ppos; @@ -552,8 +550,7 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb) writel(0x0, sfb->vp_regs + 0x40); /* set data width */ - m_nscreenstride - (sfb->width * sfb->fb->var.bits_per_pixel) / 64; + m_nscreenstride = (sfb->width * sfb->fb->var.bits_per_pixel) / 64; switch (sfb->fb->var.bits_per_pixel) { case 8: writel(0x0, sfb->vp_regs + 0x0); -- 1.8.1.2
next prev parent reply other threads:[~2015-06-16 13:42 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-16 13:42 [PATCH 1/8] staging: sm7xxfb: declare struct as const Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 2/8] staging: sm7xxfb: remove numvgamodes Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 3/8] staging: sm7xxfb: add newline Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 4/8] staging: sm7xxfb: no space after cast Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 13:42 ` Sudip Mukherjee [this message] 2015-06-16 13:54 ` [PATCH 5/8] staging: sm7xxfb: fix alignment Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 6/8] staging: sm7xxfb: reduce indention Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 7/8] staging: sm7xxfb: move mode table Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee 2015-06-16 17:33 ` Joe Perches 2015-06-16 17:33 ` Joe Perches 2015-06-17 8:15 ` Sudip Mukherjee 2015-06-17 8:27 ` Sudip Mukherjee 2015-06-17 8:20 ` Joe Perches 2015-06-17 8:20 ` Joe Perches 2015-06-17 11:30 ` Sudip Mukherjee 2015-06-17 11:42 ` Sudip Mukherjee 2015-06-16 13:42 ` [PATCH 8/8] staging: sm7xxfb: fix camelcase Sudip Mukherjee 2015-06-16 13:54 ` Sudip Mukherjee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1434462131-15191-5-git-send-email-sudipm.mukherjee@gmail.com \ --to=sudipm.mukherjee@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.