From: Sascha Hauer <s.hauer@pengutronix.de> To: Frank.Li@freescale.com Cc: linux-arm-kernel@lists.infradead.org, shawn.guo@linaro.org, shawnguo@kernel.org, linus.walleij@linaro.org, lznuaa@gmail.com, linux-gpio@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, Anson Huang <b20788@freescale.com>, Fugang Duan <B38611@freescale.com>, Fancy Fang <chen.fang@freescale.com> Subject: Re: [PATCH 6/8] ARM: dts: imx: add imx6ul and imx6ul evk board support Date: Thu, 18 Jun 2015 07:50:06 +0200 [thread overview] Message-ID: <20150618055006.GR6325@pengutronix.de> (raw) In-Reply-To: <1434555569-8237-7-git-send-email-Frank.Li@freescale.com> On Wed, Jun 17, 2015 at 11:39:27PM +0800, Frank.Li@freescale.com wrote: > From: Frank Li <Frank.Li@freescale.com> > > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + fsl,uart-has-rtscts; > + /* for DTE mode, add below change */ > + /* fsl,dte-mode; */ > + /* pinctrl-0 = <&pinctrl_uart2dte>; */ > + status = "okay"; > +}; > + > +&usdhc1 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc1>; > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > + cd-gpios = <&gpio1 19 0>; Use the correct polarity here. This is probably GPIO_ACTIVE_LOW. > + keep-power-in-suspend; > + enable-sdio-wakeup; > + vmmc-supply = <®_sd1_vmmc>; > + status = "okay"; > +}; > + > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + no-1-8-v; > + keep-power-in-suspend; > + enable-sdio-wakeup; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog_1>; > + imx6ul-evk { You can put the pinctrl nodes directly under the iomux node since: 5fcdf6a pinctrl: imx: Allow parsing DT without function nodes Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/8] ARM: dts: imx: add imx6ul and imx6ul evk board support Date: Thu, 18 Jun 2015 07:50:06 +0200 [thread overview] Message-ID: <20150618055006.GR6325@pengutronix.de> (raw) In-Reply-To: <1434555569-8237-7-git-send-email-Frank.Li@freescale.com> On Wed, Jun 17, 2015 at 11:39:27PM +0800, Frank.Li at freescale.com wrote: > From: Frank Li <Frank.Li@freescale.com> > > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + fsl,uart-has-rtscts; > + /* for DTE mode, add below change */ > + /* fsl,dte-mode; */ > + /* pinctrl-0 = <&pinctrl_uart2dte>; */ > + status = "okay"; > +}; > + > +&usdhc1 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc1>; > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > + cd-gpios = <&gpio1 19 0>; Use the correct polarity here. This is probably GPIO_ACTIVE_LOW. > + keep-power-in-suspend; > + enable-sdio-wakeup; > + vmmc-supply = <®_sd1_vmmc>; > + status = "okay"; > +}; > + > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + no-1-8-v; > + keep-power-in-suspend; > + enable-sdio-wakeup; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog_1>; > + imx6ul-evk { You can put the pinctrl nodes directly under the iomux node since: 5fcdf6a pinctrl: imx: Allow parsing DT without function nodes Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-06-18 5:50 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-17 15:39 [PATCH 0/8] add basic support for i.mx6 ul chip Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-06-17 15:39 ` [PATCH 1/8] ARM: imx: add i.mx6ul msl support Frank.Li 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-07-09 2:17 ` Shawn Guo 2015-07-09 2:17 ` Shawn Guo 2015-06-17 15:39 ` [PATCH 3/8] Document: dt: binding: imx: update document for imx6ul support Frank.Li 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-07-09 2:36 ` Shawn Guo 2015-07-09 2:36 ` Shawn Guo 2015-06-17 15:39 ` [PATCH 4/8] ARM: pinctrl: imx: add i.mx6ul pinctrl driver Frank.Li 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-07-09 2:38 ` Shawn Guo 2015-07-09 2:38 ` Shawn Guo [not found] ` <1434555569-8237-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2015-06-17 15:39 ` [PATCH 2/8] ARM: imx: add imx6ul clk tree support Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-06-18 5:40 ` Sascha Hauer 2015-06-18 5:40 ` Sascha Hauer 2015-06-17 15:39 ` [PATCH 5/8] ARM: dts: add i.mx6ul pin function include file Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-07-09 3:09 ` Shawn Guo 2015-07-09 3:09 ` Shawn Guo 2015-06-17 15:39 ` [PATCH 6/8] ARM: dts: imx: add imx6ul and imx6ul evk board support Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-06-18 5:50 ` Sascha Hauer [this message] 2015-06-18 5:50 ` Sascha Hauer 2015-07-09 7:02 ` Shawn Guo 2015-07-09 7:02 ` Shawn Guo 2015-06-17 15:39 ` [PATCH 7/8] ARM: imx: imx_v6_v7_defconfig enable imx6ul support Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com 2015-06-17 15:39 ` [PATCH 8/8] ARM: imx: add low-level debug support for i.mx6ul Frank.Li-KZfg59tc24xl57MIdRCFDg 2015-06-17 15:39 ` Frank.Li at freescale.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150618055006.GR6325@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=B38611@freescale.com \ --cc=Frank.Li@freescale.com \ --cc=b20788@freescale.com \ --cc=chen.fang@freescale.com \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=lznuaa@gmail.com \ --cc=robh+dt@kernel.org \ --cc=shawn.guo@linaro.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.