From: Shawn Guo <shawnguo@kernel.org>
To: Frank.Li@freescale.com
Cc: linux-arm-kernel@lists.infradead.org, shawn.guo@linaro.org,
linus.walleij@linaro.org, lznuaa@gmail.com,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
robh+dt@kernel.org, Anson Huang <b20788@freescale.com>,
Bai Ping <b51503@freescale.com>
Subject: Re: [PATCH 5/8] ARM: dts: add i.mx6ul pin function include file
Date: Thu, 9 Jul 2015 11:09:14 +0800 [thread overview]
Message-ID: <20150709030913.GA23464@tiger> (raw)
In-Reply-To: <1434555569-8237-6-git-send-email-Frank.Li@freescale.com>
On Wed, Jun 17, 2015 at 11:39:26PM +0800, Frank.Li@freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
>
> add pin mux define file
>
> Signed-off-by: Bai Ping <b51503@freescale.com>
> Signed-off-by: Anson Huang <b20788@freescale.com>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
> arch/arm/boot/dts/imx6ul-pinfunc.h | 938 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 938 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6ul-pinfunc.h
>
> diff --git a/arch/arm/boot/dts/imx6ul-pinfunc.h b/arch/arm/boot/dts/imx6ul-pinfunc.h
> new file mode 100644
> index 0000000..1bb774b9
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6ul-pinfunc.h
> @@ -0,0 +1,938 @@
> +/*
> + * Copyright (C) 2015 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +
> +#ifndef __DTS_IMX6UL_PINFUNC_H
> +#define __DTS_IMX6UL_PINFUNC_H
> +
> +/*
> + * The pin function ID is a tuple of
> + * <mux_reg conf_reg input_reg mux_mode input_val>
> + */
> +#define MX6UL_PAD_BOOT_MODE0__GPIO5_IO10 0x0014 0x02A0 0x0000 5 0
Please use space instead of tab between #define and macro. And if
possible, please change your scripts to use lowercase in hex value,
so that we are consistent with other i.MX pinfunc headers.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] ARM: dts: add i.mx6ul pin function include file
Date: Thu, 9 Jul 2015 11:09:14 +0800 [thread overview]
Message-ID: <20150709030913.GA23464@tiger> (raw)
In-Reply-To: <1434555569-8237-6-git-send-email-Frank.Li@freescale.com>
On Wed, Jun 17, 2015 at 11:39:26PM +0800, Frank.Li at freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
>
> add pin mux define file
>
> Signed-off-by: Bai Ping <b51503@freescale.com>
> Signed-off-by: Anson Huang <b20788@freescale.com>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
> arch/arm/boot/dts/imx6ul-pinfunc.h | 938 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 938 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6ul-pinfunc.h
>
> diff --git a/arch/arm/boot/dts/imx6ul-pinfunc.h b/arch/arm/boot/dts/imx6ul-pinfunc.h
> new file mode 100644
> index 0000000..1bb774b9
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6ul-pinfunc.h
> @@ -0,0 +1,938 @@
> +/*
> + * Copyright (C) 2015 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +
> +#ifndef __DTS_IMX6UL_PINFUNC_H
> +#define __DTS_IMX6UL_PINFUNC_H
> +
> +/*
> + * The pin function ID is a tuple of
> + * <mux_reg conf_reg input_reg mux_mode input_val>
> + */
> +#define MX6UL_PAD_BOOT_MODE0__GPIO5_IO10 0x0014 0x02A0 0x0000 5 0
Please use space instead of tab between #define and macro. And if
possible, please change your scripts to use lowercase in hex value,
so that we are consistent with other i.MX pinfunc headers.
Shawn
next prev parent reply other threads:[~2015-07-09 3:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 15:39 [PATCH 0/8] add basic support for i.mx6 ul chip Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-06-17 15:39 ` [PATCH 1/8] ARM: imx: add i.mx6ul msl support Frank.Li
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-07-09 2:17 ` Shawn Guo
2015-07-09 2:17 ` Shawn Guo
2015-06-17 15:39 ` [PATCH 3/8] Document: dt: binding: imx: update document for imx6ul support Frank.Li
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-07-09 2:36 ` Shawn Guo
2015-07-09 2:36 ` Shawn Guo
2015-06-17 15:39 ` [PATCH 4/8] ARM: pinctrl: imx: add i.mx6ul pinctrl driver Frank.Li
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-07-09 2:38 ` Shawn Guo
2015-07-09 2:38 ` Shawn Guo
[not found] ` <1434555569-8237-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-17 15:39 ` [PATCH 2/8] ARM: imx: add imx6ul clk tree support Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-06-18 5:40 ` Sascha Hauer
2015-06-18 5:40 ` Sascha Hauer
2015-06-17 15:39 ` [PATCH 5/8] ARM: dts: add i.mx6ul pin function include file Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-07-09 3:09 ` Shawn Guo [this message]
2015-07-09 3:09 ` Shawn Guo
2015-06-17 15:39 ` [PATCH 6/8] ARM: dts: imx: add imx6ul and imx6ul evk board support Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-06-18 5:50 ` Sascha Hauer
2015-06-18 5:50 ` Sascha Hauer
2015-07-09 7:02 ` Shawn Guo
2015-07-09 7:02 ` Shawn Guo
2015-06-17 15:39 ` [PATCH 7/8] ARM: imx: imx_v6_v7_defconfig enable imx6ul support Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
2015-06-17 15:39 ` [PATCH 8/8] ARM: imx: add low-level debug support for i.mx6ul Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-06-17 15:39 ` Frank.Li at freescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709030913.GA23464@tiger \
--to=shawnguo@kernel.org \
--cc=Frank.Li@freescale.com \
--cc=b20788@freescale.com \
--cc=b51503@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.