From: Brian Norris <computersforpeace@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Richard Weinberger <richard@nod.at>,
Bhuvanchandra DV <bhuvanchandradv@gmail.com>,
linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: UBIFS errors when file-system is full
Date: Wed, 2 Sep 2015 13:13:12 -0700 [thread overview]
Message-ID: <20150902201312.GA21475@google.com> (raw)
In-Reply-To: <f3a5ff1f82ee358541125b920460c17a@agner.ch>
On Wed, Sep 02, 2015 at 12:58:08PM -0700, Stefan Agner wrote:
> On 2015-08-31 18:43, Brian Norris wrote:
> > Why do you actually need to check the idle bit? If you need to read it
> > to clear out some FIFO, then that's fine -- just read it, but don't use
> > it as a second condition. The complete()/wait_for_completion()
> > synchronization should be sufficient on its own. (If not, then I think
> > you have other problems.)
> >
> > The NFC_IRQ_STATUS-based condition looks like it could lead to races
> > because your interrupt may fire between setting and checking
> > the idle bit. So the IRQ handler will increment the completion struct
> > (cmd_done), but you *won't* be doing the corresponding decrement via
> > wait_for_completion(). If you don't do that... then the subsequent
> > wait_for_completion() will immediately succeed.
>
> Tested over night and did some additional tests today, I did not see any
> issues for more than 2000 boots, so this really seems to fix the issue!
Awesome!
> Thanks Brian, will send out v12 soon.
Glad to help.
In case I didn't mention it already, I'm taking a closer look at Boris'
approach for this series:
http://lists.infradead.org/pipermail/linux-mtd/2015-August/061361.html
but your driver looks like a good candidate for using
nand_check_erased_ecc_chunk(), once we've agreed. Depenending on the
order of acceptance, I might like to get your driver converted either
before or after merging it. Shouldn't be too hard, though, as your
implementation looks very similar right now.
Brian
next prev parent reply other threads:[~2015-09-02 20:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:55 UBIFS errors when file-system is full Bhuvanchandra DV
2015-07-13 14:09 ` Richard Weinberger
2015-07-14 4:23 ` Bhuvanchandra DV
2015-07-14 6:13 ` Richard Weinberger
2015-07-14 6:30 ` Bhuvanchandra DV
2015-07-14 6:32 ` Richard Weinberger
2015-07-14 8:29 ` Bhuvanchandra DV
2015-07-14 8:42 ` Richard Weinberger
2015-07-14 10:08 ` Bhuvanchandra DV
2015-07-14 11:06 ` Richard Weinberger
[not found] ` <55A74812.2020906@gmail.com>
2015-07-16 7:35 ` Fwd: " Bhuvanchandra DV
[not found] ` <55A74AA1.2000000@nod.at>
[not found] ` <55A7540C.3050900@nod.at>
[not found] ` <55A7592D.6010906@gmail.com>
[not found] ` <55A75A05.7040603@nod.at>
2015-07-16 7:33 ` Bhuvanchandra DV
2015-07-21 6:04 ` Bhuvanchandra DV
2015-07-21 6:14 ` Richard Weinberger
2015-07-22 7:10 ` Bhuvanchandra DV
2015-07-22 7:20 ` Richard Weinberger
2015-07-24 14:43 ` Bhuvanchandra DV
2015-07-24 16:51 ` Richard Weinberger
2015-07-31 16:47 ` Bhuvanchandra DV
2015-08-01 6:36 ` Richard Weinberger
2015-08-06 10:31 ` Bhuvanchandra DV
2015-08-07 12:37 ` Richard Weinberger
2015-08-12 7:01 ` Stefan Agner
2015-08-12 7:27 ` Richard Weinberger
2015-09-01 0:45 ` Stefan Agner
2015-09-01 1:43 ` Brian Norris
2015-09-01 2:20 ` Stefan Agner
2015-09-02 19:58 ` Stefan Agner
2015-09-02 20:13 ` Brian Norris [this message]
2015-09-02 20:41 ` Stefan Agner
2015-09-07 13:47 ` Bhuvanchandra
2015-09-11 4:03 ` Bhuvanchandra
2015-09-12 9:39 ` Richard Weinberger
2015-09-13 4:45 ` Bhuvanchandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902201312.GA21475@google.com \
--to=computersforpeace@gmail.com \
--cc=bhuvanchandradv@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.