From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: sdhci: runtime suspend/resume on card insert/removal
Date: Thu, 10 Sep 2015 09:02:33 +0100 [thread overview]
Message-ID: <20150910080233.GH21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150910153129.07adbe68@xhacker>
On Thu, Sep 10, 2015 at 03:31:29PM +0800, Jisheng Zhang wrote:
> Hi Vaibhav,
>
> On Thu, 10 Sep 2015 12:40:48 +0530
> Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
>
> > Hi,
> >
> > During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
> > based platform, I observed that runtime PM suspend/resume is having
> > issues with card insertion and removal.
> >
> > Let me try to explain it using execution sequence -
> >
> > During boot:
> >
> > MMC SD card gets detected as expected.
> >
> > [ 2.431012] mmc1: new high speed SDHC card at address 1234
> > [ 2.437235] mmcblk1: mmc1:1234 SA04G 3.63 GiB
> > [ 2.444841] mmcblk1: p1
> >
> >
> > Now after coming to the linux prompt, if card removal event occurs
> > then the call sequence is -
> >
> > sdhci_irq() -->
> > -> sdhci_thread_irq(): host->thread_isr - 0x80
> > -> sdhci_card_event()
> > -> mmc_detect_change()
> > --> _mmc_detect_change()
> > ---> mmc_sd_detect()
> > mmc_sd_remove()
> > mmc_remove_card()
> > mmc_bus_remove()
> > mmc_power_off()
> > mmc_set_initial_state()
> > sdhci_set_ios()
> > ...
> > sdhci_pxav3_runtime_suspend()
> > sdhci_runtime_suspend_host()
> >
> >
> > Till here everything looks perfect :) (if I got it right)
> >
> > Now on card insertion again, the expectation is, runtime resume should
> > get called as part of interrupt trigger from the SDHCI controller on
> > card insertion.
>
> AFAIK, card insertion => wakeup irq, this irq doesn't come from SDHCI
Wakeup IRQs are what happens when the _system_ is in suspend, not
when the device is runtime suspended.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>,
ulf.hansson@linaro.org,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
nico@fluxnic.net
Subject: Re: sdhci: runtime suspend/resume on card insert/removal
Date: Thu, 10 Sep 2015 09:02:33 +0100 [thread overview]
Message-ID: <20150910080233.GH21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150910153129.07adbe68@xhacker>
On Thu, Sep 10, 2015 at 03:31:29PM +0800, Jisheng Zhang wrote:
> Hi Vaibhav,
>
> On Thu, 10 Sep 2015 12:40:48 +0530
> Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
>
> > Hi,
> >
> > During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
> > based platform, I observed that runtime PM suspend/resume is having
> > issues with card insertion and removal.
> >
> > Let me try to explain it using execution sequence -
> >
> > During boot:
> >
> > MMC SD card gets detected as expected.
> >
> > [ 2.431012] mmc1: new high speed SDHC card at address 1234
> > [ 2.437235] mmcblk1: mmc1:1234 SA04G 3.63 GiB
> > [ 2.444841] mmcblk1: p1
> >
> >
> > Now after coming to the linux prompt, if card removal event occurs
> > then the call sequence is -
> >
> > sdhci_irq() -->
> > -> sdhci_thread_irq(): host->thread_isr - 0x80
> > -> sdhci_card_event()
> > -> mmc_detect_change()
> > --> _mmc_detect_change()
> > ---> mmc_sd_detect()
> > mmc_sd_remove()
> > mmc_remove_card()
> > mmc_bus_remove()
> > mmc_power_off()
> > mmc_set_initial_state()
> > sdhci_set_ios()
> > ...
> > sdhci_pxav3_runtime_suspend()
> > sdhci_runtime_suspend_host()
> >
> >
> > Till here everything looks perfect :) (if I got it right)
> >
> > Now on card insertion again, the expectation is, runtime resume should
> > get called as part of interrupt trigger from the SDHCI controller on
> > card insertion.
>
> AFAIK, card insertion => wakeup irq, this irq doesn't come from SDHCI
Wakeup IRQs are what happens when the _system_ is in suspend, not
when the device is runtime suspended.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-09-10 8:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 7:10 sdhci: runtime suspend/resume on card insert/removal Vaibhav Hiremath
2015-09-10 7:10 ` Vaibhav Hiremath
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:57 ` Jisheng Zhang
2015-09-10 7:57 ` Jisheng Zhang
2015-09-10 8:02 ` Russell King - ARM Linux [this message]
2015-09-10 8:02 ` Russell King - ARM Linux
2015-09-10 8:04 ` Jisheng Zhang
2015-09-10 8:04 ` Jisheng Zhang
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:49 ` Russell King - ARM Linux
2015-09-14 12:49 ` Russell King - ARM Linux
2015-09-14 13:05 ` Vaibhav Hiremath
2015-09-14 13:05 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910080233.GH21084@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.