From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: sdhci: runtime suspend/resume on card insert/removal
Date: Thu, 10 Sep 2015 15:57:21 +0800 [thread overview]
Message-ID: <20150910155721.506f7483@xhacker> (raw)
In-Reply-To: <55F13670.1020902@linaro.org>
On Thu, 10 Sep 2015 13:21:12 +0530
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
>
>
> On Thursday 10 September 2015 01:01 PM, Jisheng Zhang wrote:
> > Hi Vaibhav,
> >
> > On Thu, 10 Sep 2015 12:40:48 +0530
> > Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
> >
> >> Hi,
> >>
> >> During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
> >> based platform, I observed that runtime PM suspend/resume is having
> >> issues with card insertion and removal.
> >>
> >> Let me try to explain it using execution sequence -
> >>
> >> During boot:
> >>
> >> MMC SD card gets detected as expected.
> >>
> >> [ 2.431012] mmc1: new high speed SDHC card at address 1234
> >> [ 2.437235] mmcblk1: mmc1:1234 SA04G 3.63 GiB
> >> [ 2.444841] mmcblk1: p1
> >>
> >>
> >> Now after coming to the linux prompt, if card removal event occurs
> >> then the call sequence is -
> >>
> >> sdhci_irq() -->
> >> -> sdhci_thread_irq(): host->thread_isr - 0x80
> >> -> sdhci_card_event()
> >> -> mmc_detect_change()
> >> --> _mmc_detect_change()
> >> ---> mmc_sd_detect()
> >> mmc_sd_remove()
> >> mmc_remove_card()
> >> mmc_bus_remove()
> >> mmc_power_off()
> >> mmc_set_initial_state()
> >> sdhci_set_ios()
> >> ...
> >> sdhci_pxav3_runtime_suspend()
> >> sdhci_runtime_suspend_host()
> >>
> >>
> >> Till here everything looks perfect :) (if I got it right)
> >>
> >> Now on card insertion again, the expectation is, runtime resume should
> >> get called as part of interrupt trigger from the SDHCI controller on
> >> card insertion.
> >
> > AFAIK, card insertion => wakeup irq, this irq doesn't come from SDHCI
> > controller itself because SDHCI controller is runtime suspended, clk gated
> > or power gated. So the wakeup irq should come from other always on components.
> > Take Marvell berlin SoC as an example:
> >
> > there's gpio for sdcard detect, card insertion => trigger cd gpio interrupt
> > =>resume sdhci host etc.
>
> Not always.
>
> In my case SDHCI controller is generating card insert and remove
> event/interrupts. Just to add here, I am not configuring any pins
How could sdhci controller generate card insert/remove interrupts if it's
clk gated or power gated? We should have another wake up mechanism for runtime pm.
> to GPIO mode. My pin configuration for card-detect is in MMC_CD mode.
I guess the pin is muxed between SD_CD pin and gpio.
>
> The card insertion and removal interrupt is mapped to SDHCI interrupt
> line, which is interrupt number 12 in my case.
>
> # cat /proc/interrupts
> CPU0
> 11: 55 GIC 105 Level mmc0
> 12: 220 GIC 101 Level mmc1
>
>
> >
> > If your changes work, the I guess your SDHCI host are not clk gated or
> > power gated during runtime suspended.
> >
>
> This is what I suspected initially, but it doesn't look that way.
>
> Without this change, if I just disable/remove
>
> pm_runtime_put_autosuspend(&pdev->dev);
>
> then also it works for me. What it tells me that, if I disable
> runtime_pm then it works.
>
> I can cross-check register values to make sure that it is really turned
> off. Let me do that as well.
>
> Thanks,
> Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
nico@fluxnic.net, ulf.hansson@linaro.org
Subject: Re: sdhci: runtime suspend/resume on card insert/removal
Date: Thu, 10 Sep 2015 15:57:21 +0800 [thread overview]
Message-ID: <20150910155721.506f7483@xhacker> (raw)
In-Reply-To: <55F13670.1020902@linaro.org>
On Thu, 10 Sep 2015 13:21:12 +0530
Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
>
>
> On Thursday 10 September 2015 01:01 PM, Jisheng Zhang wrote:
> > Hi Vaibhav,
> >
> > On Thu, 10 Sep 2015 12:40:48 +0530
> > Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote:
> >
> >> Hi,
> >>
> >> During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
> >> based platform, I observed that runtime PM suspend/resume is having
> >> issues with card insertion and removal.
> >>
> >> Let me try to explain it using execution sequence -
> >>
> >> During boot:
> >>
> >> MMC SD card gets detected as expected.
> >>
> >> [ 2.431012] mmc1: new high speed SDHC card at address 1234
> >> [ 2.437235] mmcblk1: mmc1:1234 SA04G 3.63 GiB
> >> [ 2.444841] mmcblk1: p1
> >>
> >>
> >> Now after coming to the linux prompt, if card removal event occurs
> >> then the call sequence is -
> >>
> >> sdhci_irq() -->
> >> -> sdhci_thread_irq(): host->thread_isr - 0x80
> >> -> sdhci_card_event()
> >> -> mmc_detect_change()
> >> --> _mmc_detect_change()
> >> ---> mmc_sd_detect()
> >> mmc_sd_remove()
> >> mmc_remove_card()
> >> mmc_bus_remove()
> >> mmc_power_off()
> >> mmc_set_initial_state()
> >> sdhci_set_ios()
> >> ...
> >> sdhci_pxav3_runtime_suspend()
> >> sdhci_runtime_suspend_host()
> >>
> >>
> >> Till here everything looks perfect :) (if I got it right)
> >>
> >> Now on card insertion again, the expectation is, runtime resume should
> >> get called as part of interrupt trigger from the SDHCI controller on
> >> card insertion.
> >
> > AFAIK, card insertion => wakeup irq, this irq doesn't come from SDHCI
> > controller itself because SDHCI controller is runtime suspended, clk gated
> > or power gated. So the wakeup irq should come from other always on components.
> > Take Marvell berlin SoC as an example:
> >
> > there's gpio for sdcard detect, card insertion => trigger cd gpio interrupt
> > =>resume sdhci host etc.
>
> Not always.
>
> In my case SDHCI controller is generating card insert and remove
> event/interrupts. Just to add here, I am not configuring any pins
How could sdhci controller generate card insert/remove interrupts if it's
clk gated or power gated? We should have another wake up mechanism for runtime pm.
> to GPIO mode. My pin configuration for card-detect is in MMC_CD mode.
I guess the pin is muxed between SD_CD pin and gpio.
>
> The card insertion and removal interrupt is mapped to SDHCI interrupt
> line, which is interrupt number 12 in my case.
>
> # cat /proc/interrupts
> CPU0
> 11: 55 GIC 105 Level mmc0
> 12: 220 GIC 101 Level mmc1
>
>
> >
> > If your changes work, the I guess your SDHCI host are not clk gated or
> > power gated during runtime suspended.
> >
>
> This is what I suspected initially, but it doesn't look that way.
>
> Without this change, if I just disable/remove
>
> pm_runtime_put_autosuspend(&pdev->dev);
>
> then also it works for me. What it tells me that, if I disable
> runtime_pm then it works.
>
> I can cross-check register values to make sure that it is really turned
> off. Let me do that as well.
>
> Thanks,
> Vaibhav
next prev parent reply other threads:[~2015-09-10 7:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 7:10 sdhci: runtime suspend/resume on card insert/removal Vaibhav Hiremath
2015-09-10 7:10 ` Vaibhav Hiremath
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:57 ` Jisheng Zhang [this message]
2015-09-10 7:57 ` Jisheng Zhang
2015-09-10 8:02 ` Russell King - ARM Linux
2015-09-10 8:02 ` Russell King - ARM Linux
2015-09-10 8:04 ` Jisheng Zhang
2015-09-10 8:04 ` Jisheng Zhang
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:49 ` Russell King - ARM Linux
2015-09-14 12:49 ` Russell King - ARM Linux
2015-09-14 13:05 ` Vaibhav Hiremath
2015-09-14 13:05 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910155721.506f7483@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.