From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: sdhci: runtime suspend/resume on card insert/removal
Date: Mon, 14 Sep 2015 13:49:49 +0100 [thread overview]
Message-ID: <20150914124949.GM21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <55F6BEA4.1070803@linaro.org>
On Mon, Sep 14, 2015 at 06:03:40PM +0530, Vaibhav Hiremath wrote:
> On Monday 14 September 2015 04:20 PM, Russell King - ARM Linux wrote:
> >On Mon, Sep 14, 2015 at 03:45:43PM +0530, Vaibhav Hiremath wrote:
> >>Came across below lines in the datasheet,
> >>
> >>========= Copy-n-paste from datasheet============
> >>
> >>All SDH interfaces share the same clock which is enabled when any of the SDH
> >>clock enables are
> >>set (from PMUA_SDH1_CLK_RES_CTRL, PMUA_SDH2_CLK_RES_CTRL,
> >>PMUA_SDH3_CLK_RES_CTRL, PMUA_SDH4_CLK_RES_CTRL,
> >>PMUA_SDH5_CLK_RES_CTRL), with clock source select and divider ratio
> >>controlled by
> >>PMUA_SDH1_CLK_RES_CTRL.
> >>
> >>==================================================
> >>
> >>
> >>And I can confirm that after disabling AXI interface clock for all the
> >>SDH modules (1-5) I see I get an abort.
> >>
> >>This clearly explains/justifies/proves that the existing code is
> >>working as expected. I have eMMC mounted on the board, which makes
> >>clock to always stay ON on SDH3.
> >>
> >>So there is an OR gate implemented inside which takes input from
> >>SDHx_AXI_EN and feeds back to all SDHx instances. Don't ask me why it
> >>has been designed that way :)
> >>
> >>And I did some experiment as well, so what I have observed is,
> >>SDH_AXI_CLOCK is required to generate card detection, without that I do
> >>not see card detection working.
> >
> >What that means is that if DT configures the interface to use its
> >internal card detection, the AXI clock must never shut off when entering
> >runtime-PM.
> >
>
> Yes, exactly.
> Its clock driver which is doing this.
>
> static struct mmp_param_gate_clk apmu_gate_clks[] = {
> /* The gate clocks has mux parent. */
> {PXA1928_CLK_SDH0, "sdh0_clk", "sdh_div", CLK_SET_RATE_PARENT,
> PXA1928_CLK_SDH0 * 4, 0x1b, 0x1b, 0x0, 0, &sdh0_lock},
> };
>
> Here the mask and enable_val both are set to 0x1b, which means it
> shuts off both peripheral and AXI clock both.
*Sigh*.
So, rather than represent the hardware in DT by telling the SDHCI code
that you have two independent clocks, you've chosen to do the brain
dead thing, and combine the two clocks *which are logically different*
to suit the Linux implementation, thereby leaking implementation details
into DT, and creating a compatibility headache through doing so.
Stop doing this. Just stop it. It's broken, it's wrong, and it's down
right idiotic.
DT should _always_ describe the bloody hardware, not the implementation.
I suggest that you have only one way to solve this on this platform.
1. Declare new clocks from your PXA clock driver which expose the AXI
and peripheral clock separately.
2. Add code (if not already there) to the SDHCI crap-pile to claim and
appropriately manage these two clocks, falling back to the existing
but broken method with existing DT.
3. Change DT to provide the new clocks to SDHCI.
That's about the only way I can see to ensure that an old DT file would
continue to work with a new kernel, given this fsckup.
Please. In future, be careful when describing stuff in DT. Don't take
short cuts to suit the implementation. Always describe the hardware,
don't describe the implementation. *Especially* when it comes to things
like device resources.
It really doesn't matter if the driver doesn't cope with them - the
important thing is that the DT always correctly describes the hardware.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: Jisheng Zhang <jszhang@marvell.com>,
ulf.hansson@linaro.org,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
nico@fluxnic.net
Subject: Re: sdhci: runtime suspend/resume on card insert/removal
Date: Mon, 14 Sep 2015 13:49:49 +0100 [thread overview]
Message-ID: <20150914124949.GM21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <55F6BEA4.1070803@linaro.org>
On Mon, Sep 14, 2015 at 06:03:40PM +0530, Vaibhav Hiremath wrote:
> On Monday 14 September 2015 04:20 PM, Russell King - ARM Linux wrote:
> >On Mon, Sep 14, 2015 at 03:45:43PM +0530, Vaibhav Hiremath wrote:
> >>Came across below lines in the datasheet,
> >>
> >>========= Copy-n-paste from datasheet============
> >>
> >>All SDH interfaces share the same clock which is enabled when any of the SDH
> >>clock enables are
> >>set (from PMUA_SDH1_CLK_RES_CTRL, PMUA_SDH2_CLK_RES_CTRL,
> >>PMUA_SDH3_CLK_RES_CTRL, PMUA_SDH4_CLK_RES_CTRL,
> >>PMUA_SDH5_CLK_RES_CTRL), with clock source select and divider ratio
> >>controlled by
> >>PMUA_SDH1_CLK_RES_CTRL.
> >>
> >>==================================================
> >>
> >>
> >>And I can confirm that after disabling AXI interface clock for all the
> >>SDH modules (1-5) I see I get an abort.
> >>
> >>This clearly explains/justifies/proves that the existing code is
> >>working as expected. I have eMMC mounted on the board, which makes
> >>clock to always stay ON on SDH3.
> >>
> >>So there is an OR gate implemented inside which takes input from
> >>SDHx_AXI_EN and feeds back to all SDHx instances. Don't ask me why it
> >>has been designed that way :)
> >>
> >>And I did some experiment as well, so what I have observed is,
> >>SDH_AXI_CLOCK is required to generate card detection, without that I do
> >>not see card detection working.
> >
> >What that means is that if DT configures the interface to use its
> >internal card detection, the AXI clock must never shut off when entering
> >runtime-PM.
> >
>
> Yes, exactly.
> Its clock driver which is doing this.
>
> static struct mmp_param_gate_clk apmu_gate_clks[] = {
> /* The gate clocks has mux parent. */
> {PXA1928_CLK_SDH0, "sdh0_clk", "sdh_div", CLK_SET_RATE_PARENT,
> PXA1928_CLK_SDH0 * 4, 0x1b, 0x1b, 0x0, 0, &sdh0_lock},
> };
>
> Here the mask and enable_val both are set to 0x1b, which means it
> shuts off both peripheral and AXI clock both.
*Sigh*.
So, rather than represent the hardware in DT by telling the SDHCI code
that you have two independent clocks, you've chosen to do the brain
dead thing, and combine the two clocks *which are logically different*
to suit the Linux implementation, thereby leaking implementation details
into DT, and creating a compatibility headache through doing so.
Stop doing this. Just stop it. It's broken, it's wrong, and it's down
right idiotic.
DT should _always_ describe the bloody hardware, not the implementation.
I suggest that you have only one way to solve this on this platform.
1. Declare new clocks from your PXA clock driver which expose the AXI
and peripheral clock separately.
2. Add code (if not already there) to the SDHCI crap-pile to claim and
appropriately manage these two clocks, falling back to the existing
but broken method with existing DT.
3. Change DT to provide the new clocks to SDHCI.
That's about the only way I can see to ensure that an old DT file would
continue to work with a new kernel, given this fsckup.
Please. In future, be careful when describing stuff in DT. Don't take
short cuts to suit the implementation. Always describe the hardware,
don't describe the implementation. *Especially* when it comes to things
like device resources.
It really doesn't matter if the driver doesn't cope with them - the
important thing is that the DT always correctly describes the hardware.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-09-14 12:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 7:10 sdhci: runtime suspend/resume on card insert/removal Vaibhav Hiremath
2015-09-10 7:10 ` Vaibhav Hiremath
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:31 ` Jisheng Zhang
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:51 ` Vaibhav Hiremath
2015-09-10 7:57 ` Jisheng Zhang
2015-09-10 7:57 ` Jisheng Zhang
2015-09-10 8:02 ` Russell King - ARM Linux
2015-09-10 8:02 ` Russell King - ARM Linux
2015-09-10 8:04 ` Jisheng Zhang
2015-09-10 8:04 ` Jisheng Zhang
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:25 ` Vaibhav Hiremath
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 6:28 ` Jisheng Zhang
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:13 ` Vaibhav Hiremath
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 8:18 ` Jisheng Zhang
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 9:19 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:15 ` Vaibhav Hiremath
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 10:50 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 11:00 ` Russell King - ARM Linux
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:33 ` Vaibhav Hiremath
2015-09-14 12:49 ` Russell King - ARM Linux [this message]
2015-09-14 12:49 ` Russell King - ARM Linux
2015-09-14 13:05 ` Vaibhav Hiremath
2015-09-14 13:05 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914124949.GM21084@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.