From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Ido Rosen <ido@kernel.org>
Cc: users@linux.kernel.org, workflows@vger.kernel.org
Subject: Re: RFC: Github PR bot questions
Date: Wed, 16 Jun 2021 14:05:43 -0400 [thread overview]
Message-ID: <20210616180543.wevddhlzq4ow22f5@nitro.local> (raw)
In-Reply-To: <CAJhbpm_BgbSx581HU0mTCkcE28n_hRx=tv74az_mE2VBmPtrVA@mail.gmail.com>
On Wed, Jun 16, 2021 at 10:48:59AM -0700, Ido Rosen wrote:
> I’d suggest limiting the feature set to automatically responding to GitHub
> PRs with a link to a tutorial on how to contribute patches etc. Doing too
> much for them may create more harm than good in the long run because it
> removes the incentive to learn the contribution process.
I do understand that sentiment, to a degree; in fact, I often compare our
process to submitting a paper to a peer-reviewed journal. You can't just email
your napkin thoughts -- it must be formatted in a very specific way, list its
references in a very specific way etc, etc.
However, that is not a perfect analogy. Our code review process must also
allow for what is effectively a "report a typo" link. Currently, this is
extremely onerous for anyone, as a 15-minute affair suddenly becomes a
herculean effort. The goal of this work is to make drive-by patches easier
without also burying maintainers under a pile of junk submissions.
> An exception to this would be documentation patches and typo fixes: the
> GitHub web editor makes it very easy to edit documentation and other
> changes that don’t require compilation to test (e.g. spelling errors in
> comments, man pages, txt files, etc.).
Or it could be a tiny change in the driver string output, so I'm not sure it
makes sense to limit this to just docs (especially with many docs being
sourced straight from .c files).
-K
next prev parent reply other threads:[~2021-06-16 18:05 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 17:18 RFC: Github PR bot questions Konstantin Ryabitsev
2021-06-16 17:24 ` Drew DeVault
2021-06-16 17:47 ` Johannes Berg
2021-06-16 17:55 ` Konstantin Ryabitsev
2021-06-16 18:13 ` Miguel Ojeda
2021-06-17 17:07 ` Serge E. Hallyn
[not found] ` <CAJhbpm_BgbSx581HU0mTCkcE28n_hRx=tv74az_mE2VBmPtrVA@mail.gmail.com>
2021-06-16 18:05 ` Konstantin Ryabitsev [this message]
2021-06-16 18:11 ` Miguel Ojeda
2021-06-16 18:22 ` Konstantin Ryabitsev
2021-06-16 18:38 ` Miguel Ojeda
2021-06-16 20:10 ` Willy Tarreau
2021-06-17 15:11 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Willy Tarreau
2021-06-16 20:24 ` Linus Torvalds
2021-06-17 15:09 ` Konstantin Ryabitsev
2021-06-16 21:11 ` Rob Herring
2021-06-16 21:18 ` Stefano Stabellini
2021-06-16 21:59 ` Rob Herring
2021-06-16 22:33 ` James Bottomley
2021-06-17 14:18 ` Rob Herring
2021-06-17 14:27 ` James Bottomley
2021-06-17 6:52 ` Mauro Carvalho Chehab
2021-06-17 8:20 ` Dmitry Vyukov
2021-06-17 8:55 ` Mauro Carvalho Chehab
2021-06-17 9:33 ` Dmitry Vyukov
2021-06-17 9:52 ` Geert Uytterhoeven
2021-06-17 14:33 ` Rob Herring
2021-06-17 15:24 ` Mauro Carvalho Chehab
2021-06-17 15:38 ` Rob Herring
2021-06-17 15:45 ` Christoph Hellwig
2021-06-17 14:02 ` Rob Herring
2021-06-17 14:47 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Steven Rostedt
2021-06-17 15:48 ` Christoph Hellwig
2021-06-17 15:53 ` Laurent Pinchart
2021-06-17 17:15 ` Rob Herring
2021-06-17 6:37 ` Dmitry Vyukov
2021-06-17 7:30 ` Greg KH
2021-06-17 14:59 ` Konstantin Ryabitsev
2021-06-17 8:24 ` Christoph Hellwig
2021-06-17 8:33 ` Jiri Kosina
2021-06-17 9:52 ` Dmitry Vyukov
2021-06-17 10:09 ` Christoph Hellwig
2021-06-17 14:57 ` Konstantin Ryabitsev
2021-06-17 15:16 ` Mark Brown
2021-06-17 15:24 ` Laurent Pinchart
2021-06-17 16:36 ` Geert Uytterhoeven
2021-06-17 18:43 ` Miguel Ojeda
2021-06-17 15:31 ` Paolo Bonzini
2021-06-17 17:06 ` Stefano Stabellini
2021-06-17 22:35 ` Jiri Kosina
2021-06-17 14:23 ` Miguel Ojeda
2021-06-17 20:42 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616180543.wevddhlzq4ow22f5@nitro.local \
--to=konstantin@linuxfoundation.org \
--cc=ido@kernel.org \
--cc=users@linux.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.