From: Rob Herring <robh@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
users@linux.kernel.org, workflows@vger.kernel.org
Subject: Re: RFC: Github PR bot questions
Date: Wed, 16 Jun 2021 15:59:52 -0600 [thread overview]
Message-ID: <CAL_JsqKAhtjGCVu2_YqVdpuvHJpC+TGhwWi2nYZmx3w1xT-59A@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2106161416020.24906@sstabellini-ThinkPad-T480s>
On Wed, Jun 16, 2021 at 3:18 PM Stefano Stabellini
<sstabellini@kernel.org> wrote:
>
> On Wed, 16 Jun 2021, Rob Herring wrote:
> > > - subsystem maintainers can configure whatever CI pre-checks they want before
> > > the series is sent to them for review (and we can work on a library of
> > > Github actions, so nobody needs to reimplement checkpatch.pl multiple times)
> >
> > What about all the patches that don't come from the GH PR? Those need
> > CI pre-checks too. We're going to implement CI twice? The biggest
> > issue I have on CI checks is applying patches. My algorithm is apply
> > to my current base (last rc1 typically) or give up. I'm sure it could
> > be a lot smarter trying several branches or looking at base-commit
> > (not consistently used) or the git diff treeish hashes. What I'd
> > really like is some bot or script that's applying series and
> > publishing git branches with a messageid to git branch tool. 0-day is
> > doing this now. Basically, the opposite direction as others have
> > mentioned.
>
> It exists: it is called patchew and we are using it in QEMU and in Xen
> Project (https://gitlab.com/xen-project/patchew).
>
> It takes patch series off of a mailing list and commits them to a branch
> to trigger a CI-loop run. It is also able to send back a "passed" or
> "failed" email to the mailing list. It is great!
Yes, I've seen that. To me, that's really just a patchwork
alternative, and standing up a web server is not what I want. Now
maybe if someone else does and I can fetch what I need then it would
work. Otherwise, it's just another project with patch applying code
that can't be used on its own. But I doubt the patch applying would do
what's needed for Linux. According to documentation, it says it can
'Apply the patch series on top of git master'. My CI already does
that. I need apply to this git tree containing all these subsystem
trees (i.e. linux-next) and find the right base yourself. Note that
applying to linux-next itself is wrong as that's not a tree any
maintainer can apply patches to.
At the end of the day, I just want to do:
git fetch agitserver $(msgid2branch $msgid)
or
b4 am -o $msgid | a-smart-git-am-that-finds-the-right-commit-base
Rob
next prev parent reply other threads:[~2021-06-16 22:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 17:18 RFC: Github PR bot questions Konstantin Ryabitsev
2021-06-16 17:24 ` Drew DeVault
2021-06-16 17:47 ` Johannes Berg
2021-06-16 17:55 ` Konstantin Ryabitsev
2021-06-16 18:13 ` Miguel Ojeda
2021-06-17 17:07 ` Serge E. Hallyn
[not found] ` <CAJhbpm_BgbSx581HU0mTCkcE28n_hRx=tv74az_mE2VBmPtrVA@mail.gmail.com>
2021-06-16 18:05 ` Konstantin Ryabitsev
2021-06-16 18:11 ` Miguel Ojeda
2021-06-16 18:22 ` Konstantin Ryabitsev
2021-06-16 18:38 ` Miguel Ojeda
2021-06-16 20:10 ` Willy Tarreau
2021-06-17 15:11 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Willy Tarreau
2021-06-16 20:24 ` Linus Torvalds
2021-06-17 15:09 ` Konstantin Ryabitsev
2021-06-16 21:11 ` Rob Herring
2021-06-16 21:18 ` Stefano Stabellini
2021-06-16 21:59 ` Rob Herring [this message]
2021-06-16 22:33 ` James Bottomley
2021-06-17 14:18 ` Rob Herring
2021-06-17 14:27 ` James Bottomley
2021-06-17 6:52 ` Mauro Carvalho Chehab
2021-06-17 8:20 ` Dmitry Vyukov
2021-06-17 8:55 ` Mauro Carvalho Chehab
2021-06-17 9:33 ` Dmitry Vyukov
2021-06-17 9:52 ` Geert Uytterhoeven
2021-06-17 14:33 ` Rob Herring
2021-06-17 15:24 ` Mauro Carvalho Chehab
2021-06-17 15:38 ` Rob Herring
2021-06-17 15:45 ` Christoph Hellwig
2021-06-17 14:02 ` Rob Herring
2021-06-17 14:47 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Steven Rostedt
2021-06-17 15:48 ` Christoph Hellwig
2021-06-17 15:53 ` Laurent Pinchart
2021-06-17 17:15 ` Rob Herring
2021-06-17 6:37 ` Dmitry Vyukov
2021-06-17 7:30 ` Greg KH
2021-06-17 14:59 ` Konstantin Ryabitsev
2021-06-17 8:24 ` Christoph Hellwig
2021-06-17 8:33 ` Jiri Kosina
2021-06-17 9:52 ` Dmitry Vyukov
2021-06-17 10:09 ` Christoph Hellwig
2021-06-17 14:57 ` Konstantin Ryabitsev
2021-06-17 15:16 ` Mark Brown
2021-06-17 15:24 ` Laurent Pinchart
2021-06-17 16:36 ` Geert Uytterhoeven
2021-06-17 18:43 ` Miguel Ojeda
2021-06-17 15:31 ` Paolo Bonzini
2021-06-17 17:06 ` Stefano Stabellini
2021-06-17 22:35 ` Jiri Kosina
2021-06-17 14:23 ` Miguel Ojeda
2021-06-17 20:42 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKAhtjGCVu2_YqVdpuvHJpC+TGhwWi2nYZmx3w1xT-59A@mail.gmail.com \
--to=robh@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=sstabellini@kernel.org \
--cc=users@linux.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.