From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Brown <broonie@kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Dmitry Vyukov <dvyukov@google.com>,
Jiri Kosina <jikos@kernel.org>,
users@linux.kernel.org, workflows@vger.kernel.org
Subject: Re: RFC: Github PR bot questions
Date: Thu, 17 Jun 2021 18:36:24 +0200 [thread overview]
Message-ID: <CAMuHMdVM+gfs1cS3i67=Gkm7sF889NwSpAQbXtfqzqGFZ5bjtQ@mail.gmail.com> (raw)
In-Reply-To: <YMtpHPaJzMxmhslt@pendragon.ideasonboard.com>
Hi Laurent,
On Thu, Jun 17, 2021 at 5:24 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thu, Jun 17, 2021 at 04:16:59PM +0100, Mark Brown wrote:
> > On Thu, Jun 17, 2021 at 10:57:28AM -0400, Konstantin Ryabitsev wrote:
> > > On Thu, Jun 17, 2021 at 11:09:34AM +0100, Christoph Hellwig wrote:
> > > > Because I don't waste my time on the kind of crap that comes from
> > > > github. If you build a separate webinterface that allows anyone to send
> > > > a proper series from a git tree that is all fine. But github is toxic.
> >
> > > Won't this just end up reimplementing a lot of stuff that we already get "for
> > > free" from Github and other forges? Yes, I know Github is proprietary, but so
> > > are many SMTP gateways used to send the patch series. I don't see how what
> > > the GH bot would do is different from:
> >
> > I think part of the concern here is that people have some standard
> > expectations for how projects they work with on Github are going to
> > function so if people end up using Github to submit patches we may end
> > up with some culture and process mismatches which could cause issues.
>
> There are some features (or lack thereof) of git..b that I suspect
> actively decrease the quality of the hosted software. For instance, the
> inability to comment on the commit messages during review can play a
> role in the average low quality of those messages. Similarly, review is
> often based on changes, not on individual commits, which results in
> commits being badly split (or not split at all, it's common to see very
> large commits with a "fix stuff" commit message).
I thought so, too, until I received a first comment on an individual commit
in a github PR yesterday[1].
> Developers who have only been exposed to those platforms are very likely
> to never have learnt the importance of commit messages, and of proper
> split of changes across commits. Those are issues that are inherent to
> those platforms and that we will likely need to handle in an automated
> way (at least to some extent) or maintainers will become crazy (I know
> we already suffer from those issues with the mailing list-based
> workflow, but I believe it would get worse, not better, and some of our
> maintainers are already suffering way more than they should).
That's definitely not a problem that originated on git..b. Been like that
in the corporate world before. Guess what happened after switching
from a more-forgiving VCS to git, and seeing
Aborting commit due to empty commit message.
? ... Dummy commit messages, of course.
[1] https://github.com/esmil/linux/commit/f5b077c3e80d85b1c2749999c9f74491f69a6ceb#comments
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-06-17 16:36 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 17:18 RFC: Github PR bot questions Konstantin Ryabitsev
2021-06-16 17:24 ` Drew DeVault
2021-06-16 17:47 ` Johannes Berg
2021-06-16 17:55 ` Konstantin Ryabitsev
2021-06-16 18:13 ` Miguel Ojeda
2021-06-17 17:07 ` Serge E. Hallyn
[not found] ` <CAJhbpm_BgbSx581HU0mTCkcE28n_hRx=tv74az_mE2VBmPtrVA@mail.gmail.com>
2021-06-16 18:05 ` Konstantin Ryabitsev
2021-06-16 18:11 ` Miguel Ojeda
2021-06-16 18:22 ` Konstantin Ryabitsev
2021-06-16 18:38 ` Miguel Ojeda
2021-06-16 20:10 ` Willy Tarreau
2021-06-17 15:11 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Willy Tarreau
2021-06-16 20:24 ` Linus Torvalds
2021-06-17 15:09 ` Konstantin Ryabitsev
2021-06-16 21:11 ` Rob Herring
2021-06-16 21:18 ` Stefano Stabellini
2021-06-16 21:59 ` Rob Herring
2021-06-16 22:33 ` James Bottomley
2021-06-17 14:18 ` Rob Herring
2021-06-17 14:27 ` James Bottomley
2021-06-17 6:52 ` Mauro Carvalho Chehab
2021-06-17 8:20 ` Dmitry Vyukov
2021-06-17 8:55 ` Mauro Carvalho Chehab
2021-06-17 9:33 ` Dmitry Vyukov
2021-06-17 9:52 ` Geert Uytterhoeven
2021-06-17 14:33 ` Rob Herring
2021-06-17 15:24 ` Mauro Carvalho Chehab
2021-06-17 15:38 ` Rob Herring
2021-06-17 15:45 ` Christoph Hellwig
2021-06-17 14:02 ` Rob Herring
2021-06-17 14:47 ` Konstantin Ryabitsev
2021-06-17 15:25 ` Steven Rostedt
2021-06-17 15:48 ` Christoph Hellwig
2021-06-17 15:53 ` Laurent Pinchart
2021-06-17 17:15 ` Rob Herring
2021-06-17 6:37 ` Dmitry Vyukov
2021-06-17 7:30 ` Greg KH
2021-06-17 14:59 ` Konstantin Ryabitsev
2021-06-17 8:24 ` Christoph Hellwig
2021-06-17 8:33 ` Jiri Kosina
2021-06-17 9:52 ` Dmitry Vyukov
2021-06-17 10:09 ` Christoph Hellwig
2021-06-17 14:57 ` Konstantin Ryabitsev
2021-06-17 15:16 ` Mark Brown
2021-06-17 15:24 ` Laurent Pinchart
2021-06-17 16:36 ` Geert Uytterhoeven [this message]
2021-06-17 18:43 ` Miguel Ojeda
2021-06-17 15:31 ` Paolo Bonzini
2021-06-17 17:06 ` Stefano Stabellini
2021-06-17 22:35 ` Jiri Kosina
2021-06-17 14:23 ` Miguel Ojeda
2021-06-17 20:42 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVM+gfs1cS3i67=Gkm7sF889NwSpAQbXtfqzqGFZ5bjtQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=dvyukov@google.com \
--cc=hch@infradead.org \
--cc=jikos@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=users@linux.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.