From: Rob Herring <robh@kernel.org> To: Frank Li <Frank.li@nxp.com> Cc: "Richard Zhu" <hongxing.zhu@nxp.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "NXP Linux Team" <linux-imx@nxp.com>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Liam Girdwood" <lgirdwood@gmail.com>, "Mark Brown" <broonie@kernel.org>, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 10/11] dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string Date: Tue, 7 May 2024 09:55:57 -0500 [thread overview] Message-ID: <20240507145557.GA461201-robh@kernel.org> (raw) In-Reply-To: <ZjAPy05fGLqX6W1I@lizhi-Precision-Tower-5810> On Mon, Apr 29, 2024 at 05:23:23PM -0400, Frank Li wrote: > On Mon, Apr 29, 2024 at 10:48:23AM -0500, Rob Herring wrote: > > On Tue, Apr 02, 2024 at 10:33:46AM -0400, Frank Li wrote: > > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > > > Add i.MX8Q PCIe "fsl,imx8q-pcie" compatible strings. > > > > > > Add "fsl,local-address" property for i.MX8Q platforms. fsl,local-address > > > is address of PCIe module in high speed io (HSIO)subsystem bus fabric. HSIO > > > bus fabric convert the incoming address base to this local-address. Two > > > instances of PCI have difference local address. > > > > This is just some intermediate bus address? We really should be able to > > describe this with standard ranges properties. > > Yes, Maybe dwc's implement have some problem. After read below doc again > https://elinux.org/Device_Tree_Usage#PCI_Address_Translation > > ┌──────┐ ┌──────────┐ > ┌────┐0x18001000 │ │ │ │ > │CPU ├───────────►│ ├──┤ Others │ > └────┘ │ │ │ │ > │ │ └──────────┘ > │ │ > │ │ ┌─────────┐ > │ │ │ │ ┌───────────┐ > │ ├──►│ HSIO │ 0xB8001000 ├───────────┤ > │ │ │ Fabric ├───────────►│Bar0 │ TLP mem 0xB8001000 > │ │ │ │ │0xB8000000 ├───────► > └──────┘ └─────────┘ │ │ Note the 0xB8xxxxxxx address on the right is a PCI address which could be anything though folks often make it 1:1. > Main Fabric ├───────────┤ > │ │ > │ │ > │ │ > │ │ > │ │ > │ │ > │ DWC │ > │ PCIe │ > │ Controller│ > │ │ > │ │ > └───────────┘ > > > dts should be > > ranges = <0x82000000 0 0xB8000000 0x18000000 0 0x07f00000> > ^^^^ And HSIO needs a node with ranges = <0xb8000000 0x18000000 size>; Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Frank Li <Frank.li@nxp.com> Cc: "Richard Zhu" <hongxing.zhu@nxp.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "NXP Linux Team" <linux-imx@nxp.com>, "Philipp Zabel" <p.zabel@pengutronix.de>, "Liam Girdwood" <lgirdwood@gmail.com>, "Mark Brown" <broonie@kernel.org>, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 10/11] dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string Date: Tue, 7 May 2024 09:55:57 -0500 [thread overview] Message-ID: <20240507145557.GA461201-robh@kernel.org> (raw) In-Reply-To: <ZjAPy05fGLqX6W1I@lizhi-Precision-Tower-5810> On Mon, Apr 29, 2024 at 05:23:23PM -0400, Frank Li wrote: > On Mon, Apr 29, 2024 at 10:48:23AM -0500, Rob Herring wrote: > > On Tue, Apr 02, 2024 at 10:33:46AM -0400, Frank Li wrote: > > > From: Richard Zhu <hongxing.zhu@nxp.com> > > > > > > Add i.MX8Q PCIe "fsl,imx8q-pcie" compatible strings. > > > > > > Add "fsl,local-address" property for i.MX8Q platforms. fsl,local-address > > > is address of PCIe module in high speed io (HSIO)subsystem bus fabric. HSIO > > > bus fabric convert the incoming address base to this local-address. Two > > > instances of PCI have difference local address. > > > > This is just some intermediate bus address? We really should be able to > > describe this with standard ranges properties. > > Yes, Maybe dwc's implement have some problem. After read below doc again > https://elinux.org/Device_Tree_Usage#PCI_Address_Translation > > ┌──────┐ ┌──────────┐ > ┌────┐0x18001000 │ │ │ │ > │CPU ├───────────►│ ├──┤ Others │ > └────┘ │ │ │ │ > │ │ └──────────┘ > │ │ > │ │ ┌─────────┐ > │ │ │ │ ┌───────────┐ > │ ├──►│ HSIO │ 0xB8001000 ├───────────┤ > │ │ │ Fabric ├───────────►│Bar0 │ TLP mem 0xB8001000 > │ │ │ │ │0xB8000000 ├───────► > └──────┘ └─────────┘ │ │ Note the 0xB8xxxxxxx address on the right is a PCI address which could be anything though folks often make it 1:1. > Main Fabric ├───────────┤ > │ │ > │ │ > │ │ > │ │ > │ │ > │ │ > │ DWC │ > │ PCIe │ > │ Controller│ > │ │ > │ │ > └───────────┘ > > > dts should be > > ranges = <0x82000000 0 0xB8000000 0x18000000 0 0x07f00000> > ^^^^ And HSIO needs a node with ranges = <0xb8000000 0x18000000 size>; Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-07 14:55 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-02 14:33 [PATCH v3 00/11] PCI: imx6: Fix\rename\clean up and add lut information for imx95 Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-02 14:33 ` [PATCH v3 01/11] PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:00 ` Manivannan Sadhasivam 2024-04-27 9:00 ` Manivannan Sadhasivam 2024-04-29 14:53 ` Frank Li 2024-04-29 14:53 ` Frank Li 2024-04-02 14:33 ` [PATCH v3 02/11] PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:23 ` Manivannan Sadhasivam 2024-04-27 9:23 ` Manivannan Sadhasivam 2024-04-29 15:58 ` Frank Li 2024-04-29 15:58 ` Frank Li 2024-04-02 14:33 ` [PATCH v3 03/11] PCI: imx6: Rename imx6_* with imx_* Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:29 ` Manivannan Sadhasivam 2024-04-27 9:29 ` Manivannan Sadhasivam 2024-04-02 14:33 ` [PATCH v3 04/11] PCI: imx6: Rename pci-imx6.c to pcie-imx.c Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:31 ` Manivannan Sadhasivam 2024-04-27 9:31 ` Manivannan Sadhasivam 2024-04-29 16:01 ` Frank Li 2024-04-29 16:01 ` Frank Li 2024-04-02 14:33 ` [PATCH v3 05/11] MAINTAINERS: pci: imx: update imx6* to imx* since rename driver file Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:33 ` Manivannan Sadhasivam 2024-04-27 9:33 ` Manivannan Sadhasivam 2024-04-29 15:03 ` Rob Herring 2024-04-29 15:03 ` Rob Herring 2024-04-02 14:33 ` [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 9:54 ` Manivannan Sadhasivam 2024-04-27 9:54 ` Manivannan Sadhasivam 2024-04-02 14:33 ` [PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 10:19 ` Manivannan Sadhasivam 2024-04-27 10:19 ` Manivannan Sadhasivam 2024-04-29 16:38 ` Frank Li 2024-04-29 16:38 ` Frank Li 2024-04-02 14:33 ` [PATCH v3 08/11] PCI: imx: Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95 Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 11:36 ` Manivannan Sadhasivam 2024-04-27 11:36 ` Manivannan Sadhasivam 2024-04-29 15:06 ` Rob Herring 2024-04-29 15:06 ` Rob Herring 2024-04-29 17:00 ` Frank Li 2024-04-29 17:00 ` Frank Li 2024-04-29 15:08 ` Rob Herring 2024-04-29 15:08 ` Rob Herring 2024-04-02 14:33 ` [PATCH v3 09/11] PCI: imx: Consolidate redundant if-checks Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 11:38 ` Manivannan Sadhasivam 2024-04-27 11:38 ` Manivannan Sadhasivam 2024-04-02 14:33 ` [PATCH v3 10/11] dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-29 15:48 ` Rob Herring 2024-04-29 15:48 ` Rob Herring 2024-04-29 21:23 ` Frank Li 2024-04-29 21:23 ` Frank Li 2024-05-07 14:55 ` Rob Herring [this message] 2024-05-07 14:55 ` Rob Herring 2024-04-02 14:33 ` [PATCH v3 11/11] PCI: imx6: Add i.MX8Q PCIe support Frank Li 2024-04-02 14:33 ` Frank Li 2024-04-27 11:47 ` Manivannan Sadhasivam 2024-04-27 11:47 ` Manivannan Sadhasivam 2024-04-29 17:56 ` Frank Li 2024-04-29 17:56 ` Frank Li 2024-04-16 14:07 ` [PATCH v3 00/11] PCI: imx6: Fix\rename\clean up and add lut information for imx95 Frank Li 2024-04-16 14:07 ` Frank Li 2024-04-25 11:12 ` Manivannan Sadhasivam 2024-04-25 11:12 ` Manivannan Sadhasivam 2024-04-23 14:23 ` Frank Li 2024-04-23 14:23 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240507145557.GA461201-robh@kernel.org \ --to=robh@kernel.org \ --cc=Frank.li@nxp.com \ --cc=bhelgaas@google.com \ --cc=bpf@vger.kernel.org \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=hongxing.zhu@nxp.com \ --cc=imx@lists.linux.dev \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kw@linux.com \ --cc=l.stach@pengutronix.de \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=manivannan.sadhasivam@linaro.org \ --cc=p.zabel@pengutronix.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.