From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] arm/mach-bcm283x/mbox: Flush and invalidate dcache when using fw mailbox
Date: Fri, 10 Jul 2015 23:24:01 -0600 [thread overview]
Message-ID: <55A0A871.9060706@wwwdotorg.org> (raw)
In-Reply-To: <1436003324-8769-5-git-send-email-alexanders83@web.de>
On 07/04/2015 03:48 AM, Alexander Stein wrote:
> When using dcache the setup data for the mailbox must be actually written
> into memory before calling into firmware. Thus flush and invalidate the
> memory.
> diff --git a/arch/arm/mach-bcm283x/mbox.c b/arch/arm/mach-bcm283x/mbox.c
> + flush_dcache_range((unsigned long)buffer,
> + (unsigned long)((void *)buffer +
> + buffer->buf_size));
> + invalidate_dcache_range((unsigned long)buffer,
> + (unsigned long)((void *)buffer +
> + buffer->buf_size));
> ret = bcm2835_mbox_call_raw(chan, phys_to_bus((u32)buffer), &rbuffer);
> if (ret)
> return ret;
I'm not sure of the details of ARMv6 memory pre-fetching, so perhaps
this doesn't matter. However, I think it'd be best if this code did:
flush cache
execute mailbox operation
invalidate cache
use results
... rather than doing the invalidate before executing the mailbox
operation. This change would guarantee that the invalidate happens after
the VideoCore has written the response into RAM, and hence guarantees
that the invalidate will cause the response to be picked up.
next prev parent reply other threads:[~2015-07-11 5:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 9:48 [U-Boot] [PATCH 0/5] dcache support for Raspberry Pi 1 Alexander Stein
2015-07-04 9:48 ` [U-Boot] [PATCH 1/5] arm1176/cpu: Match cache_flush to arm1136 Alexander Stein
2015-07-11 5:20 ` Stephen Warren
2015-07-12 7:23 ` Alexander Stein
2015-07-04 9:48 ` [U-Boot] [PATCH 2/5] arm1176/cpu: Add icache and dcache support Alexander Stein
2015-07-11 5:21 ` Stephen Warren
2015-07-12 7:26 ` Alexander Stein
2015-07-14 4:57 ` Stephen Warren
2015-07-04 9:48 ` [U-Boot] [PATCH 3/5] arm1176/cpu: Align cache flushing addresses to cacheline size Alexander Stein
2015-07-11 5:21 ` Stephen Warren
2015-07-04 9:48 ` [U-Boot] [PATCH 4/5] arm/mach-bcm283x/mbox: Flush and invalidate dcache when using fw mailbox Alexander Stein
2015-07-11 5:24 ` Stephen Warren [this message]
2015-07-04 9:48 ` [U-Boot] [PATCH 5/5] arm/rpi: Enable dcache Alexander Stein
2015-07-11 5:24 ` Stephen Warren
2015-07-12 7:30 ` Alexander Stein
2015-07-14 4:57 ` Stephen Warren
2015-07-06 7:39 ` [U-Boot] [PATCH 0/5] dcache support for Raspberry Pi 1 Albert ARIBAUD
2015-07-06 18:24 ` Alexander Stein
2015-07-06 21:26 ` Albert ARIBAUD
2015-07-08 18:15 ` Alexander Stein
2015-07-08 22:47 ` Albert ARIBAUD
2015-07-11 5:17 ` Stephen Warren
2015-07-12 8:10 ` Alexander Stein
2015-07-14 5:02 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A0A871.9060706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.