From: Haggai Eran <haggaie@mellanox.com> To: Parav Pandit <pandit.parav@gmail.com>, <cgroups@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>, <tj@kernel.org>, <lizefan@huawei.com>, <hannes@cmpxchg.org>, <dledford@redhat.com> Cc: <corbet@lwn.net>, <james.l.morris@oracle.com>, <serge@hallyn.com>, <ogerlitz@mellanox.com>, <matanb@mellanox.com>, <raindel@mellanox.com>, <akpm@linux-foundation.org>, <linux-security-module@vger.kernel.org> Subject: Re: [PATCH 0/7] devcg: device cgroup extension for rdma resource Date: Tue, 8 Sep 2015 15:45:50 +0300 [thread overview] Message-ID: <55EED87E.3000408@mellanox.com> (raw) In-Reply-To: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> On 07/09/2015 23:38, Parav Pandit wrote: > Currently user space applications can easily take away all the rdma > device specific resources such as AH, CQ, QP, MR etc. Due to which other > applications in other cgroup or kernel space ULPs may not even get chance > to allocate any rdma resources. > > This patch-set allows limiting rdma resources to set of processes. > It extend device cgroup controller for limiting rdma device limits. I don't think extending the device cgroup is the right place for these limits. It is currently a very generic controller and adding various RDMA resources to it looks out of place. Why not create a new controller for rdma? Another thing I noticed is that all limits in this cgroup are global, while the resources they control are hardware device specific. I think it would be better if the cgroup controlled the limits of each device separately. > With this patch, user verbs module queries rdma device cgroup controller > to query process's limit to consume such resource. It uncharge resource > counter after resource is being freed. This is another reason why per-device limits would be better. Since limits are reflected to user-space when querying a specific device, it will show the same maximum limit on every device opened. If the user opens 3 devices they might expect to be able to open 3 times the number of the resources they actually can. Regards, Haggai
WARNING: multiple messages have this Message-ID (diff)
From: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> To: Parav Pandit <pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: corbet-T1hC0tSOHrs@public.gmane.org, james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 0/7] devcg: device cgroup extension for rdma resource Date: Tue, 8 Sep 2015 15:45:50 +0300 [thread overview] Message-ID: <55EED87E.3000408@mellanox.com> (raw) In-Reply-To: <1441658303-18081-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On 07/09/2015 23:38, Parav Pandit wrote: > Currently user space applications can easily take away all the rdma > device specific resources such as AH, CQ, QP, MR etc. Due to which other > applications in other cgroup or kernel space ULPs may not even get chance > to allocate any rdma resources. > > This patch-set allows limiting rdma resources to set of processes. > It extend device cgroup controller for limiting rdma device limits. I don't think extending the device cgroup is the right place for these limits. It is currently a very generic controller and adding various RDMA resources to it looks out of place. Why not create a new controller for rdma? Another thing I noticed is that all limits in this cgroup are global, while the resources they control are hardware device specific. I think it would be better if the cgroup controlled the limits of each device separately. > With this patch, user verbs module queries rdma device cgroup controller > to query process's limit to consume such resource. It uncharge resource > counter after resource is being freed. This is another reason why per-device limits would be better. Since limits are reflected to user-space when querying a specific device, it will show the same maximum limit on every device opened. If the user opens 3 devices they might expect to be able to open 3 times the number of the resources they actually can. Regards, Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-08 12:46 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-07 20:38 [PATCH 0/7] devcg: device cgroup extension for rdma resource Parav Pandit 2015-09-07 20:38 ` Parav Pandit 2015-09-07 20:38 ` [PATCH 1/7] devcg: Added user option to rdma resource tracking Parav Pandit 2015-09-07 20:38 ` Parav Pandit 2015-09-07 20:38 ` [PATCH 2/7] devcg: Added rdma resource tracking module Parav Pandit 2015-09-07 20:38 ` Parav Pandit 2015-09-07 20:38 ` [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup Parav Pandit 2015-09-08 5:31 ` Haggai Eran 2015-09-08 5:31 ` Haggai Eran 2015-09-08 7:02 ` Parav Pandit 2015-09-08 7:02 ` Parav Pandit 2015-09-07 20:38 ` [PATCH 4/7] devcg: Added rdma resource tracker object per task Parav Pandit 2015-09-08 5:48 ` Haggai Eran 2015-09-08 5:48 ` Haggai Eran 2015-09-08 7:04 ` Parav Pandit 2015-09-08 8:24 ` Haggai Eran 2015-09-08 8:24 ` Haggai Eran 2015-09-08 8:26 ` Parav Pandit 2015-09-07 20:38 ` [PATCH 5/7] devcg: device cgroup's extension for RDMA resource Parav Pandit 2015-09-07 20:38 ` Parav Pandit 2015-09-08 8:22 ` Haggai Eran 2015-09-08 8:22 ` Haggai Eran 2015-09-08 10:18 ` Parav Pandit 2015-09-08 13:50 ` Haggai Eran 2015-09-08 13:50 ` Haggai Eran 2015-09-08 14:13 ` Parav Pandit 2015-09-08 8:36 ` Haggai Eran 2015-09-08 8:36 ` Haggai Eran 2015-09-08 10:50 ` Parav Pandit 2015-09-08 10:50 ` Parav Pandit 2015-09-08 14:10 ` Haggai Eran 2015-09-08 14:10 ` Haggai Eran 2015-09-07 20:38 ` [PATCH 6/7] devcg: Added support to use RDMA device cgroup Parav Pandit 2015-09-08 8:40 ` Haggai Eran 2015-09-08 8:40 ` Haggai Eran 2015-09-08 10:22 ` Parav Pandit 2015-09-08 13:40 ` Haggai Eran 2015-09-08 13:40 ` Haggai Eran 2015-09-07 20:38 ` [PATCH 7/7] devcg: Added Documentation of " Parav Pandit 2015-09-07 20:38 ` Parav Pandit 2015-09-07 20:55 ` [PATCH 0/7] devcg: device cgroup extension for rdma resource Parav Pandit 2015-09-08 12:45 ` Haggai Eran [this message] 2015-09-08 12:45 ` Haggai Eran 2015-09-08 15:23 ` Tejun Heo 2015-09-08 15:23 ` Tejun Heo 2015-09-09 3:57 ` Parav Pandit 2015-09-10 16:49 ` Tejun Heo 2015-09-10 17:46 ` Parav Pandit 2015-09-10 17:46 ` Parav Pandit 2015-09-10 20:22 ` Tejun Heo 2015-09-11 3:39 ` Parav Pandit 2015-09-11 4:04 ` Tejun Heo 2015-09-11 4:04 ` Tejun Heo 2015-09-11 4:24 ` Doug Ledford 2015-09-11 4:24 ` Doug Ledford 2015-09-11 14:52 ` Tejun Heo 2015-09-11 14:52 ` Tejun Heo 2015-09-11 16:26 ` Parav Pandit 2015-09-11 16:34 ` Tejun Heo 2015-09-11 16:34 ` Tejun Heo 2015-09-11 16:39 ` Parav Pandit 2015-09-11 16:39 ` Parav Pandit 2015-09-11 19:25 ` Tejun Heo 2015-09-14 10:18 ` Parav Pandit 2015-09-14 10:18 ` Parav Pandit 2015-09-11 16:47 ` Parav Pandit 2015-09-11 16:47 ` Parav Pandit 2015-09-11 19:05 ` Tejun Heo 2015-09-11 19:05 ` Tejun Heo 2015-09-11 19:22 ` Hefty, Sean 2015-09-11 19:43 ` Jason Gunthorpe 2015-09-11 19:43 ` Jason Gunthorpe 2015-09-11 20:06 ` Hefty, Sean 2015-09-14 11:09 ` Parav Pandit 2015-09-14 14:04 ` Parav Pandit 2015-09-14 15:21 ` Tejun Heo 2015-09-14 15:21 ` Tejun Heo 2015-09-14 17:28 ` Jason Gunthorpe 2015-09-14 17:28 ` Jason Gunthorpe 2015-09-14 18:54 ` Parav Pandit 2015-09-14 18:54 ` Parav Pandit 2015-09-14 20:18 ` Jason Gunthorpe 2015-09-15 3:08 ` Parav Pandit 2015-09-15 3:45 ` Jason Gunthorpe 2015-09-15 3:45 ` Jason Gunthorpe 2015-09-16 4:41 ` Parav Pandit 2015-09-16 4:41 ` Parav Pandit 2015-09-20 10:35 ` Haggai Eran 2015-09-20 10:35 ` Haggai Eran 2015-10-28 8:14 ` Parav Pandit 2015-10-28 8:14 ` Parav Pandit 2015-09-14 10:15 ` Parav Pandit 2015-09-11 4:43 ` Parav Pandit 2015-09-11 15:03 ` Tejun Heo 2015-09-10 17:48 ` Hefty, Sean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55EED87E.3000408@mellanox.com \ --to=haggaie@mellanox.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=corbet@lwn.net \ --cc=dledford@redhat.com \ --cc=hannes@cmpxchg.org \ --cc=james.l.morris@oracle.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=matanb@mellanox.com \ --cc=ogerlitz@mellanox.com \ --cc=pandit.parav@gmail.com \ --cc=raindel@mellanox.com \ --cc=serge@hallyn.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.