From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode callback function
Date: Tue, 22 Jun 2021 22:27:58 +0200 [thread overview]
Message-ID: <CAFBinCC3ZN9GqOAR1AnXao5G1UCgi6QOCRHeve0mHBXtYYdKOA@mail.gmail.com> (raw)
In-Reply-To: <CANAwSgTd1zq_gHbVZesLY=e3DRRGgn_o5omuDo9Lub4FavOtbQ@mail.gmail.com>
Hi Anand,
On Mon, Jun 21, 2021 at 9:20 AM Anand Moon <linux.amoon@gmail.com> wrote:
[...]
> In order to enable USB phy we probably need to do a little bit
> differently than the vendor kernel.
I agree with you here, the vendor kernel is skipping most of the
frameworks which we have available in mainline Linux
> OTG port on Odroid C1+ and Odroid C2 server two purposes
> 1 > It could act as USB host port.
> 2 > It could be used as USB power on the devices, just like Raspberry pi.
> What I meant is we need some driver code to protect the power to SbC.
yep, so we need something that controls mode switching
depending on the mode the VBUS regulator needs to be enabled (HOST) or
disabled (DEVICE/PERIPHERAL).
VBUS control however is not part of the PHY - in mainline Linux either
the dwc2 driver or a USB connector driver are taking care of it.
> So I saw your work on extcon, that's the reason I would like to void
> any changes PHY right now.
I believe that this specific PHY is unrelated to mode switching.
Either it automatically detects the mode and changes it's settings
internally or the PHY settings are the same for both modes.
Since VBUS control is not the responsibility of the PHY this is
certainly possible
My changes are not ready yet but I'll ping you once I have something to test
> I observe some failures like below.
> [ 6.013859] dwc2 c9000000.usb: DWC OTG HCD URB Dequeue
> [ 6.013897] dwc2 c9000000.usb: Called usb_hcd_giveback_urb()
> [ 6.013902] dwc2 c9000000.usb: urb->status = -115
-115 is -EINPROGRESS but I am not sure if/when that's a bad thing or
to be expected
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode callback function
Date: Tue, 22 Jun 2021 22:27:58 +0200 [thread overview]
Message-ID: <CAFBinCC3ZN9GqOAR1AnXao5G1UCgi6QOCRHeve0mHBXtYYdKOA@mail.gmail.com> (raw)
In-Reply-To: <CANAwSgTd1zq_gHbVZesLY=e3DRRGgn_o5omuDo9Lub4FavOtbQ@mail.gmail.com>
Hi Anand,
On Mon, Jun 21, 2021 at 9:20 AM Anand Moon <linux.amoon@gmail.com> wrote:
[...]
> In order to enable USB phy we probably need to do a little bit
> differently than the vendor kernel.
I agree with you here, the vendor kernel is skipping most of the
frameworks which we have available in mainline Linux
> OTG port on Odroid C1+ and Odroid C2 server two purposes
> 1 > It could act as USB host port.
> 2 > It could be used as USB power on the devices, just like Raspberry pi.
> What I meant is we need some driver code to protect the power to SbC.
yep, so we need something that controls mode switching
depending on the mode the VBUS regulator needs to be enabled (HOST) or
disabled (DEVICE/PERIPHERAL).
VBUS control however is not part of the PHY - in mainline Linux either
the dwc2 driver or a USB connector driver are taking care of it.
> So I saw your work on extcon, that's the reason I would like to void
> any changes PHY right now.
I believe that this specific PHY is unrelated to mode switching.
Either it automatically detects the mode and changes it's settings
internally or the PHY settings are the same for both modes.
Since VBUS control is not the responsibility of the PHY this is
certainly possible
My changes are not ready yet but I'll ping you once I have something to test
> I observe some failures like below.
> [ 6.013859] dwc2 c9000000.usb: DWC OTG HCD URB Dequeue
> [ 6.013897] dwc2 c9000000.usb: Called usb_hcd_giveback_urb()
> [ 6.013902] dwc2 c9000000.usb: urb->status = -115
-115 is -EINPROGRESS but I am not sure if/when that's a bad thing or
to be expected
Best regards,
Martin
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode callback function
Date: Tue, 22 Jun 2021 22:27:58 +0200 [thread overview]
Message-ID: <CAFBinCC3ZN9GqOAR1AnXao5G1UCgi6QOCRHeve0mHBXtYYdKOA@mail.gmail.com> (raw)
In-Reply-To: <CANAwSgTd1zq_gHbVZesLY=e3DRRGgn_o5omuDo9Lub4FavOtbQ@mail.gmail.com>
Hi Anand,
On Mon, Jun 21, 2021 at 9:20 AM Anand Moon <linux.amoon@gmail.com> wrote:
[...]
> In order to enable USB phy we probably need to do a little bit
> differently than the vendor kernel.
I agree with you here, the vendor kernel is skipping most of the
frameworks which we have available in mainline Linux
> OTG port on Odroid C1+ and Odroid C2 server two purposes
> 1 > It could act as USB host port.
> 2 > It could be used as USB power on the devices, just like Raspberry pi.
> What I meant is we need some driver code to protect the power to SbC.
yep, so we need something that controls mode switching
depending on the mode the VBUS regulator needs to be enabled (HOST) or
disabled (DEVICE/PERIPHERAL).
VBUS control however is not part of the PHY - in mainline Linux either
the dwc2 driver or a USB connector driver are taking care of it.
> So I saw your work on extcon, that's the reason I would like to void
> any changes PHY right now.
I believe that this specific PHY is unrelated to mode switching.
Either it automatically detects the mode and changes it's settings
internally or the PHY settings are the same for both modes.
Since VBUS control is not the responsibility of the PHY this is
certainly possible
My changes are not ready yet but I'll ping you once I have something to test
> I observe some failures like below.
> [ 6.013859] dwc2 c9000000.usb: DWC OTG HCD URB Dequeue
> [ 6.013897] dwc2 c9000000.usb: Called usb_hcd_giveback_urb()
> [ 6.013902] dwc2 c9000000.usb: urb->status = -115
-115 is -EINPROGRESS but I am not sure if/when that's a bad thing or
to be expected
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode callback function
Date: Tue, 22 Jun 2021 22:27:58 +0200 [thread overview]
Message-ID: <CAFBinCC3ZN9GqOAR1AnXao5G1UCgi6QOCRHeve0mHBXtYYdKOA@mail.gmail.com> (raw)
In-Reply-To: <CANAwSgTd1zq_gHbVZesLY=e3DRRGgn_o5omuDo9Lub4FavOtbQ@mail.gmail.com>
Hi Anand,
On Mon, Jun 21, 2021 at 9:20 AM Anand Moon <linux.amoon@gmail.com> wrote:
[...]
> In order to enable USB phy we probably need to do a little bit
> differently than the vendor kernel.
I agree with you here, the vendor kernel is skipping most of the
frameworks which we have available in mainline Linux
> OTG port on Odroid C1+ and Odroid C2 server two purposes
> 1 > It could act as USB host port.
> 2 > It could be used as USB power on the devices, just like Raspberry pi.
> What I meant is we need some driver code to protect the power to SbC.
yep, so we need something that controls mode switching
depending on the mode the VBUS regulator needs to be enabled (HOST) or
disabled (DEVICE/PERIPHERAL).
VBUS control however is not part of the PHY - in mainline Linux either
the dwc2 driver or a USB connector driver are taking care of it.
> So I saw your work on extcon, that's the reason I would like to void
> any changes PHY right now.
I believe that this specific PHY is unrelated to mode switching.
Either it automatically detects the mode and changes it's settings
internally or the PHY settings are the same for both modes.
Since VBUS control is not the responsibility of the PHY this is
certainly possible
My changes are not ready yet but I'll ping you once I have something to test
> I observe some failures like below.
> [ 6.013859] dwc2 c9000000.usb: DWC OTG HCD URB Dequeue
> [ 6.013897] dwc2 c9000000.usb: Called usb_hcd_giveback_urb()
> [ 6.013902] dwc2 c9000000.usb: urb->status = -115
-115 is -EINPROGRESS but I am not sure if/when that's a bad thing or
to be expected
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-22 20:28 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:41 [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 1/8] phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 2/8] phy: amlogic: meson8b-usb2: Use phy init callback function Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 3/8] phy: amlogic: meson8b-usb2: Use phy exit " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-22 20:27 ` Martin Blumenstingl [this message]
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 5/8] phy: amlogic: meson8b-usb2: Reorder phy poweroff " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 0:34 ` kernel test robot
2021-06-17 19:41 ` [RFCv1 6/8] phy: amlogic: meson8b-usb2: Use phy reset " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 8/8] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:11 ` [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCC3ZN9GqOAR1AnXao5G1UCgi6QOCRHeve0mHBXtYYdKOA@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.