From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode.
Date: Mon, 21 Jun 2021 12:45:00 +0530 [thread overview]
Message-ID: <CANAwSgRi7UcS22QKZRRhwYvB3Dyk0ChowX+KByEsxP35ezjtKw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCC0KScn6cJ36ZB_=TRncOOCXJHWwR3s=o3TobH=yOrGJA@mail.gmail.com>
Hi Martin,
On Fri, 18 Jun 2021 at 04:07, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Thu, Jun 17, 2021 at 9:44 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > @@ -245,8 +250,6 @@ static int phy_meson8b_usb2_power_on(struct phy *phy)
> > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_FSEL_MASK,
> > 0x5 << REG_CTRL_FSEL_SHIFT);
> > /* reset the PHY */
> > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET,
> > - REG_CTRL_POWER_ON_RESET);
> The vendor driver uses the following sequence for the power on reset:
> - set the power on reset bit
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> With your change we now:
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> I don't know if this is sufficient to bring the PHY into a well-defined state.
> Maybe it works, maybe it doesn't reset at all in this case - I don't
> know how to verify this though.
>
Initially, I tried to some bit mask code to resolve this but it failed,
So no harm in keeping the original changes.
There is another parameter REG_CTRL_PORT_RESET to be considered.
>
> Best regards,
> Martin
Thanks
-Anand
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode.
Date: Mon, 21 Jun 2021 12:45:00 +0530 [thread overview]
Message-ID: <CANAwSgRi7UcS22QKZRRhwYvB3Dyk0ChowX+KByEsxP35ezjtKw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCC0KScn6cJ36ZB_=TRncOOCXJHWwR3s=o3TobH=yOrGJA@mail.gmail.com>
Hi Martin,
On Fri, 18 Jun 2021 at 04:07, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Thu, Jun 17, 2021 at 9:44 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > @@ -245,8 +250,6 @@ static int phy_meson8b_usb2_power_on(struct phy *phy)
> > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_FSEL_MASK,
> > 0x5 << REG_CTRL_FSEL_SHIFT);
> > /* reset the PHY */
> > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET,
> > - REG_CTRL_POWER_ON_RESET);
> The vendor driver uses the following sequence for the power on reset:
> - set the power on reset bit
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> With your change we now:
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> I don't know if this is sufficient to bring the PHY into a well-defined state.
> Maybe it works, maybe it doesn't reset at all in this case - I don't
> know how to verify this though.
>
Initially, I tried to some bit mask code to resolve this but it failed,
So no harm in keeping the original changes.
There is another parameter REG_CTRL_PORT_RESET to be considered.
>
> Best regards,
> Martin
Thanks
-Anand
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode.
Date: Mon, 21 Jun 2021 12:45:00 +0530 [thread overview]
Message-ID: <CANAwSgRi7UcS22QKZRRhwYvB3Dyk0ChowX+KByEsxP35ezjtKw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCC0KScn6cJ36ZB_=TRncOOCXJHWwR3s=o3TobH=yOrGJA@mail.gmail.com>
Hi Martin,
On Fri, 18 Jun 2021 at 04:07, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Thu, Jun 17, 2021 at 9:44 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > @@ -245,8 +250,6 @@ static int phy_meson8b_usb2_power_on(struct phy *phy)
> > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_FSEL_MASK,
> > 0x5 << REG_CTRL_FSEL_SHIFT);
> > /* reset the PHY */
> > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET,
> > - REG_CTRL_POWER_ON_RESET);
> The vendor driver uses the following sequence for the power on reset:
> - set the power on reset bit
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> With your change we now:
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> I don't know if this is sufficient to bring the PHY into a well-defined state.
> Maybe it works, maybe it doesn't reset at all in this case - I don't
> know how to verify this though.
>
Initially, I tried to some bit mask code to resolve this but it failed,
So no harm in keeping the original changes.
There is another parameter REG_CTRL_PORT_RESET to be considered.
>
> Best regards,
> Martin
Thanks
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode.
Date: Mon, 21 Jun 2021 12:45:00 +0530 [thread overview]
Message-ID: <CANAwSgRi7UcS22QKZRRhwYvB3Dyk0ChowX+KByEsxP35ezjtKw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCC0KScn6cJ36ZB_=TRncOOCXJHWwR3s=o3TobH=yOrGJA@mail.gmail.com>
Hi Martin,
On Fri, 18 Jun 2021 at 04:07, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Thu, Jun 17, 2021 at 9:44 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > @@ -245,8 +250,6 @@ static int phy_meson8b_usb2_power_on(struct phy *phy)
> > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_FSEL_MASK,
> > 0x5 << REG_CTRL_FSEL_SHIFT);
> > /* reset the PHY */
> > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET,
> > - REG_CTRL_POWER_ON_RESET);
> The vendor driver uses the following sequence for the power on reset:
> - set the power on reset bit
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> With your change we now:
> - wait 500us
> - clear the power on reset bit
> - wait 500us
>
> I don't know if this is sufficient to bring the PHY into a well-defined state.
> Maybe it works, maybe it doesn't reset at all in this case - I don't
> know how to verify this though.
>
Initially, I tried to some bit mask code to resolve this but it failed,
So no harm in keeping the original changes.
There is another parameter REG_CTRL_PORT_RESET to be considered.
>
> Best regards,
> Martin
Thanks
-Anand
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-21 7:15 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:41 [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 1/8] phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-17 22:33 ` Martin Blumenstingl
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-18 15:32 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 2/8] phy: amlogic: meson8b-usb2: Use phy init callback function Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 12:26 ` Martin Blumenstingl
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-18 13:17 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 3/8] phy: amlogic: meson8b-usb2: Use phy exit " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 13:19 ` Anand Moon
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-18 20:01 ` Martin Blumenstingl
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-21 7:20 ` Anand Moon
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-22 20:27 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 5/8] phy: amlogic: meson8b-usb2: Reorder phy poweroff " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-17 22:16 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 0:34 ` kernel test robot
2021-06-17 19:41 ` [RFCv1 6/8] phy: amlogic: meson8b-usb2: Use phy reset " Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-17 22:24 ` Martin Blumenstingl
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 15:33 ` Anand Moon
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-18 20:06 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-22 20:11 ` Martin Blumenstingl
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-24 14:54 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:07 ` Anand Moon
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-06-27 20:25 ` Martin Blumenstingl
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-07-02 19:13 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-17 22:37 ` Martin Blumenstingl
2021-06-21 7:15 ` Anand Moon [this message]
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-21 7:15 ` Anand Moon
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-22 20:00 ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 8/8] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:26 ` Martin Blumenstingl
2021-06-17 22:11 ` [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-17 22:11 ` Martin Blumenstingl
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 13:20 ` Anand Moon
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-18 20:16 ` Martin Blumenstingl
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
2021-06-21 7:21 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANAwSgRi7UcS22QKZRRhwYvB3Dyk0ChowX+KByEsxP35ezjtKw@mail.gmail.com \
--to=linux.amoon@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.