From: Chanwoo Choi <cwchoi00@gmail.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Lee Jones <lee.jones@linaro.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 1/5] extcon: arizona: Update to use the new device properties API
Date: Fri, 19 Jun 2015 11:14:33 +0900 [thread overview]
Message-ID: <CAGTfZH0zPbxOTbavXbwKfuetKXdGLctTs+PE_gb8C_6bfkJhbQ@mail.gmail.com> (raw)
In-Reply-To: <1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Hi Charles,
Looks good to me about this patch. But I add one comment.
On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> The device properties API will load data from both device tree and ACPI,
> update the binding to use this API instead of the OF API.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..1153929 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -24,6 +24,7 @@
> #include <linux/input.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/property.h>
> #include <linux/regulator/consumer.h>
> #include <linux/extcon.h>
>
> @@ -1110,12 +1111,12 @@ static void arizona_micd_set_level(struct arizona *arizona, int index,
> regmap_update_bits(arizona->regmap, reg, mask, level);
> }
>
> -static int arizona_extcon_of_get_pdata(struct arizona *arizona)
> +static int arizona_extcon_device_get_pdata(struct arizona *arizona)
> {
> struct arizona_pdata *pdata = &arizona->pdata;
> unsigned int val = ARIZONA_ACCDET_MODE_HPL;
>
> - of_property_read_u32(arizona->dev->of_node, "wlf,hpdet-channel", &val);
> + device_property_read_u32(arizona->dev, "wlf,hpdet-channel", &val);
> switch (val) {
> case ARIZONA_ACCDET_MODE_HPL:
> case ARIZONA_ACCDET_MODE_HPR:
> @@ -1149,7 +1150,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>
> if (IS_ENABLED(CONFIG_OF)) {
If you remain the upper if statement, I think
"device_property_read_u32" function cannot get the data from ACPI. I
think that you can remove upper if statement of "CONFIG_OF".
> if (!dev_get_platdata(arizona->dev))
> - arizona_extcon_of_get_pdata(arizona);
> + arizona_extcon_device_get_pdata(arizona);
> }
>
> info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD");
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cwchoi00-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Charles Keepax
<ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org
Subject: Re: [PATCH v2 1/5] extcon: arizona: Update to use the new device properties API
Date: Fri, 19 Jun 2015 11:14:33 +0900 [thread overview]
Message-ID: <CAGTfZH0zPbxOTbavXbwKfuetKXdGLctTs+PE_gb8C_6bfkJhbQ@mail.gmail.com> (raw)
In-Reply-To: <1434638631-16451-2-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Hi Charles,
Looks good to me about this patch. But I add one comment.
On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
<ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> The device properties API will load data from both device tree and ACPI,
> update the binding to use this API instead of the OF API.
>
> Signed-off-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
> drivers/extcon/extcon-arizona.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..1153929 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -24,6 +24,7 @@
> #include <linux/input.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/property.h>
> #include <linux/regulator/consumer.h>
> #include <linux/extcon.h>
>
> @@ -1110,12 +1111,12 @@ static void arizona_micd_set_level(struct arizona *arizona, int index,
> regmap_update_bits(arizona->regmap, reg, mask, level);
> }
>
> -static int arizona_extcon_of_get_pdata(struct arizona *arizona)
> +static int arizona_extcon_device_get_pdata(struct arizona *arizona)
> {
> struct arizona_pdata *pdata = &arizona->pdata;
> unsigned int val = ARIZONA_ACCDET_MODE_HPL;
>
> - of_property_read_u32(arizona->dev->of_node, "wlf,hpdet-channel", &val);
> + device_property_read_u32(arizona->dev, "wlf,hpdet-channel", &val);
> switch (val) {
> case ARIZONA_ACCDET_MODE_HPL:
> case ARIZONA_ACCDET_MODE_HPR:
> @@ -1149,7 +1150,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>
> if (IS_ENABLED(CONFIG_OF)) {
If you remain the upper if statement, I think
"device_property_read_u32" function cannot get the data from ACPI. I
think that you can remove upper if statement of "CONFIG_OF".
> if (!dev_get_platdata(arizona->dev))
> - arizona_extcon_of_get_pdata(arizona);
> + arizona_extcon_device_get_pdata(arizona);
> }
>
> info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD");
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-19 2:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 14:43 [PATCH v2 0/5] Add basic microphone detection bindings Charles Keepax
2015-06-18 14:43 ` Charles Keepax
2015-06-18 14:43 ` [PATCH v2 1/5] extcon: arizona: Update to use the new device properties API Charles Keepax
2015-06-18 14:43 ` Charles Keepax
2015-06-19 2:14 ` Chanwoo Choi [this message]
2015-06-19 2:14 ` Chanwoo Choi
2015-06-18 14:43 ` [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings Charles Keepax
2015-06-18 14:43 ` Charles Keepax
2015-06-19 2:25 ` Chanwoo Choi
2015-06-19 2:25 ` Chanwoo Choi
2015-06-19 8:17 ` Charles Keepax
2015-06-19 8:17 ` Charles Keepax
2015-06-19 8:28 ` Chanwoo Choi
2015-06-19 8:28 ` Chanwoo Choi
2015-06-19 9:08 ` Charles Keepax
2015-06-19 9:08 ` Charles Keepax
2015-06-19 10:31 ` Chanwoo Choi
2015-06-19 10:44 ` Charles Keepax
2015-06-19 10:44 ` Charles Keepax
2015-06-19 11:03 ` Chanwoo Choi
2015-06-19 11:03 ` Chanwoo Choi
2015-06-19 11:59 ` Charles Keepax
2015-06-19 11:59 ` Charles Keepax
2015-06-18 14:43 ` [PATCH v2 3/5] extcon: arizona: Convert to gpiod Charles Keepax
2015-06-19 2:36 ` Chanwoo Choi
2015-06-19 8:14 ` Charles Keepax
2015-06-19 8:14 ` Charles Keepax
2015-06-19 8:39 ` Chanwoo Choi
2015-06-19 8:39 ` Chanwoo Choi
2015-06-19 9:13 ` Charles Keepax
2015-06-19 9:50 ` Chanwoo Choi
2015-06-19 9:54 ` Charles Keepax
2015-06-19 9:54 ` Charles Keepax
2015-06-18 14:43 ` [PATCH v2 4/5] mfd: arizona: Update DT doc for new mic detection bindings Charles Keepax
2015-06-18 14:43 ` [PATCH v2 5/5] mfd: arizona: Update several pdata members to unsigned Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGTfZH0zPbxOTbavXbwKfuetKXdGLctTs+PE_gb8C_6bfkJhbQ@mail.gmail.com \
--to=cwchoi00@gmail.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.