From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rong Chen <rong.a.chen@intel.com>
Cc: kernel test robot <lkp@intel.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Mon, 15 Mar 2021 12:12:41 -0700 [thread overview]
Message-ID: <CAHk-=wg0DY=cE-6Tjp_Dt32UC6XtMZBa0Rr2GqkK=Sh9HE=5kQ@mail.gmail.com> (raw)
In-Reply-To: <09373c3d-73e8-933a-24ad-5c4ba4fdc615@intel.com>
On Sun, Mar 14, 2021 at 7:32 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
> It can be reproduced with '-a' option in dash:
Oh, ok. That kind of explains it.
'dash' is trash. Please somebody make a bug report.
> $ a="!"
> $ [ "$a" = ".size" ]
> $ [ "$a" = ".size" -a "$b" = ".LPBX0," ]
> sh: 2: [: =: unexpected operator
This is 100% a dash bug. There is no question what-so-ever about it.
This is not some kind of "POSIX is ambiguous", or "the handling of
'-a' is complicated".
It's simply just that dash is buggy.
> While dash supports most uses of the -a and -o options, they have
> very confusing semantics even in bash and are best avoided.
No, they have perfectly sane semantics in bash, and in POSIX.
See
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
and there is absolutely zero question that bash does this correctly,
and dash does not.
But yes, it seems to be easy to work around, but still - could some
Ubuntu person please open a bug report on dash?
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Mon, 15 Mar 2021 12:12:41 -0700 [thread overview]
Message-ID: <CAHk-=wg0DY=cE-6Tjp_Dt32UC6XtMZBa0Rr2GqkK=Sh9HE=5kQ@mail.gmail.com> (raw)
In-Reply-To: <09373c3d-73e8-933a-24ad-5c4ba4fdc615@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Sun, Mar 14, 2021 at 7:32 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
> It can be reproduced with '-a' option in dash:
Oh, ok. That kind of explains it.
'dash' is trash. Please somebody make a bug report.
> $ a="!"
> $ [ "$a" = ".size" ]
> $ [ "$a" = ".size" -a "$b" = ".LPBX0," ]
> sh: 2: [: =: unexpected operator
This is 100% a dash bug. There is no question what-so-ever about it.
This is not some kind of "POSIX is ambiguous", or "the handling of
'-a' is complicated".
It's simply just that dash is buggy.
> While dash supports most uses of the -a and -o options, they have
> very confusing semantics even in bash and are best avoided.
No, they have perfectly sane semantics in bash, and in POSIX.
See
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
and there is absolutely zero question that bash does this correctly,
and dash does not.
But yes, it seems to be easy to work around, but still - could some
Ubuntu person please open a bug report on dash?
Linus
next prev parent reply other threads:[~2021-03-15 19:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:03 [PATCH] gcov: fail build on gcov_info size mismatch Peter Oberparleiter
2021-03-11 18:38 ` Linus Torvalds
2021-03-12 17:46 ` Peter Oberparleiter
2021-03-11 19:33 ` kernel test robot
2021-03-11 19:33 ` kernel test robot
2021-03-11 20:02 ` Linus Torvalds
2021-03-11 20:02 ` Linus Torvalds
2021-03-12 3:49 ` [kbuild-all] " Rong Chen
2021-03-12 3:49 ` Rong Chen
2021-03-12 17:52 ` [kbuild-all] " Linus Torvalds
2021-03-12 17:52 ` Linus Torvalds
2021-03-15 2:31 ` [kbuild-all] " Rong Chen
2021-03-15 2:31 ` Rong Chen
2021-03-15 19:12 ` Linus Torvalds [this message]
2021-03-15 19:12 ` Linus Torvalds
2021-03-15 20:32 ` [kbuild-all] " Jamie Heilman
2021-03-15 20:32 ` Jamie Heilman
2021-03-15 20:57 ` [kbuild-all] " Linus Torvalds
2021-03-15 20:57 ` Linus Torvalds
2021-03-15 23:09 ` [kbuild-all] " Herbert Xu
2021-03-15 23:09 ` Herbert Xu
2021-03-15 23:22 ` [kbuild-all] " Linus Torvalds
2021-03-15 23:22 ` Linus Torvalds
2021-03-16 9:51 ` [kbuild-all] " Herbert Xu
2021-03-16 9:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg0DY=cE-6Tjp_Dt32UC6XtMZBa0Rr2GqkK=Sh9HE=5kQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oberpar@linux.ibm.com \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.