From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rong Chen <rong.a.chen@intel.com>
Cc: kernel test robot <lkp@intel.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Fri, 12 Mar 2021 09:52:59 -0800 [thread overview]
Message-ID: <CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com> (raw)
In-Reply-To: <db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com>
On Thu, Mar 11, 2021 at 7:50 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
>
> The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the
> error.
>
> + [ ! = .size -a ABI = .LPBX0, ]
> ./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
But that's not what the patch did.
The patch used quotes around $a, so "$a" should still be fine.
See:
[torvalds@ryzen ~]$ a="!" [ "$a" = ".size" ]
is fine, but
[torvalds@ryzen ~]$ a="!" [ $a = ".size" ]
-bash: [: =: unary operator expected
and the patch I saw, and that the test robot replied to, had that
correct quoting, afaik.
So I still don't see what the test robot is complaining about. Was
there an earlier version of the patch without the quotes that I didn't
see?
Or is the shell on the test robot doing something really really odd,
and it's somehow nds32-specific?
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Fri, 12 Mar 2021 09:52:59 -0800 [thread overview]
Message-ID: <CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com> (raw)
In-Reply-To: <db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com>
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
On Thu, Mar 11, 2021 at 7:50 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
>
> The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the
> error.
>
> + [ ! = .size -a ABI = .LPBX0, ]
> ./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
But that's not what the patch did.
The patch used quotes around $a, so "$a" should still be fine.
See:
[torvalds(a)ryzen ~]$ a="!" [ "$a" = ".size" ]
is fine, but
[torvalds(a)ryzen ~]$ a="!" [ $a = ".size" ]
-bash: [: =: unary operator expected
and the patch I saw, and that the test robot replied to, had that
correct quoting, afaik.
So I still don't see what the test robot is complaining about. Was
there an earlier version of the patch without the quotes that I didn't
see?
Or is the shell on the test robot doing something really really odd,
and it's somehow nds32-specific?
Linus
next prev parent reply other threads:[~2021-03-12 17:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:03 [PATCH] gcov: fail build on gcov_info size mismatch Peter Oberparleiter
2021-03-11 18:38 ` Linus Torvalds
2021-03-12 17:46 ` Peter Oberparleiter
2021-03-11 19:33 ` kernel test robot
2021-03-11 19:33 ` kernel test robot
2021-03-11 20:02 ` Linus Torvalds
2021-03-11 20:02 ` Linus Torvalds
2021-03-12 3:49 ` [kbuild-all] " Rong Chen
2021-03-12 3:49 ` Rong Chen
2021-03-12 17:52 ` Linus Torvalds [this message]
2021-03-12 17:52 ` Linus Torvalds
2021-03-15 2:31 ` [kbuild-all] " Rong Chen
2021-03-15 2:31 ` Rong Chen
2021-03-15 19:12 ` [kbuild-all] " Linus Torvalds
2021-03-15 19:12 ` Linus Torvalds
2021-03-15 20:32 ` [kbuild-all] " Jamie Heilman
2021-03-15 20:32 ` Jamie Heilman
2021-03-15 20:57 ` [kbuild-all] " Linus Torvalds
2021-03-15 20:57 ` Linus Torvalds
2021-03-15 23:09 ` [kbuild-all] " Herbert Xu
2021-03-15 23:09 ` Herbert Xu
2021-03-15 23:22 ` [kbuild-all] " Linus Torvalds
2021-03-15 23:22 ` Linus Torvalds
2021-03-16 9:51 ` [kbuild-all] " Herbert Xu
2021-03-16 9:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oberpar@linux.ibm.com \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.