All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Rong Chen <rong.a.chen@intel.com>,
	kernel test robot <lkp@intel.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kbuild-all@lists.01.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Mon, 15 Mar 2021 13:57:58 -0700	[thread overview]
Message-ID: <CAHk-=wj6OiV_sSZbqz-ZPnL7=NboN-3VQYM6brVCfq2px0EAqg@mail.gmail.com> (raw)
In-Reply-To: <YE/ERLHBdjJ19TYT@audible.transient.net>

On Mon, Mar 15, 2021 at 1:32 PM Jamie Heilman
<jamie@audible.transient.net> wrote:
>
> fwiw, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850202

Yup, that seems to be the exact same thing from 4 years ago.

But it looks like nothing ever came out of it. It probably stayed
within the Debian bugzilla, and didn't go to upstream dash
maintainers.

It does look like dash is actually actively maintained, and it's even
a kernel maintainer that does it: Herbert Xu seems to maintain the
dash tree and I see commits from January.

So maybe we can get it fixed by just cc'ing Herbert.

Herbert, easy test-case:

    $ [ "!" = ".size" ]

works, but

    $ [ "!"  = ".size" -a "b" = ".LPBX0," ]

causes

    dash: 6: [: =: unexpected operator

because for some reason that "-a" ends up (wild handwaving here about
what is going on) re-parsing the first expression, and ignoring the
quoting around "!" when it does so.

I verified that the bug still exists in that current dash source tree,
but I didn't dig any deeper than that "wild handwaving guess" as to
what is actually going on.

                Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] gcov: fail build on gcov_info size mismatch
Date: Mon, 15 Mar 2021 13:57:58 -0700	[thread overview]
Message-ID: <CAHk-=wj6OiV_sSZbqz-ZPnL7=NboN-3VQYM6brVCfq2px0EAqg@mail.gmail.com> (raw)
In-Reply-To: <YE/ERLHBdjJ19TYT@audible.transient.net>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Mon, Mar 15, 2021 at 1:32 PM Jamie Heilman
<jamie@audible.transient.net> wrote:
>
> fwiw, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850202

Yup, that seems to be the exact same thing from 4 years ago.

But it looks like nothing ever came out of it. It probably stayed
within the Debian bugzilla, and didn't go to upstream dash
maintainers.

It does look like dash is actually actively maintained, and it's even
a kernel maintainer that does it: Herbert Xu seems to maintain the
dash tree and I see commits from January.

So maybe we can get it fixed by just cc'ing Herbert.

Herbert, easy test-case:

    $ [ "!" = ".size" ]

works, but

    $ [ "!"  = ".size" -a "b" = ".LPBX0," ]

causes

    dash: 6: [: =: unexpected operator

because for some reason that "-a" ends up (wild handwaving here about
what is going on) re-parsing the first expression, and ignoring the
quoting around "!" when it does so.

I verified that the bug still exists in that current dash source tree,
but I didn't dig any deeper than that "wild handwaving guess" as to
what is actually going on.

                Linus

  reply	other threads:[~2021-03-15 20:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 13:03 [PATCH] gcov: fail build on gcov_info size mismatch Peter Oberparleiter
2021-03-11 18:38 ` Linus Torvalds
2021-03-12 17:46   ` Peter Oberparleiter
2021-03-11 19:33 ` kernel test robot
2021-03-11 19:33   ` kernel test robot
2021-03-11 20:02   ` Linus Torvalds
2021-03-11 20:02     ` Linus Torvalds
2021-03-12  3:49     ` [kbuild-all] " Rong Chen
2021-03-12  3:49       ` Rong Chen
2021-03-12 17:52       ` [kbuild-all] " Linus Torvalds
2021-03-12 17:52         ` Linus Torvalds
2021-03-15  2:31         ` [kbuild-all] " Rong Chen
2021-03-15  2:31           ` Rong Chen
2021-03-15 19:12           ` [kbuild-all] " Linus Torvalds
2021-03-15 19:12             ` Linus Torvalds
2021-03-15 20:32             ` [kbuild-all] " Jamie Heilman
2021-03-15 20:32               ` Jamie Heilman
2021-03-15 20:57               ` Linus Torvalds [this message]
2021-03-15 20:57                 ` Linus Torvalds
2021-03-15 23:09                 ` [kbuild-all] " Herbert Xu
2021-03-15 23:09                   ` Herbert Xu
2021-03-15 23:22                   ` [kbuild-all] " Linus Torvalds
2021-03-15 23:22                     ` Linus Torvalds
2021-03-16  9:51         ` [kbuild-all] " Herbert Xu
2021-03-16  9:51           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wj6OiV_sSZbqz-ZPnL7=NboN-3VQYM6brVCfq2px0EAqg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oberpar@linux.ibm.com \
    --cc=rong.a.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.